#708 apply strictier linting rules (#717)

* #708 apply strictier linting rules and fix simple eslint bugs

* #708 fix eslint errors relate to promise

* #708 fix eslint import/no-extraneous-dependencies

* #708 fix eslint errors of react-hook

* #708 enable eslint check for typescript

---------

Co-authored-by: lethemanh <lethemanh@lethemanhs-MacBook-Pro.local>
This commit is contained in:
lethemanh
2026-04-01 22:15:10 +07:00
committed by GitHub
parent 2bff6aae78
commit cadfa70e60
321 changed files with 27452 additions and 27600 deletions
+68 -68
View File
@@ -1,102 +1,102 @@
import { renderHook, act } from "@testing-library/react";
import { useUserSearch } from "@/components/Attendees/useUserSearch";
import { searchUsers } from "@/features/User/userAPI";
import { renderHook, act } from '@testing-library/react'
import { useUserSearch } from '@/components/Attendees/useUserSearch'
import { searchUsers } from '@/features/User/userAPI'
jest.mock("@/features/User/userAPI", () => ({
searchUsers: jest.fn(),
}));
jest.mock('@/features/User/userAPI', () => ({
searchUsers: jest.fn()
}))
describe("useUserSearch", () => {
const mockSearchUsers = searchUsers as jest.Mock;
describe('useUserSearch', () => {
const mockSearchUsers = searchUsers as jest.Mock
beforeEach(() => {
jest.useFakeTimers();
jest.clearAllMocks();
});
jest.useFakeTimers()
jest.clearAllMocks()
})
afterEach(() => {
jest.useRealTimers();
});
jest.useRealTimers()
})
it("should initialize with default values", () => {
it('should initialize with default values', () => {
const { result } = renderHook(() =>
useUserSearch({ objectTypes: ["user"], errorMessage: "Error" })
);
useUserSearch({ objectTypes: ['user'], errorMessage: 'Error' })
)
expect(result.current.query).toBe("");
expect(result.current.loading).toBe(false);
expect(result.current.options).toEqual([]);
expect(result.current.hasSearched).toBe(false);
expect(result.current.isOpen).toBe(false);
expect(result.current.inputError).toBeNull();
expect(result.current.snackbarOpen).toBe(false);
expect(result.current.snackbarMessage).toBe("");
});
expect(result.current.query).toBe('')
expect(result.current.loading).toBe(false)
expect(result.current.options).toEqual([])
expect(result.current.hasSearched).toBe(false)
expect(result.current.isOpen).toBe(false)
expect(result.current.inputError).toBeNull()
expect(result.current.snackbarOpen).toBe(false)
expect(result.current.snackbarMessage).toBe('')
})
it("should debounce and fetch users when query changes", async () => {
const mockUsers = [{ displayName: "John Doe", email: "john@example.com" }];
mockSearchUsers.mockResolvedValueOnce(mockUsers);
it('should debounce and fetch users when query changes', async () => {
const mockUsers = [{ displayName: 'John Doe', email: 'john@example.com' }]
mockSearchUsers.mockResolvedValueOnce(mockUsers)
const { result } = renderHook(() =>
useUserSearch({ objectTypes: ["user"], errorMessage: "Error" })
);
useUserSearch({ objectTypes: ['user'], errorMessage: 'Error' })
)
act(() => {
result.current.setQuery("John");
});
result.current.setQuery('John')
})
expect(result.current.loading).toBe(false); // Before debounce
expect(result.current.loading).toBe(false) // Before debounce
// Wait for the mock promise to resolve within act
await act(async () => {
jest.advanceTimersByTime(300);
await Promise.resolve(); // allow microtasks to flush
});
jest.advanceTimersByTime(300)
await Promise.resolve() // allow microtasks to flush
})
expect(mockSearchUsers).toHaveBeenCalledWith("John", ["user"]);
expect(result.current.loading).toBe(false);
expect(result.current.options).toEqual(mockUsers);
expect(result.current.hasSearched).toBe(true);
});
expect(mockSearchUsers).toHaveBeenCalledWith('John', ['user'])
expect(result.current.loading).toBe(false)
expect(result.current.options).toEqual(mockUsers)
expect(result.current.hasSearched).toBe(true)
})
it("should clear options and handle empty query", () => {
it('should clear options and handle empty query', () => {
const { result } = renderHook(() =>
useUserSearch({ objectTypes: ["user"], errorMessage: "Error" })
);
useUserSearch({ objectTypes: ['user'], errorMessage: 'Error' })
)
act(() => {
result.current.setQuery(" "); // empty query with spaces
});
result.current.setQuery(' ') // empty query with spaces
})
act(() => {
jest.advanceTimersByTime(300);
});
jest.advanceTimersByTime(300)
})
expect(mockSearchUsers).not.toHaveBeenCalled();
expect(result.current.options).toEqual([]);
expect(result.current.loading).toBe(false);
expect(result.current.hasSearched).toBe(false);
});
expect(mockSearchUsers).not.toHaveBeenCalled()
expect(result.current.options).toEqual([])
expect(result.current.loading).toBe(false)
expect(result.current.hasSearched).toBe(false)
})
it("should handle search errors and show the custom error message", async () => {
mockSearchUsers.mockRejectedValueOnce(new Error("API Error"));
it('should handle search errors and show the custom error message', async () => {
mockSearchUsers.mockRejectedValueOnce(new Error('API Error'))
const { result } = renderHook(() =>
useUserSearch({ objectTypes: ["user"], errorMessage: "Custom Error" })
);
useUserSearch({ objectTypes: ['user'], errorMessage: 'Custom Error' })
)
act(() => {
result.current.setQuery("FailedSearch");
});
result.current.setQuery('FailedSearch')
})
await act(async () => {
jest.advanceTimersByTime(300);
await Promise.resolve(); // allow microtasks to flush
});
jest.advanceTimersByTime(300)
await Promise.resolve() // allow microtasks to flush
})
expect(result.current.hasSearched).toBe(false);
expect(result.current.loading).toBe(false);
expect(result.current.snackbarOpen).toBe(true);
expect(result.current.snackbarMessage).toBe("Custom Error");
});
});
expect(result.current.hasSearched).toBe(false)
expect(result.current.loading).toBe(false)
expect(result.current.snackbarOpen).toBe(true)
expect(result.current.snackbarMessage).toBe('Custom Error')
})
})