#708 apply strictier linting rules (#717)

* #708 apply strictier linting rules and fix simple eslint bugs

* #708 fix eslint errors relate to promise

* #708 fix eslint import/no-extraneous-dependencies

* #708 fix eslint errors of react-hook

* #708 enable eslint check for typescript

---------

Co-authored-by: lethemanh <lethemanh@lethemanhs-MacBook-Pro.local>
This commit is contained in:
lethemanh
2026-04-01 22:15:10 +07:00
committed by GitHub
parent 2bff6aae78
commit cadfa70e60
321 changed files with 27452 additions and 27600 deletions
+88 -88
View File
@@ -1,120 +1,120 @@
import { createEventContext } from "@/features/Events/createEventContext";
import { Calendar } from "@/features/Calendars/CalendarTypes";
import { CalendarEvent } from "@/features/Events/EventsTypes";
import { userData } from "@/features/User/userDataTypes";
import { userAttendee } from "@/features/User/models/attendee";
import { createEventContext } from '@/features/Events/createEventContext'
import { Calendar } from '@/features/Calendars/CalendarTypes'
import { CalendarEvent } from '@/features/Events/EventsTypes'
import { userData } from '@/features/User/userDataTypes'
import { userAttendee } from '@/features/User/models/attendee'
const makeUser = (email: string): userData => ({
email,
given_name: "Alice",
family_name: "User",
name: "Alice User",
sid: "user1",
sub: "user1",
});
given_name: 'Alice',
family_name: 'User',
name: 'Alice User',
sid: 'user1',
sub: 'user1'
})
const makeEvent = (overrides: Partial<CalendarEvent> = {}): CalendarEvent =>
({
uid: "event-1",
calId: "user1/cal1",
title: "Test Event",
start: "2024-01-15T10:00:00",
end: "2024-01-15T11:00:00",
organizer: { cal_address: "alice@example.com" },
uid: 'event-1',
calId: 'user1/cal1',
title: 'Test Event',
start: '2024-01-15T10:00:00',
end: '2024-01-15T11:00:00',
organizer: { cal_address: 'alice@example.com' },
attendee: [
{ cal_address: "alice@example.com", partstat: "ACCEPTED" },
{ cal_address: "owner@example.com", partstat: "ACCEPTED" },
{ cal_address: "other@example.com", partstat: "NEEDS-ACTION" },
{ cal_address: 'alice@example.com', partstat: 'ACCEPTED' },
{ cal_address: 'owner@example.com', partstat: 'ACCEPTED' },
{ cal_address: 'other@example.com', partstat: 'NEEDS-ACTION' }
],
...overrides,
}) as CalendarEvent;
...overrides
}) as CalendarEvent
const makeCalendar = (overrides: Partial<Calendar> = {}): Calendar =>
({
id: "user1/cal1",
name: "Test Calendar",
id: 'user1/cal1',
name: 'Test Calendar',
delegated: false,
owner: { emails: ["alice@example.com"], firstname: "Alice" },
owner: { emails: ['alice@example.com'], firstname: 'Alice' },
events: {},
...overrides,
}) as Calendar;
...overrides
}) as Calendar
describe("createEventContext", () => {
describe("non-delegated calendar", () => {
const calendar = makeCalendar({ delegated: false });
const user = makeUser("alice@example.com");
describe('createEventContext', () => {
describe('non-delegated calendar', () => {
const calendar = makeCalendar({ delegated: false })
const user = makeUser('alice@example.com')
it("finds currentUserAttendee by logged-in user email", () => {
const event = makeEvent();
const ctx = createEventContext(event, calendar, user);
expect(ctx.currentUserAttendee?.cal_address).toBe("alice@example.com");
});
it('finds currentUserAttendee by logged-in user email', () => {
const event = makeEvent()
const ctx = createEventContext(event, calendar, user)
expect(ctx.currentUserAttendee?.cal_address).toBe('alice@example.com')
})
it("returns null currentUserAttendee when user is not an attendee", () => {
const event = makeEvent({ attendee: [] });
const ctx = createEventContext(event, calendar, user);
expect(ctx.currentUserAttendee).toBeUndefined();
});
it('returns null currentUserAttendee when user is not an attendee', () => {
const event = makeEvent({ attendee: [] })
const ctx = createEventContext(event, calendar, user)
expect(ctx.currentUserAttendee).toBeUndefined()
})
it("isOwn is true when user email is in owner emails", () => {
const ctx = createEventContext(makeEvent(), calendar, user);
expect(ctx.isOwn).toBe(true);
});
it('isOwn is true when user email is in owner emails', () => {
const ctx = createEventContext(makeEvent(), calendar, user)
expect(ctx.isOwn).toBe(true)
})
it("isOwn is false when user email is not in owner emails", () => {
const other = makeUser("other@example.com");
const ctx = createEventContext(makeEvent(), calendar, other);
expect(ctx.isOwn).toBe(false);
});
});
it('isOwn is false when user email is not in owner emails', () => {
const other = makeUser('other@example.com')
const ctx = createEventContext(makeEvent(), calendar, other)
expect(ctx.isOwn).toBe(false)
})
})
describe("delegated calendar", () => {
describe('delegated calendar', () => {
const calendar = makeCalendar({
id: "user2/cal1",
id: 'user2/cal1',
delegated: true,
owner: { emails: ["owner@example.com"], firstname: "Owner" },
});
const user = makeUser("alice@example.com"); // logged-in user, not the owner
owner: { emails: ['owner@example.com'], firstname: 'Owner' }
})
const user = makeUser('alice@example.com') // logged-in user, not the owner
it("finds currentUserAttendee by owner email, not logged-in user email", () => {
const event = makeEvent({ calId: "user2/cal1" });
const ctx = createEventContext(event, calendar, user);
expect(ctx.currentUserAttendee?.cal_address).toBe("owner@example.com");
});
it('finds currentUserAttendee by owner email, not logged-in user email', () => {
const event = makeEvent({ calId: 'user2/cal1' })
const ctx = createEventContext(event, calendar, user)
expect(ctx.currentUserAttendee?.cal_address).toBe('owner@example.com')
})
it("does not find logged-in user as attendee for delegated calendar", () => {
it('does not find logged-in user as attendee for delegated calendar', () => {
const event = makeEvent({
calId: "user2/cal1",
calId: 'user2/cal1',
attendee: [
{
cal_address: "owner@example.com",
partstat: "ACCEPTED",
} as userAttendee,
],
});
const ctx = createEventContext(event, calendar, user);
cal_address: 'owner@example.com',
partstat: 'ACCEPTED'
} as userAttendee
]
})
const ctx = createEventContext(event, calendar, user)
// currentUserAttendee should be owner's, not alice's
expect(ctx.currentUserAttendee?.cal_address).toBe("owner@example.com");
});
expect(ctx.currentUserAttendee?.cal_address).toBe('owner@example.com')
})
it("returns undefined currentUserAttendee when owner is not an attendee", () => {
it('returns undefined currentUserAttendee when owner is not an attendee', () => {
const event = makeEvent({
calId: "user2/cal1",
calId: 'user2/cal1',
attendee: [
{
cal_address: "alice@example.com",
partstat: "ACCEPTED",
} as userAttendee,
],
});
const ctx = createEventContext(event, calendar, user);
expect(ctx.currentUserAttendee).toBeUndefined();
});
cal_address: 'alice@example.com',
partstat: 'ACCEPTED'
} as userAttendee
]
})
const ctx = createEventContext(event, calendar, user)
expect(ctx.currentUserAttendee).toBeUndefined()
})
it("passes event through unchanged", () => {
const event = makeEvent({ calId: "user2/cal1" });
const ctx = createEventContext(event, calendar, user);
expect(ctx.event).toBe(event);
});
});
});
it('passes event through unchanged', () => {
const event = makeEvent({ calId: 'user2/cal1' })
const ctx = createEventContext(event, calendar, user)
expect(ctx.event).toBe(event)
})
})
})