From 150dadeab5f624b29c954a1ce2f962b09725e778 Mon Sep 17 00:00:00 2001
From: Eric Doughty-Papassideris <edoughtypapassideris@linagora.com>
Date: Sun, 8 Dec 2024 22:53:39 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=91=E2=80=8D=F0=9F=92=BB=20back:=20log?=
 =?UTF-8?q?=20diagnostic=20tool=20errors=20as=20last=20resort=20(#762)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../node/src/core/platform/framework/api/diagnostics.ts   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tdrive/backend/node/src/core/platform/framework/api/diagnostics.ts b/tdrive/backend/node/src/core/platform/framework/api/diagnostics.ts
index a4e31d80..d49e596d 100644
--- a/tdrive/backend/node/src/core/platform/framework/api/diagnostics.ts
+++ b/tdrive/backend/node/src/core/platform/framework/api/diagnostics.ts
@@ -1,5 +1,6 @@
 import assert from "node:assert";
 import config from "../../../config";
+import { logger } from "../logger";
 
 /**
  * Values that can match a set of diagnostic providers.
@@ -142,7 +143,7 @@ const runProvider = async provider => {
   const startMs = now();
   try {
     const result = await provider.get();
-    if (!result.ok || result.warn)
+    if (!result.ok)
       logger.error(
         { provider: provider.key, result },
         "Got diagnostic provider result with ok=false",
@@ -153,8 +154,9 @@ const runProvider = async provider => {
         "Got diagnostic provider result with ok=true but a warning",
       );
     return recordDiagnostic(startMs, provider.key, result);
-  } catch (error) {
-    return recordDiagnostic(startMs, provider.key, undefined, error);
+  } catch (err) {
+    logger.error({ err, provider: provider.key }, "Failed to read diagnostic provider");
+    return recordDiagnostic(startMs, provider.key, undefined, err);
   }
 };