eduvia/workavia-drive
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

🚨 front: linter empty function and react props warnings

Browse Source
This commit is contained in:
Eric Doughty-Papassideris
2024-11-11 00:52:17 +01:00
committed by ericlinagora
parent a2840f16ec
commit 1c2a56aaa1
4 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tdrive/frontend/src/app/views/client/body/drive/documents/common.tsx
-1
View File
@@ -15,7 +15,6 @@ export type DriveItemOverlayProps = {
item: DriveItem|null; item: DriveItem|null;
className: string; className: string;
}; };
export const menuBuilder = async () => {};
export const CheckableIcon = ({ export const CheckableIcon = ({
show, show,
tdrive/frontend/src/app/views/client/body/drive/modals/confirm-move/index.tsx
+2 -3
View File
@@ -11,7 +11,7 @@ export type ConfirmModalType = {
parent_id: string; parent_id: string;
mode: 'move' | 'select-file' | 'select-files'; mode: 'move' | 'select-file' | 'select-files';
title: string; title: string;
onSelected: (ids: string[]) => Promise<void>; onSelected?: (ids: string[]) => Promise<void>;
}; };
export const ConfirmModalAtom = atom<ConfirmModalType>({ export const ConfirmModalAtom = atom<ConfirmModalType>({
@@ -21,7 +21,6 @@ export const ConfirmModalAtom = atom<ConfirmModalType>({
parent_id: '', parent_id: '',
mode: 'move', mode: 'move',
title: '', title: '',
onSelected: async () => {},
}, },
}); });
@@ -40,7 +39,7 @@ const ConfirmModalContent = () => {
const handleClose = async () => { const handleClose = async () => {
setLoading(true); setLoading(true);
await state.onSelected(selected.map((i) => i.id)); state.onSelected && await state.onSelected(selected.map((i) => i.id));
setState({ ...state, open: false }); setState({ ...state, open: false });
setLoading(false); setLoading(false);
}; };
tdrive/frontend/src/app/views/client/body/drive/modals/selector/index.tsx
+2 -3
View File
@@ -15,7 +15,7 @@ export type SelectorModalType = {
parent_id: string; parent_id: string;
mode: 'move' | 'select-file' | 'select-files'; mode: 'move' | 'select-file' | 'select-files';
title: string; title: string;
onSelected: (ids: string[]) => Promise<void>; onSelected?: (ids: string[]) => Promise<void>;
}; };
export const SelectorModalAtom = atom<SelectorModalType>({ export const SelectorModalAtom = atom<SelectorModalType>({
@@ -25,7 +25,6 @@ export const SelectorModalAtom = atom<SelectorModalType>({
parent_id: '', parent_id: '',
mode: 'move', mode: 'move',
title: '', title: '',
onSelected: async () => {},
}, },
}); });
@@ -135,7 +134,7 @@ const SelectorModalContent = (key: any) => {
className="float-right" className="float-right"
onClick={async () => { onClick={async () => {
setLoading(true); setLoading(true);
await state.onSelected(selected.map(i => i.id)); state.onSelected && await state.onSelected(selected.map(i => i.id));
setState({ ...state, open: false }); setState({ ...state, open: false });
setLoading(false); setLoading(false);
}} }}
tdrive/frontend/src/app/views/client/viewer/drive-preview.tsx
+5 -1
View File
@@ -1,4 +1,5 @@
import { useEffect, useState } from 'react'; import { useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import { useHistory } from 'react-router-dom'; import { useHistory } from 'react-router-dom';
import { Transition } from '@headlessui/react'; import { Transition } from '@headlessui/react';
import { fadeTransition } from 'src/utils/transitions'; import { fadeTransition } from 'src/utils/transitions';
@@ -24,7 +25,6 @@ import Controls from './controls';
interface DrivePreviewProps { interface DrivePreviewProps {
items: DriveItem[]; items: DriveItem[];
} }
export const DrivePreview: React.FC<DrivePreviewProps> = ({ items }) => { export const DrivePreview: React.FC<DrivePreviewProps> = ({ items }) => {
const history = useHistory(); const history = useHistory();
const company = useRouterCompany(); const company = useRouterCompany();
@@ -64,6 +64,7 @@ export const DrivePreview: React.FC<DrivePreviewProps> = ({ items }) => {
useEffect(() => { useEffect(() => {
if (items.length < 2) if (items.length < 2)
// eslint-disable-next-line @typescript-eslint/no-empty-function
return () => {}; return () => {};
addShortcut({ shortcut: 'Right', handler: handleSwitchRight }); addShortcut({ shortcut: 'Right', handler: handleSwitchRight });
addShortcut({ shortcut: 'Left', handler: handleSwitchLeft }); addShortcut({ shortcut: 'Left', handler: handleSwitchLeft });
@@ -184,3 +185,6 @@ export const DrivePreview: React.FC<DrivePreviewProps> = ({ items }) => {
</Modal> </Modal>
); );
}; };
DrivePreview.propTypes = {
items: PropTypes.any.isRequired,
}