From 78caea4e925d1e3d47a0e8f0d636e306e1e7cf92 Mon Sep 17 00:00:00 2001
From: Montassar Ghanmy <Monta.ghanmy@gmail.com>
Date: Fri, 2 Jun 2023 10:08:39 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=8D=9E=20Improved=20path=20breadcrumb=20(?=
 =?UTF-8?q?#62)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .github/workflows/publish-frontend.yml        |   2 +-
 .../views/client/body/drive/header-path.tsx   | 119 ++++++++++++------
 2 files changed, 80 insertions(+), 41 deletions(-)

diff --git a/.github/workflows/publish-frontend.yml b/.github/workflows/publish-frontend.yml
index 8629f171..384290ea 100644
--- a/.github/workflows/publish-frontend.yml
+++ b/.github/workflows/publish-frontend.yml
@@ -22,7 +22,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x]
+        node-version: [16.x]
 
     steps:
       - uses: actions/checkout@v2
diff --git a/tdrive/frontend/src/app/views/client/body/drive/header-path.tsx b/tdrive/frontend/src/app/views/client/body/drive/header-path.tsx
index 590fb6f2..0b5507dd 100644
--- a/tdrive/frontend/src/app/views/client/body/drive/header-path.tsx
+++ b/tdrive/frontend/src/app/views/client/body/drive/header-path.tsx
@@ -1,4 +1,3 @@
-import { Button } from '@atoms/button/button';
 import { Title } from '@atoms/text';
 import { DriveItem } from '@features/drive/types';
 import { ChevronDownIcon } from '@heroicons/react/solid';
@@ -33,18 +32,48 @@ export const PathRender = ({
   inTrash: boolean;
   onClick: (id: string) => void;
 }) => {
+  const pathLength = (path || []).reduce((acc, curr) => acc + curr.name.length, 0);
   return (
-    <Title className="overflow-hidden whitespace-nowrap mr-2 pl-px inline-flex">
-      {(path || [])?.map((a, i) => (
-        <PathItem
-          key={a.id}
-          item={a}
-          first={i === 0}
-          last={i + 1 === path?.length}
-          onClick={onClick}
-        />
-      ))}
-    </Title>
+    <nav className="overflow-hidden whitespace-nowrap mr-2 pl-px inline-flex">
+      {pathLength < 70 ? (
+        (path || [])?.map((a, i) => (
+          <PathItem
+            key={a.id}
+            item={a}
+            first={i === 0}
+            last={i + 1 === path?.length}
+            onClick={onClick}
+          />
+        ))
+      ) : (
+        <>
+          <PathItem
+            key={path[path.length - 3]?.id}
+            item={{
+              ...path[path?.length - 3],
+              name: '...',
+            }}
+            first={true}
+            last={false}
+            onClick={onClick}
+          />
+          <PathItem
+            key={path[path.length - 2]?.id}
+            item={path[path?.length - 2]}
+            first={false}
+            last={false}
+            onClick={onClick}
+          />
+          <PathItem
+            key={path[path.length - 1]?.id}
+            item={path[path?.length - 1]}
+            first={false}
+            last={true}
+            onClick={onClick}
+          />
+        </>
+      )}
+    </nav>
   );
 };
 
@@ -61,40 +90,50 @@ const PathItem = ({
 }) => {
   const { user } = useCurrentUser();
   return (
-    <Button
-      theme={last ? 'primary' : 'default'}
-      className={
-        '-ml-px shrink overflow-hidden whitespace-nowrap last:flex-[1_0_auto_!important] first:flex-[0_0_auto] first:flex-shrink-0 ' +
-        (!first ? 'rounded-l-none ' : '') +
-        (!last ? 'rounded-r-none ' : '') +
-        (!first && !last ? 'max-w-[15ch] ' : '')
-      }
-      onClick={evt => {
-        if (first) {
-          MenusManager.openMenu(
-            [
-              { type: 'menu', text: 'Home', onClick: () => onClick('root') },
-              { type: 'menu', text: 'My Drive', onClick: () => onClick('user_' + user?.id) },
-            ],
-            { x: evt.clientX, y: evt.clientY },
-            'center',
-          );
-        } else {
-          onClick(item?.id || '');
-        }
-      }}
-    >
-      <span className="text-ellipsis overflow-hidden whitespace-nowrap" style={{ maxWidth: 120 }}>
-        {item?.name || ''}
-      </span>
+    <div className="flex items-center">
+      <a
+        href="#"
+        className="text-sm font-medium text-gray-700 hover:text-blue-600 dark:text-gray-400 dark:hover:text-white"
+        onClick={evt => {
+          if (first) {
+            MenusManager.openMenu(
+              [
+                { type: 'menu', text: 'Home', onClick: () => onClick('root') },
+                { type: 'menu', text: 'My Drive', onClick: () => onClick('user_' + user?.id) },
+              ],
+              { x: evt.clientX, y: evt.clientY },
+              'center',
+            );
+          } else {
+            onClick(item?.id || '');
+          }
+        }}
+      >
+        <Title>{item?.name || ''}</Title>
+      </a>
       {item?.access_info?.public?.level && item?.access_info?.public?.level !== 'none' && (
         <PublicIcon className="h-5 w-5 ml-2" />
       )}
       {first && (
-        <span className="ml-2 -mr-1">
+        <span className="ml-2 -mr-1 text-gray-700">
           <ChevronDownIcon className="w-4 h-4" />
         </span>
       )}
-    </Button>
+      {!last && (
+        <svg
+          aria-hidden="true"
+          className="w-6 h-6 text-gray-400 mx-1"
+          fill="currentColor"
+          viewBox="0 0 20 20"
+          xmlns="http://www.w3.org/2000/svg"
+        >
+          <path
+            fillRule="evenodd"
+            d="M7.293 14.707a1 1 0 010-1.414L10.586 10 7.293 6.707a1 1 0 011.414-1.414l4 4a1 1 0 010 1.414l-4 4a1 1 0 01-1.414 0z"
+            clipRule="evenodd"
+          ></path>
+        </svg>
+      )}
+    </div>
   );
 };