♻️Removed console.log from backend node + error serializer

This commit is contained in:
Anton SHEPILOV
2024-11-01 11:51:06 +01:00
committed by Anton Shepilov
parent 01744274eb
commit da9736e23b
19 changed files with 121 additions and 139 deletions
@@ -12,6 +12,12 @@ export const logger = pino({
mixin() {
return executionStorage.getStore() ? executionStorage.getStore() : {};
},
formatters: {
level(label: string) {
return { level: label.toUpperCase() };
},
},
serializers: pino.stdSerializers,
});
export const getLogger = (name?: string): TdriveLogger =>
@@ -28,7 +28,7 @@ export async function buildDependenciesTree(
`The component dependency ${dependencyName} has not been found for component ${name}`,
);
} else {
console.warn(
logger.warn(
`(warning) The component dependency ${dependencyName} has not been found for component ${name} it will be imported asynchronously`,
);
@@ -209,7 +209,7 @@ export default class MongoSearch extends SearchAdapter implements SearchAdapterI
const { query, sort, project } = buildSearchQuery<EntityType>(entityType, filters, options);
logger.info(`Search query: ${JSON.stringify(query)}`);
console.log(query);
logger.info(query);
const sortMapped: any = sort
? Object.fromEntries(
@@ -1,6 +1,7 @@
import { buildSelectQuery } from "../../../database/services/orm/connectors/mongodb/query-builder";
import { EntityTarget, FindFilter, FindOptions, getEntityDefinition } from "../../api";
import { asciiFold } from "../utils";
import { logger } from "../../../../framework";
export function buildSearchQuery<Entity>(
entityType: EntityTarget<Entity>,
@@ -15,7 +16,7 @@ export function buildSearchQuery<Entity>(
try {
query = buildSelectQuery(entityType, filters, options);
} catch (e) {
console.log(e);
logger.info(e);
}
let sort: any = {};
@@ -1,6 +1,7 @@
import Analytics, { IdentifyParams, TrackParams } from "@segment/analytics-node";
import { Analytics as AnalyticsAbtract } from "./types";
import axios, { AxiosInstance } from "axios";
import { logger } from "../../../framework/logger";
export default class Segment implements AnalyticsAbtract {
protected version = "5.0.0"; //Segment analytics lib version
@@ -33,7 +34,7 @@ export default class Segment implements AnalyticsAbtract {
try {
this.analytics.identify(message as IdentifyParams, callback);
} catch (err) {
console.error(err);
logger.error(err);
}
}
@@ -47,7 +48,7 @@ export default class Segment implements AnalyticsAbtract {
try {
this.analytics.track(message as TrackParams, callback);
} catch (err) {
console.error(err);
logger.error(err);
}
}
@@ -1,8 +1,9 @@
import { FastifyInstance } from "fastify";
import { logger } from "../../framework/logger";
function serverErrorHandler(server: FastifyInstance): void {
server.setErrorHandler(async (err, request, reply) => {
console.error(`Got ${reply.statusCode} error on request ${request.id} : `, err);
logger.error(`Got ${reply.statusCode} error on request ${request.id} : `, err);
server.log.debug(`Got ${reply.statusCode} error on request ${request.id} : ${err.toString()}`);
await reply.send(
reply.statusCode == 500
@@ -1,4 +1,4 @@
import { Initializable, TdriveServiceProvider } from "../../../core/platform/framework";
import { Initializable, logger, TdriveServiceProvider } from "../../../core/platform/framework";
import { ListResult, Paginable } from "../../../core/platform/framework/api/crud-service";
import gr from "../../global-resolver";
import {
@@ -39,7 +39,7 @@ export class CompanyApplicationServiceImpl implements TdriveServiceProvider, Ini
app.application.api = null;
return app;
} catch (err) {
console.error(err);
logger.error(err);
return null;
}
}
@@ -285,7 +285,7 @@ export const getAccessLevel = async (
);
if (matchingChannel) return matchingChannel.level;
} catch (e) {
console.log(e);
logger.info(e);
}
}
@@ -406,7 +406,7 @@ export const getSharedByUser = (
return getGrantorAndThrowIfEmpty(entity);
}
if (entity.type === "company" && entity.id === context.company.id && entity.level != "none") {
console.log("company", entity);
logger.info("company", entity);
return getGrantorAndThrowIfEmpty(entity);
}
}
@@ -47,7 +47,7 @@ export class DocumentsProcessor
);
content_keywords = await getKeywordsOfFile(storedFile.mime, storedFile.name, storedFile.file);
} catch (error) {
console.debug(error);
logger.debug(error);
logger.error({ error: `${error}` }, "Failed to generate content keywords");
}
return { content_keywords, item: message.item };
@@ -470,7 +470,7 @@ export class DocumentsService {
}
}
} catch (error) {
console.error("🚀🚀 error:", error);
logger.error(error, "🚀🚀 error:");
}
await this.repository.save(driveItem);
@@ -6,6 +6,7 @@ import { UploadOptions } from "../../types";
import { PublicFile } from "../../entities/file";
import gr from "../../../global-resolver";
import { formatAttachmentContentDispositionHeader } from "../../utils";
import { logger } from "../../../../core/platform/framework";
export class FileController {
async save(
@@ -54,7 +55,7 @@ export class FileController {
response.type(data.mime);
return response.send(data.file);
} catch (e) {
console.log("!!!" + e);
logger.info(e);
throw e;
}
}
@@ -80,7 +81,7 @@ export class FileController {
response.send(data.file);
return response;
} catch (err) {
console.log(err);
logger.error(err);
response.statusCode = 500;
response.send("");
}
@@ -1,6 +1,9 @@
import { fromPath } from "pdf2pic";
import { mkdirSync } from "fs";
import { cleanFiles, getTmpFile } from "../../../../../utils/files";
import { logger } from "../../../../../core/platform/framework";
class PDFConversionError extends Error {}
export async function convertFromPdf(
inputPath: string,
@@ -33,11 +36,12 @@ export async function convertFromPdf(
//Just no more page to convert
}
} catch (error) {
console.error(error);
const pdfConversionError = new PDFConversionError("Can't convert file with pdf-image.", { cause: error });
logger.error(pdfConversionError);
for (const file of pages) {
cleanFiles([file]);
}
throw Error("Can't convert file with pdf-image.");
throw pdfConversionError;
}
return { output: pages, done: true };
}
@@ -7,6 +7,7 @@ import {
CompanyStatsObject,
CompanyUserObject,
} from "./web/types";
import { logger } from "../../core/platform/framework";
export function formatCompany(
companyEntity: Company,
@@ -75,6 +76,8 @@ export function formatCompany(
},
);
logger.info("🚀🚀 res.plan.features: ", res.plan.features);
return res;
}
@@ -490,7 +490,7 @@ export class WorkspaceServiceImpl implements TdriveServiceProvider, Initializabl
}
}
} catch (err) {
console.log(err);
logger.warn(err);
}
}
}
@@ -35,6 +35,7 @@ import WorkspacePendingUser from "../../entities/workspace_pending_users";
import { ConsoleCompany, CreateConsoleUser } from "../../../console/types";
import { hasCompanyAdminLevel } from "../../../../utils/company";
import gr from "../../../global-resolver";
import { logger } from "../../../../core/platform/framework";
export class WorkspaceUsersCrudController
implements
@@ -525,7 +526,7 @@ export class WorkspaceUsersCrudController
return { status: "success" };
} catch (e) {
console.error(e);
logger.warn(e);
return {
status: "error",
};
+2 -1
View File
@@ -1,6 +1,7 @@
import { mkdirSync, existsSync, promises as fsPromise, createWriteStream, readFileSync } from "fs";
import { Readable } from "stream";
import { v4 as uuidv4 } from "uuid";
import { logger } from "../core/platform/framework";
const { unlink } = fsPromise;
@@ -50,7 +51,7 @@ export const writeToTemporaryFile = async (input: Readable, extension: string):
return temporaryFilePath;
} catch (error) {
console.debug(error);
logger.debug(error);
throw Error(error);
}