TF-3334 Skip getting stored state in interactor when performing actions with email and mailbox

lib/features/mailbox/domain/state/mark_as_mailbox_read_state.dart

@@ -39,7 +39,7 @@ class MarkAsMailboxReadAllSuccess extends UIActionState {
   ];
 }
 
-class MarkAsMailboxReadHasSomeEmailFailure extends UIActionState {
+class MarkAsMailboxReadHasSomeEmailFailure extends UIState {
 
   final String mailboxDisplayName;
   final int countEmailsRead;
@@ -47,17 +47,12 @@ class MarkAsMailboxReadHasSomeEmailFailure extends UIActionState {
   MarkAsMailboxReadHasSomeEmailFailure(
     this.mailboxDisplayName,
     this.countEmailsRead,
-    {
-      jmap.State? currentEmailState,
-      jmap.State? currentMailboxState,
-    }
-  ) : super(currentMailboxState, currentEmailState);
+  );
 
   @override
   List<Object?> get props => [
     mailboxDisplayName,
     countEmailsRead,
-    ...super.props
   ];
 }
 

lib/features/mailbox/domain/state/move_mailbox_state.dart

@@ -1,13 +1,11 @@
 import 'package:core/presentation/state/failure.dart';
 import 'package:core/presentation/state/success.dart';
 import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart';
-import 'package:tmail_ui_user/features/base/state/ui_action_state.dart';
 import 'package:tmail_ui_user/features/email/domain/model/move_action.dart';
-import 'package:jmap_dart_client/jmap/core/state.dart' as jmap;
 
 class LoadingMoveMailbox extends UIState {}
 
-class MoveMailboxSuccess extends UIActionState {
+class MoveMailboxSuccess extends UIState {
 
   final MailboxId mailboxIdSelected;
   final MoveAction moveAction;
@@ -22,10 +20,8 @@ class MoveMailboxSuccess extends UIActionState {
       this.parentId,
       this.destinationMailboxId,
       this.destinationMailboxDisplayName,
-      jmap.State? currentEmailState,
-      jmap.State? currentMailboxState,
     }
-  ) : super(currentEmailState, currentMailboxState);
+  );
 
   @override
   List<Object?> get props => [
@@ -34,7 +30,6 @@ class MoveMailboxSuccess extends UIActionState {
     parentId,
     destinationMailboxId,
     destinationMailboxDisplayName,
-    ...super.props
   ];
 }
 

lib/features/mailbox/domain/state/rename_mailbox_state.dart

@@ -1,17 +1,9 @@
 import 'package:core/presentation/state/failure.dart';
 import 'package:core/presentation/state/success.dart';
-import 'package:tmail_ui_user/features/base/state/ui_action_state.dart';
-import 'package:jmap_dart_client/jmap/core/state.dart' as jmap;
 
 class LoadingRenameMailbox extends UIState {}
 
-class RenameMailboxSuccess extends UIActionState {
-
-  RenameMailboxSuccess({
-    jmap.State? currentEmailState,
-    jmap.State? currentMailboxState,
-  }) : super(currentEmailState, currentMailboxState);
-}
+class RenameMailboxSuccess extends UIState {}
 
 class RenameMailboxFailure extends FeatureFailure {
 

lib/features/mailbox/domain/usecases/mark_as_mailbox_read_interactor.dart

@@ -1,19 +1,18 @@
 import 'dart:async';
 
-import 'package:core/core.dart';
+import 'package:core/presentation/state/failure.dart';
+import 'package:core/presentation/state/success.dart';
 import 'package:dartz/dartz.dart';
 import 'package:jmap_dart_client/jmap/account_id.dart';
 import 'package:jmap_dart_client/jmap/core/session/session.dart';
 import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart';
-import 'package:tmail_ui_user/features/email/domain/repository/email_repository.dart';
 import 'package:tmail_ui_user/features/mailbox/domain/repository/mailbox_repository.dart';
 import 'package:tmail_ui_user/features/mailbox/domain/state/mark_as_mailbox_read_state.dart';
 
 class MarkAsMailboxReadInteractor {
   final MailboxRepository _mailboxRepository;
-  final EmailRepository _emailRepository;
 
-  MarkAsMailboxReadInteractor(this._mailboxRepository, this._emailRepository);
+  MarkAsMailboxReadInteractor(this._mailboxRepository);
 
   Stream<Either<Failure, Success>> execute(
     Session session,
@@ -27,14 +26,6 @@ class MarkAsMailboxReadInteractor {
       yield Right<Failure, Success>(MarkAsMailboxReadLoading());
       onProgressController.add(Right(MarkAsMailboxReadLoading()));
 
-      final listState = await Future.wait([
-        _mailboxRepository.getMailboxState(session, accountId),
-        _emailRepository.getEmailState(session, accountId),
-      ], eagerError: true);
-
-      final currentMailboxState = listState.first;
-      final currentEmailState = listState.last;
-
       final listEmails = await _mailboxRepository.markAsMailboxRead(
         session,
         accountId,
@@ -43,16 +34,12 @@ class MarkAsMailboxReadInteractor {
         onProgressController);
 
       if (totalEmailUnread == listEmails.length) {
-        yield Right(MarkAsMailboxReadAllSuccess(
-          mailboxDisplayName,
-          currentEmailState: currentEmailState,
-          currentMailboxState: currentMailboxState));
+        yield Right(MarkAsMailboxReadAllSuccess(mailboxDisplayName));
       } else if (listEmails.isNotEmpty) {
         yield Right(MarkAsMailboxReadHasSomeEmailFailure(
           mailboxDisplayName,
           listEmails.length,
-          currentEmailState: currentEmailState,
-          currentMailboxState: currentMailboxState));
+        ));
       } else {
         yield Left(MarkAsMailboxReadAllFailure(mailboxDisplayName: mailboxDisplayName));
       }

lib/features/mailbox/domain/usecases/move_mailbox_interactor.dart

@@ -1,4 +1,5 @@
-import 'package:core/core.dart';
+import 'package:core/presentation/state/failure.dart';
+import 'package:core/presentation/state/success.dart';
 import 'package:dartz/dartz.dart';
 import 'package:jmap_dart_client/jmap/account_id.dart';
 import 'package:jmap_dart_client/jmap/core/session/session.dart';
@@ -14,8 +15,6 @@ class MoveMailboxInteractor {
   Stream<Either<Failure, Success>> execute(Session session, AccountId accountId, MoveMailboxRequest request) async* {
     try {
       yield Right<Failure, Success>(LoadingMoveMailbox());
-
-      final currentMailboxState = await _mailboxRepository.getMailboxState(session, accountId);
       final result = await _mailboxRepository.moveMailbox(session, accountId, request);
       if (result) {
         yield Right<Failure, Success>(MoveMailboxSuccess(
@@ -24,7 +23,7 @@ class MoveMailboxInteractor {
             parentId: request.parentId,
             destinationMailboxId: request.destinationMailboxId,
             destinationMailboxDisplayName: request.destinationMailboxDisplayName,
-            currentMailboxState: currentMailboxState));
+        ));
       } else {
         yield Left<Failure, Success>(MoveMailboxFailure(null));
       }

lib/features/mailbox/domain/usecases/rename_mailbox_interactor.dart

@@ -1,4 +1,5 @@
-import 'package:core/core.dart';
+import 'package:core/presentation/state/failure.dart';
+import 'package:core/presentation/state/success.dart';
 import 'package:dartz/dartz.dart';
 import 'package:jmap_dart_client/jmap/account_id.dart';
 import 'package:jmap_dart_client/jmap/core/session/session.dart';
@@ -15,17 +16,13 @@ class RenameMailboxInteractor {
   Stream<Either<Failure, Success>> execute(Session session, AccountId accountId, RenameMailboxRequest request) async* {
     try {
       yield Right<Failure, Success>(LoadingRenameMailbox());
-
-      final currentMailboxState = await _mailboxRepository.getMailboxState(session, accountId);
-      log('RenameMailboxInteractor::execute:currentMailboxState: $currentMailboxState');
       final result = await _mailboxRepository.renameMailbox(session, accountId, request);
       if (result) {
-        yield Right<Failure, Success>(RenameMailboxSuccess(currentMailboxState: currentMailboxState));
+        yield Right<Failure, Success>(RenameMailboxSuccess());
       } else {
         yield Left<Failure, Success>(RenameMailboxFailure(null));
       }
     } catch (e) {
-      logError('RenameMailboxInteractor::execute(): error: $e');
       final exception = SetMailboxNameException.detectMailboxNameException(e, request.mailboxId);
       yield Left<Failure, Success>(RenameMailboxFailure(exception));
     }