eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-3333 Remove Mailbox/query & Mailbox/get when performing display spam banner

Browse Source
This commit is contained in:
dab246
2024-12-19 16:51:30 +07:00
committed by Dat H. Pham
parent e386848af8
commit 091d52e635
12 changed files with 25 additions and 286 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/mailbox_dashboard/presentation/bindings/mailbox_dashboard_bindings.dart
-13
View File
@@ -52,14 +52,11 @@ import 'package:tmail_ui_user/features/mailbox/domain/usecases/mark_as_mailbox_r
import 'package:tmail_ui_user/features/mailbox/presentation/mailbox_bindings.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource/search_datasource.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource/session_storage_composer_datasource.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource/spam_report_datasource.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource_impl/hive_spam_report_datasource_impl.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource_impl/local_spam_report_datasource_impl.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource_impl/search_datasource_impl.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource_impl/session_storage_composer_datasoure_impl.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/datasource_impl/spam_report_datasource_impl.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/local/local_spam_report_manager.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/network/spam_report_api.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/repository/composer_cache_repository_impl.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/repository/search_repository_impl.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/repository/spam_report_repository_impl.dart';
@@ -71,7 +68,6 @@ import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_app
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_composer_cache_on_web_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_spam_mailbox_cached_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_spam_report_state_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_unread_spam_mailbox_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/quick_search_email_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/remove_composer_cache_on_web_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/remove_email_drafts_interactor.dart';
@@ -153,7 +149,6 @@ class MailboxDashBoardBindings extends BaseBindings {
Get.put(SpamReportController(
Get.find<StoreSpamReportInteractor>(),
Get.find<GetUnreadSpamMailboxInteractor>(),
Get.find<StoreSpamReportStateInteractor>(),
Get.find<GetSpamReportStateInteractor>(),
Get.find<GetSpamMailboxCachedInteractor>()));
@@ -198,7 +193,6 @@ class MailboxDashBoardBindings extends BaseBindings {
Get.lazyPut<PrintFileDataSource>(() => Get.find<PrintFileDataSourceImpl>());
Get.lazyPut<MailboxDataSource>(() => Get.find<MailboxDataSourceImpl>());
Get.lazyPut<SessionStorageComposerDatasource>(() => Get.find<SessionStorageComposerDatasourceImpl>());
Get.lazyPut<SpamReportDataSource>(() => Get.find<SpamReportDataSourceImpl>());
Get.lazyPut<MailboxDataSource>(() => Get.find<MailboxDataSourceImpl>());
Get.lazyPut<MailboxCacheDataSourceImpl>(() => Get.find<MailboxCacheDataSourceImpl>());
Get.lazyPut<ServerSettingsDataSource>(
@@ -244,10 +238,6 @@ class MailboxDashBoardBindings extends BaseBindings {
Get.lazyPut(() => SessionStorageComposerDatasourceImpl(
Get.find<HtmlTransform>(),
Get.find<CacheExceptionThrower>()));
Get.lazyPut(() => SpamReportDataSourceImpl(
Get.find<SpamReportApi>(),
Get.find<RemoteExceptionThrower>(),
));
Get.lazyPut(() => LocalSpamReportDataSourceImpl(
Get.find<LocalSpamReportManager>(),
Get.find<CacheExceptionThrower>(),
@@ -306,8 +296,6 @@ class MailboxDashBoardBindings extends BaseBindings {
Get.find<EmailRepository>()));
Get.lazyPut(() => StoreSpamReportInteractor(
Get.find<SpamReportRepository>()));
Get.lazyPut(() => GetUnreadSpamMailboxInteractor(
Get.find<SpamReportRepository>()));
Get.lazyPut(() => StoreSpamReportStateInteractor(
Get.find<SpamReportRepository>()));
Get.lazyPut(() => GetSpamReportStateInteractor(
@@ -376,7 +364,6 @@ class MailboxDashBoardBindings extends BaseBindings {
Get.lazyPut(() => ComposerCacheRepositoryImpl(Get.find<SessionStorageComposerDatasource>()));
Get.lazyPut(() => SpamReportRepositoryImpl(
{
DataSourceType.network: Get.find<SpamReportDataSource>(),
DataSourceType.local: Get.find<LocalSpamReportDataSourceImpl>(),
DataSourceType.hiveCache: Get.find<HiveSpamReportDataSourceImpl>()
},
lib/features/mailbox_dashboard/presentation/controller/mailbox_dashboard_controller.dart
+15 -5
View File
@@ -2112,15 +2112,25 @@ class MailboxDashBoardController extends ReloadableController with UserSettingPo
bool get enableSpamReport => spamReportController.enableSpamReport;
void getSpamReportBanner() {
if (spamReportController.enableSpamReport &&
sessionCurrent != null &&
accountId.value != null) {
spamReportController.getSpamMailboxAction(sessionCurrent!, accountId.value!);
if (enableSpamReport) {
final spamId = spamMailboxId;
if (spamId == null) {
spamReportController.setSpamPresentationMailbox(null);
return;
}
final spamMailbox = mapMailboxById[spamId];
final unreadEmails = spamMailbox?.unreadEmails?.value.value ?? 0;
if (unreadEmails > 0) {
spamReportController.setSpamPresentationMailbox(spamMailbox);
} else {
spamReportController.setSpamPresentationMailbox(null);
}
}
}
void refreshSpamReportBanner() {
if (spamReportController.enableSpamReport && sessionCurrent != null && accountId.value != null) {
if (enableSpamReport && sessionCurrent != null && accountId.value != null) {
spamReportController.getSpamMailboxCached(accountId.value!, sessionCurrent!.username);
}
}
lib/features/mailbox_dashboard/presentation/controller/spam_report_controller.dart
+7 -21
View File
@@ -3,31 +3,25 @@ import 'package:core/presentation/state/success.dart';
import 'package:flutter/cupertino.dart';
import 'package:get/get.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
import 'package:jmap_dart_client/jmap/core/session/session.dart';
import 'package:jmap_dart_client/jmap/core/user_name.dart';
import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart';
import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox_filter_condition.dart';
import 'package:model/extensions/mailbox_extension.dart';
import 'package:model/extensions/presentation_mailbox_extension.dart';
import 'package:model/mailbox/presentation_mailbox.dart';
import 'package:tmail_ui_user/features/base/base_controller.dart';
import 'package:tmail_ui_user/features/mailbox/presentation/extensions/presentation_mailbox_extension.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/model/spam_report_state.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/state/get_number_of_unread_spam_emails_state.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/state/get_spam_mailbox_cached_state.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/state/get_spam_report_state.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/state/store_last_time_dismissed_spam_reported_state.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/state/store_spam_report_state.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_spam_mailbox_cached_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_spam_report_state_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/get_unread_spam_mailbox_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/store_last_time_dismissed_spam_reported_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/store_spam_report_state_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/controller/mailbox_dashboard_controller.dart';
class SpamReportController extends BaseController {
final StoreSpamReportInteractor _storeSpamReportInteractor;
final GetUnreadSpamMailboxInteractor _getNumberOfUnreadSpamEmailsInteractor;
final StoreSpamReportStateInteractor _storeSpamReportStateInteractor;
final GetSpamReportStateInteractor _getSpamReportStateInteractor;
final GetSpamMailboxCachedInteractor _getSpamMailboxCachedInteractor;
@@ -37,7 +31,6 @@ class SpamReportController extends BaseController {
SpamReportController(
this._storeSpamReportInteractor,
this._getNumberOfUnreadSpamEmailsInteractor,
this._storeSpamReportStateInteractor,
this._getSpamReportStateInteractor,
this._getSpamMailboxCachedInteractor
@@ -46,9 +39,7 @@ class SpamReportController extends BaseController {
@override
void handleSuccessViewState(Success success) {
super.handleSuccessViewState(success);
if (success is GetUnreadSpamMailboxSuccess){
presentationSpamMailbox.value = success.unreadSpamMailbox.toPresentationMailbox();
} else if (success is StoreLastTimeDismissedSpamReportSuccess) {
if (success is StoreLastTimeDismissedSpamReportSuccess) {
presentationSpamMailbox.value = null;
} else if (success is GetSpamReportStateSuccess) {
spamReportState.value = success.spamReportState;
@@ -62,9 +53,7 @@ class SpamReportController extends BaseController {
@override
void handleFailureViewState(Failure failure) {
super.handleFailureViewState(failure);
if (failure is GetUnreadSpamMailboxFailure ||
failure is GetSpamMailboxCachedFailure ||
failure is InvalidSpamReportCondition) {
if (failure is GetSpamMailboxCachedFailure) {
presentationSpamMailbox.value = null;
}
}
@@ -91,13 +80,6 @@ class SpamReportController extends BaseController {
}
}
void getSpamMailboxAction(Session session, AccountId accountId) {
consumeState(_getNumberOfUnreadSpamEmailsInteractor.execute(
session,
accountId,
mailboxFilterCondition: MailboxFilterCondition(role: Role('Spam'))));
}
void getSpamMailboxCached(AccountId accountId, UserName userName) {
consumeState(_getSpamMailboxCachedInteractor.execute(accountId, userName));
}
@@ -121,6 +103,10 @@ class SpamReportController extends BaseController {
}
void getSpamReportStateAction() {
consumeState(_getSpamReportStateInteractor.execute());
consumeState(_getSpamReportStateInteractor.execute());
}
void setSpamPresentationMailbox(PresentationMailbox? spamMailbox) {
presentationSpamMailbox.value = spamMailbox;
}
}