eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-4329 Fix rogue mailbox set request for favorite

Browse Source
This commit is contained in:
dab246
2026-02-12 10:12:17 +07:00
committed by Dat H. Pham
parent cfec32a2c1
commit 0db3845133
3 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/mailbox/presentation/mailbox_controller.dart
+4 -1
View File
@@ -891,7 +891,10 @@ class MailboxController extends BaseMailboxController
void goToCreateNewMailboxView(BuildContext context, {PresentationMailbox? parentMailbox}) async { void goToCreateNewMailboxView(BuildContext context, {PresentationMailbox? parentMailbox}) async {
if (session != null && accountId != null) { if (session != null && accountId != null) {
final arguments = MailboxCreatorArguments(allMailboxes, parentMailbox); final arguments = MailboxCreatorArguments(
allMailboxes.withoutVirtualMailbox,
parentMailbox,
);
final result = PlatformInfo.isWeb final result = PlatformInfo.isWeb
? await DialogRouter().pushGeneralDialog(routeName: AppRoutes.mailboxCreator, arguments: arguments) ? await DialogRouter().pushGeneralDialog(routeName: AppRoutes.mailboxCreator, arguments: arguments)
lib/features/search/mailbox/presentation/search_mailbox_controller.dart
+5 -1
View File
@@ -15,6 +15,7 @@ import 'package:jmap_dart_client/jmap/core/session/session.dart';
import 'package:jmap_dart_client/jmap/core/state.dart' as jmap; import 'package:jmap_dart_client/jmap/core/state.dart' as jmap;
import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart'; import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart';
import 'package:model/email/presentation_email.dart'; import 'package:model/email/presentation_email.dart';
import 'package:model/extensions/list_presentation_mailbox_extension.dart';
import 'package:model/extensions/presentation_email_extension.dart'; import 'package:model/extensions/presentation_email_extension.dart';
import 'package:model/mailbox/presentation_mailbox.dart'; import 'package:model/mailbox/presentation_mailbox.dart';
import 'package:tmail_ui_user/features/base/base_mailbox_controller.dart'; import 'package:tmail_ui_user/features/base/base_mailbox_controller.dart';
@@ -824,7 +825,10 @@ class SearchMailboxController extends BaseMailboxController with MailboxActionHa
void goToCreateNewMailboxView(BuildContext context, {PresentationMailbox? parentMailbox}) async { void goToCreateNewMailboxView(BuildContext context, {PresentationMailbox? parentMailbox}) async {
if (session != null && accountId != null) { if (session != null && accountId != null) {
final arguments = MailboxCreatorArguments(allMailboxes, parentMailbox); final arguments = MailboxCreatorArguments(
allMailboxes.withoutVirtualMailbox,
parentMailbox,
);
final result = PlatformInfo.isWeb final result = PlatformInfo.isWeb
? await DialogRouter().pushGeneralDialog(routeName: AppRoutes.mailboxCreator, arguments: arguments) ? await DialogRouter().pushGeneralDialog(routeName: AppRoutes.mailboxCreator, arguments: arguments)
model/lib/extensions/list_presentation_mailbox_extension.dart
+4 -1
View File
@@ -1,4 +1,4 @@
import 'package:collection/collection.dart';
import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart'; import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart';
import 'package:model/extensions/presentation_mailbox_extension.dart'; import 'package:model/extensions/presentation_mailbox_extension.dart';
import 'package:model/mailbox/presentation_mailbox.dart'; import 'package:model/mailbox/presentation_mailbox.dart';
@@ -18,4 +18,7 @@ extension ListPresentationMailboxExtension on List<PresentationMailbox> {
bool get isAllUnreadMailboxes => every((mailbox) => mailbox.countUnReadEmailsAsString.isNotEmpty); bool get isAllUnreadMailboxes => every((mailbox) => mailbox.countUnReadEmailsAsString.isNotEmpty);
List<MailboxId> get mailboxIds => map((mailbox) => mailbox.id).toList(); List<MailboxId> get mailboxIds => map((mailbox) => mailbox.id).toList();
List<PresentationMailbox> get withoutVirtualMailbox =>
whereNot((mailbox) => mailbox.isVirtualFolder).toList();
} }