TF-4236 Implement remove a label from an thread

2026-01-09 19:49:21 +07:00
parent b37359af03
commit 1058b94363
23 changed files with 402 additions and 47 deletions
@@ -20,6 +20,20 @@ import 'package:tmail_ui_user/features/thread_detail/presentation/widgets/thread
 extension GetThreadDetailEmailViews on ThreadDetailController {
  List<Widget> getThreadDetailEmailViews({List<Label>? labels}) {
    final loadMoreSegments = Map<LoadMoreIndex, LoadMoreCount>.from(this.loadMoreSegments);
+    PresentationEmail? emailDisplayLabel;
+
+    final lastEmail = emailIdsPresentation.values.lastOrNull;
+
+    if (currentExpandedEmailId.value == null) {
+      emailDisplayLabel = lastEmail;
+    } else  {
+      emailDisplayLabel = emailIdsPresentation[currentExpandedEmailId.value];
+    }
+
+    final emailLabels = _getLabelsForEmail(
+      email: emailDisplayLabel,
+      availableLabels: labels,
+    );

    return emailIdsPresentation.entries.map((entry) {
      final emailId = entry.key;
@@ -48,14 +62,6 @@ extension GetThreadDetailEmailViews on ThreadDetailController {
      final isFirstEmailInThreadDetail = indexOfEmailId == 0;

      if (presentationEmail.emailInThreadStatus == EmailInThreadStatus.collapsed) {
-        final lastEmail = emailIdsPresentation.values.last;
-
-        final emailLabels = _getLabelsForFirstEmail(
-          lastEmail: lastEmail,
-          isFirstEmailInThreadDetail: isFirstEmailInThreadDetail,
-          availableLabels: labels,
-        );
-
        return ThreadDetailCollapsedEmail(
          presentationEmail: presentationEmail.copyWith(
            subject: isFirstEmailInThreadDetail
@@ -77,10 +83,10 @@ extension GetThreadDetailEmailViews on ThreadDetailController {
          onToggleThreadDetailCollapseExpand: () {
            toggleThreadDetailCollapseExpand(presentationEmail);
          },
-          onDeleteLabelAction: (label) => removeLabelFromEmail(
-            lastEmail!.id!,
-            label,
-          ),
+          onDeleteLabelAction: (label) {
+            if (emailDisplayLabel?.id == null) return;
+            removeLabelFromEmail(emailDisplayLabel!.id!, label);
+          },
        );
      }

@@ -92,7 +98,7 @@ extension GetThreadDetailEmailViews on ThreadDetailController {
          isInsideThreadDetailView: true,
          emailId: presentationEmail.id,
          isFirstEmailInThreadDetail: true,
-          threadSubject: emailIdsPresentation.values.last?.subject,
+          threadSubject: lastEmail?.subject,
          onToggleThreadDetailCollapseExpand: () {
            toggleThreadDetailCollapseExpand(presentationEmail);
          },
@@ -120,17 +126,15 @@ extension GetThreadDetailEmailViews on ThreadDetailController {
    }).toList();
  }

-  List<Label>? _getLabelsForFirstEmail({
-    required PresentationEmail? lastEmail,
-    required bool isFirstEmailInThreadDetail,
+  List<Label>? _getLabelsForEmail({
+    required PresentationEmail? email,
    required List<Label>? availableLabels,
  }) {
-    if (!isFirstEmailInThreadDetail ||
-        availableLabels == null ||
+    if (availableLabels == null ||
        availableLabels.isEmpty) {
      return null;
    }

-    return lastEmail?.getLabelList(availableLabels);
+    return email?.getLabelList(availableLabels);
  }
 }
@@ -13,6 +13,7 @@ import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/extensions
 import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/extensions/update_current_emails_flags_extension.dart';
 import 'package:tmail_ui_user/features/thread/domain/extensions/presentation_email_map_extension.dart';
 import 'package:tmail_ui_user/features/thread_detail/domain/extensions/list_email_in_thread_detail_info_extension.dart';
+import 'package:tmail_ui_user/features/thread_detail/presentation/extension/labels/remove_label_from_thread_extension.dart';
 import 'package:tmail_ui_user/features/thread_detail/presentation/thread_detail_controller.dart';
 import 'package:tmail_ui_user/main/routes/dialog_router.dart';

@@ -48,18 +49,25 @@ extension AddLabelToThreadExtension on ThreadDetailController {
    bool isSelected, {
    List<EmailId>? currentEmailIds,
  }) {
-    if (isSelected) {
-      final accountId = mailboxDashBoardController.accountId.value;
-      final session = mailboxDashBoardController.sessionCurrent;
-      final emailIds =
-          currentEmailIds ?? emailsInThreadDetailInfo.emailIdsToDisplay(true);
+    final accountId = mailboxDashBoardController.accountId.value;
+    final session = mailboxDashBoardController.sessionCurrent;
+    final emailIds =
+        currentEmailIds ?? emailsInThreadDetailInfo.emailIdsToDisplay(true);

+    if (isSelected) {
      _addALabelToAThread(
        session: session,
        accountId: accountId,
        emailIds: emailIds,
        label: label,
      );
+    } else {
+      removeALabelFromAThread(
+        session: session,
+        accountId: accountId,
+        emailIds: emailIds,
+        label: label,
+      );
    }
  }

@@ -120,7 +128,7 @@ extension AddLabelToThreadExtension on ThreadDetailController {
  void handleAddLabelToThreadSuccess(AddALabelToAThreadSuccess success) {
    toastManager.showMessageSuccess(success);

-    _autoSyncLabelToThreadOnMemory(
+    autoSyncLabelToThreadOnMemory(
      emailIds: success.emailIds,
      labelKeyword: success.labelKeyword,
    );
@@ -130,52 +138,81 @@ extension AddLabelToThreadExtension on ThreadDetailController {
    toastManager.showMessageFailure(failure);
  }

-  void _autoSyncLabelToThreadOnMemory({
+  void autoSyncLabelToThreadOnMemory({
    required List<EmailId> emailIds,
    required KeyWordIdentifier labelKeyword,
+    bool remove = false,
  }) {
    _updateLabelInThreadOnMemory(
      emailIds: emailIds,
      labelKeyword: labelKeyword,
+      remove: remove,
    );
  }

  void _updateLabelInThreadOnMemory({
    required List<EmailId> emailIds,
    required KeyWordIdentifier labelKeyword,
+    required bool remove,
  }) {
+    _updateEmailsInThread(emailIds, labelKeyword, remove);
+    _updateCurrentLoadedEmailIfNeeded(emailIds, labelKeyword, remove);
+    _updateMailboxDashboard(emailIds, labelKeyword, remove);
+    _refreshLabelSettingState();
+  }
+
+  void _updateEmailsInThread(
+    List<EmailId> emailIds,
+    KeyWordIdentifier labelKeyword,
+    bool remove,
+  ) {
    emailIdsPresentation.value =
        emailIdsPresentation.toggleListEmailsKeywordByIds(
      emailIds: emailIds,
      keyword: labelKeyword,
-      remove: false,
+      remove: remove,
    );

    emailsInThreadDetailInfo.value =
        emailsInThreadDetailInfo.toggleListEmailsKeywordByIds(
      emailIds: emailIds,
      keyword: labelKeyword,
-      remove: false,
+      remove: remove,
    );
+  }

+  void _updateCurrentLoadedEmailIfNeeded(
+    List<EmailId> emailIds,
+    KeyWordIdentifier labelKeyword,
+    bool remove,
+  ) {
    final emailLoaded = currentEmailLoaded.value;
    final emailLoadedId = emailLoaded?.emailCurrent?.id;
-    if (emailLoaded != null &&
-        emailLoadedId != null &&
-        emailIds.contains(emailLoadedId)) {
-      currentEmailLoaded.value = emailLoaded.toggleEmailKeyword(
-        emailId: emailLoadedId,
-        keyword: labelKeyword,
-        remove: false,
-      );
+
+    if (emailLoadedId == null || !emailIds.contains(emailLoadedId)) {
+      return;
    }

+    currentEmailLoaded.value = emailLoaded!.toggleEmailKeyword(
+      emailId: emailLoadedId,
+      keyword: labelKeyword,
+      remove: remove,
+    );
+  }
+
+  void _updateMailboxDashboard(
+    List<EmailId> emailIds,
+    KeyWordIdentifier labelKeyword,
+    bool remove,
+  ) {
    mailboxDashBoardController.updateEmailFlagByEmailIds(
      emailIds,
-      isLabelAdded: true,
+      isLabelAdded: !remove,
      labelKeyword: labelKeyword,
    );
+  }

+  void _refreshLabelSettingState() {
    mailboxDashBoardController.labelController.isLabelSettingEnabled.refresh();
  }
 }
@@ -0,0 +1,80 @@
+import 'package:jmap_dart_client/jmap/account_id.dart';
+import 'package:jmap_dart_client/jmap/core/session/session.dart';
+import 'package:jmap_dart_client/jmap/mail/email/email.dart';
+import 'package:labels/labels.dart';
+import 'package:tmail_ui_user/features/email/domain/state/labels/remove_a_label_from_an_thread_state.dart';
+import 'package:tmail_ui_user/features/home/data/exceptions/session_exceptions.dart';
+import 'package:tmail_ui_user/features/labels/domain/exceptions/label_exceptions.dart';
+import 'package:tmail_ui_user/features/thread_detail/presentation/extension/labels/add_label_to_thread_extension.dart';
+import 'package:tmail_ui_user/features/thread_detail/presentation/thread_detail_controller.dart';
+
+extension RemoveLabelFromThreadExtension on ThreadDetailController {
+  void removeALabelFromAThread({
+    required Session? session,
+    required AccountId? accountId,
+    required Label label,
+    required List<EmailId> emailIds,
+  }) {
+    final labelDisplay = label.safeDisplayName;
+
+    if (session == null) {
+      emitFailure(
+        controller: this,
+        failure: RemoveALabelFromAThreadFailure(
+          exception: NotFoundSessionException(),
+          labelDisplay: labelDisplay,
+        ),
+      );
+      return;
+    }
+
+    if (accountId == null) {
+      emitFailure(
+        controller: this,
+        failure: RemoveALabelFromAThreadFailure(
+          exception: NotFoundAccountIdException(),
+          labelDisplay: labelDisplay,
+        ),
+      );
+      return;
+    }
+
+    final labelKeyword = label.keyword;
+    if (labelKeyword == null) {
+      emitFailure(
+        controller: this,
+        failure: RemoveALabelFromAThreadFailure(
+          exception: LabelKeywordIsNull(),
+          labelDisplay: labelDisplay,
+        ),
+      );
+      return;
+    }
+
+    consumeState(removeALabelFromAThreadInteractor.execute(
+      session,
+      accountId,
+      emailIds,
+      labelKeyword,
+      label.safeDisplayName,
+    ));
+  }
+
+  void handleRemoveLabelFromThreadSuccess(
+    RemoveALabelFromAThreadSuccess success,
+  ) {
+    toastManager.showMessageSuccess(success);
+
+    autoSyncLabelToThreadOnMemory(
+      emailIds: success.emailIds,
+      labelKeyword: success.labelKeyword,
+      remove: true,
+    );
+  }
+
+  void handleRemoveLabelFromThreadFailure(
+    RemoveALabelFromAThreadFailure failure,
+  ) {
+    toastManager.showMessageFailure(failure);
+  }
+}
@@ -4,6 +4,7 @@ import 'package:jmap_dart_client/http/http_client.dart';
 import 'package:tmail_ui_user/features/base/base_bindings.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/add_a_label_to_a_thread_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/get_email_content_interactor.dart';
+import 'package:tmail_ui_user/features/email/domain/usecases/labels/remove_a_label_from_a_thread_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/mark_as_email_read_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/mark_as_star_email_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/print_email_interactor.dart';
@@ -47,6 +48,7 @@ class ThreadDetailBindings extends BaseBindings {
      Get.find<MarkAsStarMultipleEmailInteractor>(),
      Get.find<MarkAsMultipleEmailReadInteractor>(),
      Get.find<AddALabelToAThreadInteractor>(),
+      Get.find<RemoveALabelFromAThreadInteractor>(),
    ));
  }

@@ -17,10 +17,12 @@ import 'package:model/extensions/keyword_identifier_extension.dart';
 import 'package:model/mailbox/presentation_mailbox.dart';
 import 'package:tmail_ui_user/features/base/base_controller.dart';
 import 'package:tmail_ui_user/features/email/domain/state/add_a_label_to_an_thread_state.dart';
+import 'package:tmail_ui_user/features/email/domain/state/labels/remove_a_label_from_an_thread_state.dart';
 import 'package:tmail_ui_user/features/email/domain/state/mark_as_email_read_state.dart';
 import 'package:tmail_ui_user/features/email/domain/state/print_email_state.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/add_a_label_to_a_thread_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/get_email_content_interactor.dart';
+import 'package:tmail_ui_user/features/email/domain/usecases/labels/remove_a_label_from_a_thread_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/mark_as_email_read_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/mark_as_star_email_interactor.dart';
 import 'package:tmail_ui_user/features/email/domain/usecases/print_email_interactor.dart';
@@ -52,6 +54,7 @@ import 'package:tmail_ui_user/features/thread_detail/presentation/extension/hand
 import 'package:tmail_ui_user/features/thread_detail/presentation/extension/handle_refresh_thread_detail_action.dart';
 import 'package:tmail_ui_user/features/thread_detail/presentation/extension/initialize_thread_detail_emails.dart';
 import 'package:tmail_ui_user/features/thread_detail/presentation/extension/labels/add_label_to_thread_extension.dart';
+import 'package:tmail_ui_user/features/thread_detail/presentation/extension/labels/remove_label_from_thread_extension.dart';
 import 'package:tmail_ui_user/features/thread_detail/presentation/extension/mark_collapsed_email_unread_success.dart';
 import 'package:tmail_ui_user/features/thread_detail/presentation/extension/quick_create_rule_from_collapsed_email_success.dart';
 import 'package:tmail_ui_user/features/thread_detail/presentation/extension/thread_detail_on_selected_email_updated.dart';
@@ -70,6 +73,7 @@ class ThreadDetailController extends BaseController {
  final MarkAsStarMultipleEmailInteractor markAsStarMultipleEmailInteractor;
  final MarkAsMultipleEmailReadInteractor markAsMultipleEmailReadInteractor;
  final AddALabelToAThreadInteractor addALabelToAThreadInteractor;
+  final RemoveALabelFromAThreadInteractor removeALabelFromAThreadInteractor;

  ThreadDetailController(
    this._getEmailIdsByThreadIdInteractor,
@@ -81,6 +85,7 @@ class ThreadDetailController extends BaseController {
    this.markAsStarMultipleEmailInteractor,
    this.markAsMultipleEmailReadInteractor,
    this.addALabelToAThreadInteractor,
+    this.removeALabelFromAThreadInteractor,
  );

  final emailIdsPresentation = <EmailId, PresentationEmail?>{}.obs;
@@ -267,6 +272,8 @@ class ThreadDetailController extends BaseController {
      quickCreateRuleFromCollapsedEmailSuccess(success);
    } else if (success is AddALabelToAThreadSuccess) {
      handleAddLabelToThreadSuccess(success);
+    } else if (success is RemoveALabelFromAThreadSuccess) {
+      handleRemoveLabelFromThreadSuccess(success);
    } else {
      super.handleSuccessViewState(success);
    }
@@ -291,6 +298,8 @@ class ThreadDetailController extends BaseController {
      toastManager.showMessageFailure(failure as FeatureFailure);
    } else if (failure is AddALabelToAThreadFailure) {
      handleAddLabelToThreadFailure(failure);
+    } else if (failure is RemoveALabelFromAThreadFailure) {
+      handleRemoveLabelFromThreadFailure(failure);
    } else {
      super.handleFailureViewState(failure);
    }
@@ -64,7 +64,7 @@ class ThreadDetailCollapsedEmail extends StatelessWidget {
          children: [
            if (showSubject)
              EmailSubjectWidget(
-                presentationEmail: presentationEmail,
+                emailSubject: presentationEmail.getEmailTitle(),
                imagePaths: imagePaths,
                isMobileResponsive: isMobileResponsive,
                labels: labels,