From 20c97778193a3e25bf0216859faf454f6b10d7a0 Mon Sep 17 00:00:00 2001 From: dab246 Date: Mon, 28 Aug 2023 18:34:16 +0700 Subject: [PATCH] Fix TextEditingController was used after being disposed in LoginView (cherry picked from commit 16d0c8b5db6e5829836a87afb66769698236c837) --- lib/features/base/base_controller.dart | 11 ++++------- lib/features/login/presentation/login_bindings.dart | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/features/base/base_controller.dart b/lib/features/base/base_controller.dart index b3555b5b1..d4aef2fb7 100644 --- a/lib/features/base/base_controller.dart +++ b/lib/features/base/base_controller.dart @@ -279,13 +279,10 @@ abstract class BaseController extends GetxController bool _isFcmActivated(Session session, AccountId accountId) => [FirebaseCapability.fcmIdentifier].isSupported(session, accountId) && AppConfig.fcmAvailable; - void goToLogin({LoginArguments? arguments}) async { - await Future.delayed( - const Duration(milliseconds: 500), - () async { - await pushAndPopAll(AppRoutes.login, arguments: arguments); - } - ); + void goToLogin({LoginArguments? arguments}) { + if (Get.currentRoute != AppRoutes.login) { + pushAndPopAll(AppRoutes.login, arguments: arguments); + } } void logout(Session? session, AccountId? accountId) { diff --git a/lib/features/login/presentation/login_bindings.dart b/lib/features/login/presentation/login_bindings.dart index 7b32bfed1..28d27ac9d 100644 --- a/lib/features/login/presentation/login_bindings.dart +++ b/lib/features/login/presentation/login_bindings.dart @@ -54,7 +54,7 @@ class LoginBindings extends BaseBindings { @override void bindingsController() { - Get.lazyPut(() => LoginController( + Get.create(() => LoginController( Get.find(), Get.find(), Get.find(),