TF-1487 Apply linter rule

lib/features/manage_account/presentation/email_rules/email_rules_controller.dart

@@ -271,8 +271,9 @@ class EmailRulesController extends BaseController {
   Widget _deleteEmailRuleActionTile(BuildContext context, TMailRule rule) {
     return (EmailRuleBottomSheetActionTileBuilder(
       const Key('delete_emailRule_action'),
-      SvgPicture.asset(_imagePaths.icDeleteComposer,
-          color: AppColor.colorActionDeleteConfirmDialog),
+      SvgPicture.asset(
+        _imagePaths.icDeleteComposer,
+        colorFilter: AppColor.colorActionDeleteConfirmDialog.asFilter()),
       AppLocalizations.of(context).deleteRule,
       rule,
       iconLeftPadding: const EdgeInsets.only(left: 12, right: 16),

lib/features/manage_account/presentation/forward/forward_view.dart

@@ -140,7 +140,7 @@ class ForwardView extends GetWidget<ForwardController> with AppLoaderMixin {
             _imagePaths.icNotConnection,
             width: 24,
             height: 24,
-            color: Colors.white,
+            colorFilter: Colors.white.asFilter(),
             fit: BoxFit.fill),
           backgroundColor: AppColor.toastErrorBackgroundColor,
           textColor: Colors.white,

lib/features/manage_account/presentation/forward/widgets/email_forward_item_widget.dart

@@ -31,7 +31,7 @@ class EmailForwardItemWidget extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final _imagePaths = Get.find<ImagePaths>();
+    final imagePaths = Get.find<ImagePaths>();
 
     return Padding(
       padding: const EdgeInsets.only(top: 4),
@@ -53,7 +53,7 @@ class EmailForwardItemWidget extends StatelessWidget {
                 recipientForward.selectMode == SelectMode.ACTIVE ? 12 : 0))
             ),
             child: Row(children: [
-              _buildAvatarIcon(_imagePaths),
+              _buildAvatarIcon(imagePaths),
               const SizedBox(width: 12),
               Expanded(child: Column(
                 mainAxisSize: MainAxisSize.min,
@@ -92,7 +92,7 @@ class EmailForwardItemWidget extends StatelessWidget {
                 buildIconWeb(
                   iconSize: 30,
                   splashRadius: 20,
-                  icon: SvgPicture.asset(_imagePaths.icDeleteRecipient),
+                  icon: SvgPicture.asset(imagePaths.icDeleteRecipient),
                   onTap: () => onDeleteRecipientCallback?.call(recipientForward)
                 )
             ]),

lib/features/manage_account/presentation/forward/widgets/list_email_forward_widget.dart

@@ -82,6 +82,7 @@ class ListEmailForwardsWidget extends GetWidget<ForwardController> {
       color: Colors.transparent,
       child: InkWell(
         customBorder: const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(5))),
+        onTap: controller.selectAllRecipientForward,
         child: Padding(
           padding: const EdgeInsets.symmetric(vertical: 8, horizontal: 12),
           child: Text(
@@ -93,7 +94,6 @@ class ListEmailForwardsWidget extends GetWidget<ForwardController> {
             )
           ),
         ),
-        onTap: controller.selectAllRecipientForward,
       )
     );
   }
@@ -107,7 +107,7 @@ class ListEmailForwardsWidget extends GetWidget<ForwardController> {
           buildIconWeb(
             icon: SvgPicture.asset(
               _imagePaths.icCloseComposer,
-              color: AppColor.colorTextButton,
+              colorFilter: AppColor.colorTextButton.asFilter(),
               fit: BoxFit.fill),
             tooltip: AppLocalizations.of(context).cancel,
             onTap: controller.cancelSelectionMode

lib/features/manage_account/presentation/mailbox_visibility/mailbox_visibility_controller.dart

@@ -96,10 +96,10 @@ class MailboxVisibilityController extends BaseMailboxController {
 
   @override
   void onReady() {
-    final _session = _accountDashBoardController.sessionCurrent.value;
-    final _accountId = _accountDashBoardController.accountId.value;
-    if(_session != null && _accountId != null) {
-      getAllMailbox(_session, _accountId);
+    final session = _accountDashBoardController.sessionCurrent.value;
+    final accountId = _accountDashBoardController.accountId.value;
+    if(session != null && accountId != null) {
+      getAllMailbox(session, accountId);
     }
     super.onReady();
   }
@@ -111,22 +111,22 @@ class MailboxVisibilityController extends BaseMailboxController {
   }
 
   void subscribeMailbox(MailboxNode mailboxNode) {
-    final _mailboxSubscribeState = mailboxNode.item.isSubscribedMailbox
+    final mailboxSubscribeState = mailboxNode.item.isSubscribedMailbox
       ? MailboxSubscribeState.disabled : MailboxSubscribeState.enabled;
-    final _mailboxSubscribeStateAction = mailboxNode.item.isSubscribedMailbox
+    final mailboxSubscribeStateAction = mailboxNode.item.isSubscribedMailbox
       ? MailboxSubscribeAction.unSubscribe : MailboxSubscribeAction.subscribe;
     _subscribeMailboxAction(
         SubscribeMailboxRequest(
           mailboxNode.item.id,
-          _mailboxSubscribeState,
-          _mailboxSubscribeStateAction,
+          mailboxSubscribeState,
+          mailboxSubscribeStateAction,
         )
     );
   }
 
   void _subscribeMailboxAction(SubscribeMailboxRequest subscribeMailboxRequest) {
-    final _accountId = _accountDashBoardController.accountId.value;
-    if (_accountId != null) {
+    final accountId = _accountDashBoardController.accountId.value;
+    if (accountId != null) {
       final subscribeRequest = generateSubscribeRequest(
         subscribeMailboxRequest.mailboxId,
         subscribeMailboxRequest.subscribeState,
@@ -134,9 +134,9 @@ class MailboxVisibilityController extends BaseMailboxController {
       );
 
       if (subscribeRequest is SubscribeMultipleMailboxRequest) {
-        consumeState(_subscribeMultipleMailboxInteractor!.execute(_accountId, subscribeRequest));
+        consumeState(_subscribeMultipleMailboxInteractor!.execute(accountId, subscribeRequest));
       } else if (subscribeRequest is SubscribeMailboxRequest) {
-        consumeState(_subscribeMailboxInteractor!.execute(_accountId, subscribeRequest));
+        consumeState(_subscribeMailboxInteractor!.execute(accountId, subscribeRequest));
       }
     }
   }
@@ -196,11 +196,11 @@ class MailboxVisibilityController extends BaseMailboxController {
   }
 
   void _refreshMailboxChanges(jmap.State? newMailboxState) {
-    final _session = _accountDashBoardController.sessionCurrent.value;
-    final _accountId = _accountDashBoardController.accountId.value;
+    final session = _accountDashBoardController.sessionCurrent.value;
+    final accountId = _accountDashBoardController.accountId.value;
     final mailboxState = newMailboxState ?? currentMailboxState;
-    if (_session != null && _accountId != null && mailboxState != null) {
-      refreshMailboxChanges(_session, _accountId, mailboxState);
+    if (session != null && accountId != null && mailboxState != null) {
+      refreshMailboxChanges(session, accountId, mailboxState);
     }
   }
 
@@ -224,7 +224,7 @@ class MailboxVisibilityController extends BaseMailboxController {
             _imagePaths.icFolderMailbox,
             width: 24,
             height: 24,
-            color: Colors.white,
+            colorFilter: Colors.white.asFilter(),
             fit: BoxFit.fill
           ),
           backgroundColor: AppColor.toastSuccessBackgroundColor,

lib/features/manage_account/presentation/mailbox_visibility/widgets/mailbox_visibility_folder_tile_builder.dart

@@ -62,9 +62,9 @@ class MailBoxVisibilityFolderTileBuilder extends StatelessWidget {
               _mailboxNode.expandMode == ExpandMode.EXPAND
                 ? _imagePaths.icExpandFolder
                 : _imagePaths.icCollapseFolder,
-              color: _mailboxNode.item.allowedToDisplay
-                ? AppColor.primaryColor
-                : AppColor.colorIconUnSubscribedMailbox,
+              colorFilter: _mailboxNode.item.allowedToDisplay
+                ? AppColor.primaryColor.asFilter()
+                : AppColor.colorIconUnSubscribedMailbox.asFilter(),
               fit: BoxFit.fill
             ),
             tooltip: _mailboxNode.expandMode == ExpandMode.EXPAND
@@ -120,9 +120,9 @@ class MailBoxVisibilityFolderTileBuilder extends StatelessWidget {
         _mailboxNode.item.getMailboxIcon(_imagePaths),
         width: 20,
         height: 20,
-        color: _mailboxNode.item.allowedToDisplay
-          ? AppColor.primaryColor
-          : AppColor.colorIconUnSubscribedMailbox,
+        colorFilter: _mailboxNode.item.allowedToDisplay
+          ? AppColor.primaryColor.asFilter()
+          : AppColor.colorIconUnSubscribedMailbox.asFilter(),
         fit: BoxFit.fill
       ),
     );

lib/features/manage_account/presentation/manage_account_dashboard_view.dart

@@ -77,7 +77,7 @@ class ManageAccountDashBoardView extends GetWidget<ManageAccountDashBoardControl
                 Expanded(child: Row(
                   crossAxisAlignment: CrossAxisAlignment.start,
                   children: [
-                    SizedBox(child: ManageAccountMenuView(), width: ResponsiveUtils.defaultSizeMenu),
+                    SizedBox(width: ResponsiveUtils.defaultSizeMenu, child: ManageAccountMenuView()),
                     Expanded(child: Container(
                       color: AppColor.colorBgDesktop,
                       child: Column(children: [

lib/features/manage_account/presentation/menu/settings/settings_view.dart

@@ -134,7 +134,7 @@ class SettingsView extends GetWidget<SettingsController> {
                       _imagePaths.icBack,
                       width: 18,
                       height: 18,
-                      color: AppColor.colorTextButton,
+                      colorFilter: AppColor.colorTextButton.asFilter(),
                       fit: BoxFit.fill),
                   Container(
                     margin: const EdgeInsets.only(left: 8),

lib/features/manage_account/presentation/menu/widgets/setting_first_level_tile_builder.dart

@@ -30,7 +30,7 @@ class SettingFirstLevelTileBuilder extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return InkWell(child: Padding(
+    return InkWell(onTap: clickAction,child: Padding(
       padding: const EdgeInsets.only(top: 24, bottom: 24),
       child: Row(
         children: [
@@ -76,11 +76,10 @@ class SettingFirstLevelTileBuilder extends StatelessWidget {
            icon: SvgPicture.asset(
              _imagePath.icCollapseFolder,
              fit: BoxFit.fill,
-             color: AppColor.colorCollapseMailbox),
+             colorFilter: AppColor.colorCollapseMailbox.asFilter()),
            onPressed: clickAction
         )
       ])),
-      onTap: clickAction,
     );
   }
 

lib/features/manage_account/presentation/vacation/vacation_controller.dart

@@ -179,7 +179,7 @@ class VacationController extends BaseController {
                       onPrimary: Colors.white,
                       onSurface: Colors.black),
                   textButtonTheme: TextButtonThemeData(
-                      style: TextButton.styleFrom(primary: AppColor.primaryColor))),
+                      style: TextButton.styleFrom(foregroundColor: AppColor.primaryColor))),
               child: child!);
         }
     );
@@ -207,7 +207,7 @@ class VacationController extends BaseController {
               onPrimary: Colors.white,
               onSurface: Colors.black),
             textButtonTheme: TextButtonThemeData(
-              style: TextButton.styleFrom(primary: AppColor.primaryColor))),
+              style: TextButton.styleFrom(foregroundColor: AppColor.primaryColor))),
           child: MediaQuery(
               data: const MediaQueryData(alwaysUse24HourFormat: false),
               child: child!),
@@ -270,7 +270,7 @@ class VacationController extends BaseController {
 
       final messagePlainText = messageTextController.text;
       final messageHtmlText = (BuildUtils.isWeb ? _vacationMessageHtmlText : await _getMessageHtmlText()) ?? '';
-      if (messagePlainText.isEmpty && messageHtmlText.isEmpty) {
+      if (messagePlainText.isEmpty && messageHtmlText.isEmpty && context.mounted) {
         _appToast.showToastWithIcon(
             context,
             bgColor: AppColor.toastErrorBackgroundColor,

lib/features/manage_account/presentation/vacation/vacation_view.dart

@@ -1,6 +1,5 @@
 
 import 'package:core/core.dart';
-import 'package:enough_html_editor/enough_html_editor.dart' as html_editor_mobile;
 import 'package:flutter/material.dart';
 import 'package:flutter_svg/flutter_svg.dart';
 import 'package:get/get.dart';
@@ -468,7 +467,7 @@ class VacationView extends GetWidget<VacationController> with RichTextButtonMixi
         ),
       );
     } else {
-      return html_editor_mobile.HtmlEditor(
+      return HtmlEditor(
           key: controller.htmlKey,
           minHeight: controller.htmlEditorMinHeight,
           addDefaultSelectionMenuItems: false,