diff --git a/docs/adr/0025-fix-can-not-select-suggestion-email-by-mouse-clicking-on-web.md b/docs/adr/0025-fix-can-not-select-suggestion-email-by-mouse-clicking-on-web.md new file mode 100644 index 000000000..3bc962fe7 --- /dev/null +++ b/docs/adr/0025-fix-can-not-select-suggestion-email-by-mouse-clicking-on-web.md @@ -0,0 +1,24 @@ +# 25. Fix can't select suggestion email by mouse clicking on web + +Date: 2023-04-24 + +## Status + +- Issue: [#1576](https://github.com/linagora/tmail-flutter/issues/1576) +- Issue: [#1753](https://github.com/linagora/tmail-flutter/issues/1753) + +## Context + +Tap events are not being simulated to overlay on the `Web/Desktop` but work fine on mobile devices. This worked fine until the previous release stable `3.3` + +## Root cause + +Because the thing that the overlay is attached to is a `TextField`, so in order to keep from unfocused the text field when tapping outside of it, you need to tell the overlay widget that it's part of the TextField for purposes of the `Tap outside` behavior + +## Decision + +- Try wrapping a `TextFieldTapRegion` around the `Material` in the overlay. So that when the tap arrives, it's considered `inside` of the text field. + +## Consequences + +- Widget on overlay work fine. diff --git a/pubspec.lock b/pubspec.lock index d293305cb..aa4e4d319 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -1473,10 +1473,10 @@ packages: dependency: "direct main" description: name: super_tag_editor - sha256: "0888ef22d5a1485baeb628892de449e03af4b6f901ac7f7c9ddd2f44f6199e22" + sha256: f992eab1bad3595148f1a62f98fd981fac814d53682b8414311eca470dbfa768 url: "https://pub.dev" source: hosted - version: "0.1.1" + version: "0.1.2" syncfusion_flutter_core: dependency: transitive description: diff --git a/pubspec.yaml b/pubspec.yaml index 13a9d78f3..9f7e95ef9 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -194,7 +194,7 @@ dependencies: # flutter_localizations depends on intl 0.17.0 intl: 0.17.0 - super_tag_editor: 0.1.1 + super_tag_editor: 0.1.2 external_app_launcher: 3.1.0 @@ -227,6 +227,7 @@ dependency_overrides: url: https://github.com/linagora/enough_html_editor.git ref: fix/escaped-html-signature + # For information on the generic Dart part of this file, see the # following page: https://dart.dev/tools/pub/pubspec