From 2e4b38fcb247adb4d8a70e7485e41dde9b4ec90f Mon Sep 17 00:00:00 2001
From: DatDang <tddang@linagora.com>
Date: Fri, 3 Jan 2025 15:09:27 +0700
Subject: [PATCH] TF-3385 Add try-catch to cache method calls on user actions

---
 .../repository/email_repository_impl.dart     | 131 +++++++++++-------
 .../repository/mailbox_repository_impl.dart   |  38 +++--
 2 files changed, 105 insertions(+), 64 deletions(-)

diff --git a/lib/features/email/data/repository/email_repository_impl.dart b/lib/features/email/data/repository/email_repository_impl.dart
index 89ba6ae11..5b19266eb 100644
--- a/lib/features/email/data/repository/email_repository_impl.dart
+++ b/lib/features/email/data/repository/email_repository_impl.dart
@@ -6,6 +6,7 @@ import 'package:core/data/network/download/downloaded_response.dart';
 import 'package:core/presentation/state/failure.dart';
 import 'package:core/presentation/state/success.dart';
 import 'package:core/presentation/utils/html_transformer/transform_configuration.dart';
+import 'package:core/utils/app_logger.dart';
 import 'package:dartz/dartz.dart';
 import 'package:dio/dio.dart';
 import 'package:email_recovery/email_recovery/email_recovery_action.dart';
@@ -101,12 +102,16 @@ class EmailRepositoryImpl extends EmailRepository {
       readActions,
     );
 
-    await emailDataSource[DataSourceType.hiveCache]!.markAsRead(
-      session,
-      accountId,
-      result.emailIdsSuccess,
-      readActions,
-    );
+    try {
+      await emailDataSource[DataSourceType.hiveCache]!.markAsRead(
+        session,
+        accountId,
+        result.emailIdsSuccess,
+        readActions,
+      );
+    } catch (e) {
+      logError('EmailRepositoryImpl::markAsRead:exception $e');
+    }
 
     return result;
   }
@@ -159,18 +164,22 @@ class EmailRepositoryImpl extends EmailRepository {
       ),
     );
     
-    await emailDataSource[DataSourceType.hiveCache]
-      !.moveToMailbox(
-        session,
-        accountId,
-        MoveToMailboxRequest(
-          updatedCurrentMailboxes,
-          moveRequest.destinationMailboxId,
-          moveRequest.moveAction,
-          moveRequest.emailActionType,
-          destinationPath: moveRequest.destinationPath,
-        ),
-      );
+    try {
+      await emailDataSource[DataSourceType.hiveCache]
+        !.moveToMailbox(
+          session,
+          accountId,
+          MoveToMailboxRequest(
+            updatedCurrentMailboxes,
+            moveRequest.destinationMailboxId,
+            moveRequest.moveAction,
+            moveRequest.emailActionType,
+            destinationPath: moveRequest.destinationPath,
+          ),
+        );
+    } catch (e) {
+      logError('EmailRepositoryImpl::moveToMailbox:exception $e');
+    }
 
     return result;
   }
@@ -191,12 +200,16 @@ class EmailRepositoryImpl extends EmailRepository {
       emailIds,
       markStarAction,
     );
-    await emailDataSource[DataSourceType.hiveCache]!.markAsStar(
-      session,
-      accountId,
-      result.emailIdsSuccess,
-      markStarAction
-    );
+    try {
+      await emailDataSource[DataSourceType.hiveCache]!.markAsStar(
+        session,
+        accountId,
+        result.emailIdsSuccess,
+        markStarAction
+      );
+    } catch (e) {
+      logError('EmailRepositoryImpl::markAsStar:exception $e');
+    }
     return result;
   }
 
@@ -230,12 +243,16 @@ class EmailRepositoryImpl extends EmailRepository {
       email,
       cancelToken: cancelToken
     );
-    await emailDataSource[DataSourceType.hiveCache]!.saveEmailAsDrafts(
-      session,
-      accountId,
-      result,
-      cancelToken: cancelToken
-    );
+    try {
+      await emailDataSource[DataSourceType.hiveCache]!.saveEmailAsDrafts(
+        session,
+        accountId,
+        result,
+        cancelToken: cancelToken
+      );
+    } catch (e) {
+      logError('EmailRepositoryImpl::saveEmailAsDrafts:exception $e');
+    }
     return result;
   }
 
@@ -252,12 +269,16 @@ class EmailRepositoryImpl extends EmailRepository {
       emailId,
       cancelToken: cancelToken
     );
-    await emailDataSource[DataSourceType.hiveCache]!.removeEmailDrafts(
-      session,
-      accountId,
-      emailId,
-      cancelToken: cancelToken
-    );
+    try {
+      await emailDataSource[DataSourceType.hiveCache]!.removeEmailDrafts(
+        session,
+        accountId,
+        emailId,
+        cancelToken: cancelToken
+      );
+    } catch (e) {
+      logError('EmailRepositoryImpl::removeEmailDrafts:exception $e');
+    }
     return result;
   }
 
@@ -276,12 +297,16 @@ class EmailRepositoryImpl extends EmailRepository {
       oldEmailId,
       cancelToken: cancelToken
     );
-    await emailDataSource[DataSourceType.hiveCache]!.updateEmailDrafts(
-      session,
-      accountId,
-      result,
-      oldEmailId,
-    );
+    try {
+      await emailDataSource[DataSourceType.hiveCache]!.updateEmailDrafts(
+        session,
+        accountId,
+        result,
+        oldEmailId,
+      );
+    } catch (e) {
+      logError('EmailRepositoryImpl::updateEmailDrafts:exception $e');
+    }
     return result;
   }
 
@@ -320,8 +345,12 @@ class EmailRepositoryImpl extends EmailRepository {
       accountId,
       emailIds,
     );
-    await emailDataSource[DataSourceType.hiveCache]
-      !.deleteMultipleEmailsPermanently(session, accountId, result.emailIdsSuccess);
+    try {
+      await emailDataSource[DataSourceType.hiveCache]
+        !.deleteMultipleEmailsPermanently(session, accountId, result.emailIdsSuccess);
+    } catch (e) {
+      logError('EmailRepositoryImpl::deleteMultipleEmailsPermanently:exception $e');
+    }
 
     return result;
   }
@@ -339,11 +368,15 @@ class EmailRepositoryImpl extends EmailRepository {
       emailId,
       cancelToken: cancelToken
     );
-    await emailDataSource[DataSourceType.hiveCache]!.deleteEmailPermanently(
-      session,
-      accountId,
-      emailId,
-    );
+    try {
+      await emailDataSource[DataSourceType.hiveCache]!.deleteEmailPermanently(
+        session,
+        accountId,
+        emailId,
+      );
+    } catch (e) {
+      logError('EmailRepositoryImpl::deleteEmailPermanently:exception $e');
+    }
 
     return result;
   }
diff --git a/lib/features/mailbox/data/repository/mailbox_repository_impl.dart b/lib/features/mailbox/data/repository/mailbox_repository_impl.dart
index cf4a9c120..5fbf9394e 100644
--- a/lib/features/mailbox/data/repository/mailbox_repository_impl.dart
+++ b/lib/features/mailbox/data/repository/mailbox_repository_impl.dart
@@ -219,8 +219,12 @@ class MailboxRepositoryImpl extends MailboxRepository {
     final result = await mapDataSource[DataSourceType.network]
       !.renameMailbox(session, accountId, request);
 
-    await mapDataSource[DataSourceType.local]
-      !.renameMailbox(session, accountId, request);
+    try {
+      await mapDataSource[DataSourceType.local]
+        !.renameMailbox(session, accountId, request);
+    } catch (e) {
+      logError('MailboxRepositoryImpl::renameMailbox: Exception: $e');
+    }
 
     return result;
   }
@@ -239,19 +243,23 @@ class MailboxRepositoryImpl extends MailboxRepository {
       mailboxId,
       totalEmailUnread,
       onProgressController);
-    await mapDataSource[DataSourceType.local]!.markAsMailboxRead(
-      session,
-      accountId,
-      mailboxId,
-      totalEmailUnread - result.length,
-      onProgressController,
-    );
-    await emailDataSource?.markAsRead(
-      session,
-      accountId,
-      result,
-      ReadActions.markAsRead,
-    );
+    try {
+      await mapDataSource[DataSourceType.local]!.markAsMailboxRead(
+        session,
+        accountId,
+        mailboxId,
+        totalEmailUnread - result.length,
+        onProgressController,
+      );
+      await emailDataSource?.markAsRead(
+        session,
+        accountId,
+        result,
+        ReadActions.markAsRead,
+      );
+    } catch (e) {
+      logError('MailboxRepositoryImpl::markAsMailboxRead: Exception: $e');
+    }
     return result;
   }