TF-4269 Apply PR review: breadcrumbs, log error details, and code cleanup for NSE Sentry integration
- Replace capture(message:) with addBreadcrumb(level: .warning) in NotificationService for non-error diagnostic checkpoints - Add addBreadcrumb method to SentryManager with category/level support - Include error details in KeychainController SentryConfig decode failure log - Split combined guard into two separate guards to distinguish nil state vs unchanged state - Remove dead do-catch block in onComplete closure; use errors.forEach to capture real errors - Translate Vietnamese doc comment to English in SentryManager
This commit is contained in:
@@ -178,8 +178,10 @@ jobs:
|
||||
# 4. Upload dSYMs (Native code: Swift, Objective-C, C++)
|
||||
DSYM_DIR="$XCARCHIVE/dSYMs"
|
||||
if [ -d "$DSYM_DIR" ]; then
|
||||
echo "dSYM contents:"
|
||||
ls -la "$DSYM_DIR"
|
||||
echo "Uploading dSYMs from $DSYM_DIR..."
|
||||
sentry-cli debug-files upload --include-sources "$DSYM_DIR"
|
||||
sentry-cli debug-files upload --include-sources --log-level info "$DSYM_DIR"
|
||||
else
|
||||
echo "::error::dSYMs directory not found inside xcarchive at $DSYM_DIR."
|
||||
exit 1
|
||||
|
||||
Reference in New Issue
Block a user