eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-4236 Misleading variable name: maxBatches represents batch size, not batch count.

Browse Source
This commit is contained in:
dab246
2026-01-26 13:34:27 +07:00
committed by Dat H. Pham
parent fe57e72a02
commit 38074ab9f7
6 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/base/mixin/batch_set_email_processing_mixin.dart
+7 -4
View File
@@ -40,14 +40,14 @@ mixin BatchSetEmailProcessingMixin on HandleSetErrorMixin, MailAPIMixin {
final maxObjects = getMaxObjectsInSetMethod(session, accountId);
final totalEmails = emailIds.length;
final maxBatches = min(totalEmails, maxObjects);
final batchSize = min(totalEmails, maxObjects);
final List<EmailId> updatedEmailIds = List.empty(growable: true);
final List<SetResponse> listSetResponse = List.empty(growable: true);
for (int start = 0; start < totalEmails; start += maxBatches) {
for (int start = 0; start < totalEmails; start += batchSize) {
int end =
(start + maxBatches < totalEmails) ? start + maxBatches : totalEmails;
(start + batchSize < totalEmails) ? start + batchSize : totalEmails;
log('EmailAPI::$debugLabel:emails from ${start + 1} to $end');
@@ -73,7 +73,10 @@ mixin BatchSetEmailProcessingMixin on HandleSetErrorMixin, MailAPIMixin {
SetEmailResponse.deserialize,
);
if (setEmailResponse == null) continue;
if (setEmailResponse == null) {
log('EmailAPI::$debugLabel: Batch from ${start + 1} to $end returned null response');
continue;
}
final listEmailIds = setEmailResponse.updated?.keys.toEmailIds() ?? [];
updatedEmailIds.addAll(listEmailIds);