TF-495 Implement linter for mailbox view

This commit is contained in:
dab246
2022-04-22 10:47:52 +07:00
committed by Dat H. Pham
parent a305ba1826
commit 3c44d9aa93
24 changed files with 207 additions and 219 deletions
@@ -20,6 +20,8 @@ class MailboxView extends GetWidget<MailboxController> {
final _imagePaths = Get.find<ImagePaths>();
final _responsiveUtils = Get.find<ResponsiveUtils>();
MailboxView({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return Drawer(
@@ -28,13 +30,13 @@ class MailboxView extends GetWidget<MailboxController> {
body: Column(
children: [
_buildLogoApp(context),
if (!_responsiveUtils.isDesktop(context)) Divider(color: AppColor.colorDividerMailbox, height: 0.5, thickness: 0.2),
if (!_responsiveUtils.isDesktop(context)) const Divider(color: AppColor.colorDividerMailbox, height: 0.5, thickness: 0.2),
Expanded(child: Container(
padding: EdgeInsets.zero,
color: _responsiveUtils.isDesktop(context) ? AppColor.colorBgDesktop : Colors.white,
child: Column(children: [
if (_responsiveUtils.isDesktop(context)) _buildComposerButton(context),
Obx(() => controller.isSearchActive() ? _buildInputSearchFormWidget(context) : SizedBox.shrink()),
Obx(() => controller.isSearchActive() ? _buildInputSearchFormWidget(context) : const SizedBox.shrink()),
Expanded(child: Obx(() => Container(
color: _responsiveUtils.isDesktop(context) ? AppColor.colorBgDesktop : Colors.white,
padding: EdgeInsets.zero,
@@ -52,11 +54,11 @@ class MailboxView extends GetWidget<MailboxController> {
if (controller.isSearchActive()) {
return controller.listPresentationMailboxSelected.isNotEmpty
? _buildOptionSelectionMailbox(context)
: SizedBox.shrink();
: const SizedBox.shrink();
} else {
return controller.listMailboxNodeSelected.isNotEmpty
? _buildOptionSelectionMailbox(context)
: SizedBox.shrink();
: const SizedBox.shrink();
}
}),
]
@@ -76,7 +78,7 @@ class MailboxView extends GetWidget<MailboxController> {
(SloganBuilder(arrangedByHorizontal: true)
..setSloganText(AppLocalizations.of(context).app_name)
..setSloganTextAlign(TextAlign.center)
..setSloganTextStyle(TextStyle(color: Colors.black, fontSize: 20, fontWeight: FontWeight.bold))
..setSloganTextStyle(const TextStyle(color: Colors.black, fontSize: 20, fontWeight: FontWeight.bold))
..setSizeLogo(24)
..setLogo(_imagePaths.icLogoTMail))
.build(),
@@ -84,7 +86,7 @@ class MailboxView extends GetWidget<MailboxController> {
if (controller.mailboxDashBoardController.appInformation.value != null) {
return _buildVersionInformation(context, controller.mailboxDashBoardController.appInformation.value!);
} else {
return SizedBox.shrink();
return const SizedBox.shrink();
}
}),
])
@@ -93,19 +95,19 @@ class MailboxView extends GetWidget<MailboxController> {
Widget _buildComposerButton(BuildContext context) {
return Container(
padding: EdgeInsets.only(top: 16, right: 16, left: 20),
padding: const EdgeInsets.only(top: 16, right: 16, left: 20),
color: AppColor.colorBgDesktop,
alignment: Alignment.centerLeft,
child: (ButtonBuilder(_imagePaths.icCompose)
..key(Key('button_compose_email'))
..key(const Key('button_compose_email'))
..decoration(BoxDecoration(borderRadius: BorderRadius.circular(25), color: AppColor.colorTextButton))
..paddingIcon(EdgeInsets.only(right: 8))
..paddingIcon(const EdgeInsets.only(right: 8))
..iconColor(Colors.white)
..maxWidth(140)
..size(20)
..radiusSplash(10)
..padding(EdgeInsets.symmetric(vertical: 13))
..textStyle(TextStyle(fontSize: 15, color: Colors.white, fontWeight: FontWeight.w500))
..padding(const EdgeInsets.symmetric(vertical: 13))
..textStyle(const TextStyle(fontSize: 15, color: Colors.white, fontWeight: FontWeight.w500))
..onPressActionClick(() => controller.mailboxDashBoardController.composeEmailAction())
..text(AppLocalizations.of(context).compose, isVertical: false))
.build());
@@ -122,21 +124,21 @@ class MailboxView extends GetWidget<MailboxController> {
Widget _buildLoadingView() {
return Obx(() => controller.viewState.value.fold(
(failure) => SizedBox.shrink(),
(failure) => const SizedBox.shrink(),
(success) => success is LoadingState
? Center(child: Padding(
? const Center(child: Padding(
padding: EdgeInsets.only(top: 16),
child: SizedBox(
width: 24,
height: 24,
child: CupertinoActivityIndicator(color: AppColor.colorTextButton))))
: SizedBox.shrink()));
: const SizedBox.shrink()));
}
Widget _buildListMailbox(BuildContext context) {
return ListView(
controller: controller.mailboxListScrollController,
key: PageStorageKey('mailbox_list'),
key: const PageStorageKey('mailbox_list'),
primary: false,
shrinkWrap: true,
padding: EdgeInsets.only(
@@ -148,30 +150,30 @@ class MailboxView extends GetWidget<MailboxController> {
&& _responsiveUtils.isMobile(context)
&& _responsiveUtils.isLandscape(context))
|| _responsiveUtils.isDesktop(context)) {
return SizedBox.shrink();
return const SizedBox.shrink();
}
return _buildUserInformation(context);
}),
_buildLoadingView(),
Obx(() => controller.defaultMailboxTree.value.root.childrenItems?.isNotEmpty ?? false
? _buildMailboxCategory(context, MailboxCategories.exchange, controller.defaultMailboxTree.value.root)
: SizedBox.shrink()),
SizedBox(height: 8),
: const SizedBox.shrink()),
const SizedBox(height: 8),
Obx(() => controller.folderMailboxTree.value.root.childrenItems?.isNotEmpty ?? false
? Column(children: [
? Column(children: const [
Divider(color: AppColor.colorDividerMailbox, height: 0.5, thickness: 0.2),
SizedBox(height: 8),
])
: SizedBox.shrink()),
: const SizedBox.shrink()),
Obx(() => controller.folderMailboxTree.value.root.childrenItems?.isNotEmpty ?? false
? _buildMailboxCategory(context, MailboxCategories.folders, controller.folderMailboxTree.value.root)
: SizedBox.shrink()),
SizedBox(height: 8),
Divider(color: AppColor.colorDividerMailbox, height: 0.5, thickness: 0.2),
: const SizedBox.shrink()),
const SizedBox(height: 8),
const Divider(color: AppColor.colorDividerMailbox, height: 0.5, thickness: 0.2),
Row(children: [
Expanded(child: _buildSearchBarWidget(context)),
Padding(
padding: EdgeInsets.only(right: 8),
padding: const EdgeInsets.only(right: 8),
child: buildIconWeb(
icon: SvgPicture.asset(_imagePaths.icAddNewFolder, color: AppColor.colorTextButton, fit: BoxFit.fill),
tooltip: AppLocalizations.of(context).new_mailbox,
@@ -183,14 +185,14 @@ class MailboxView extends GetWidget<MailboxController> {
Widget _buildUserInformation(BuildContext context) {
return Container(
padding: EdgeInsets.symmetric(vertical: 10),
padding: const EdgeInsets.symmetric(vertical: 10),
child: Column(children: [
Padding(
padding: EdgeInsets.only(left: 16, bottom: 10),
padding: const EdgeInsets.only(left: 16, bottom: 10),
child: (UserInformationWidgetBuilder(_imagePaths, context, controller.mailboxDashBoardController.userProfile.value)
..addOnLogoutAction(() => controller.mailboxDashBoardController.logoutAction()))
.build()),
Divider(color: AppColor.colorDividerMailbox, height: 0.5, thickness: 0.2)
const Divider(color: AppColor.colorDividerMailbox, height: 0.5, thickness: 0.2)
]),
);
}
@@ -202,7 +204,7 @@ class MailboxView extends GetWidget<MailboxController> {
Expanded(child: Text(categories.getTitle(context),
maxLines: 1,
overflow: TextOverflow.ellipsis,
style: TextStyle(fontSize: 17, color: Colors.black, fontWeight: FontWeight.bold))),
style: const TextStyle(fontSize: 17, color: Colors.black, fontWeight: FontWeight.bold))),
buildIconWeb(
splashRadius: 12,
icon: SvgPicture.asset(
@@ -230,10 +232,10 @@ class MailboxView extends GetWidget<MailboxController> {
return Column(children: [
_buildHeaderMailboxCategory(context, categories),
AnimatedContainer(
duration: Duration(milliseconds: 400),
duration: const Duration(milliseconds: 400),
child: categories.getExpandMode(controller.mailboxCategoriesExpandMode.value) == ExpandMode.EXPAND
? _buildBodyMailboxCategory(context, categories, mailboxNode)
: Offstage())
: const Offstage())
]);
}
@@ -242,7 +244,7 @@ class MailboxView extends GetWidget<MailboxController> {
?.map((mailboxNode) => mailboxNode.hasChildren()
? TreeViewChild(
context,
key: Key('children_tree_mailbox_child'),
key: const Key('children_tree_mailbox_child'),
isExpanded: mailboxNode.expandMode == ExpandMode.EXPAND,
parent: Obx(() => (MailBoxFolderTileBuilder(context, _imagePaths, mailboxNode, lastNode: lastNode,
mailboxNodeSelected: controller.mailboxDashBoardController.selectedMailbox.value)
@@ -262,7 +264,7 @@ class MailboxView extends GetWidget<MailboxController> {
Widget _buildInputSearchFormWidget(BuildContext context) {
return Padding(
padding: EdgeInsets.only(left: 8, top: 16),
padding: const EdgeInsets.only(left: 8, top: 16),
child: Row(
children: [
buildIconWeb(
@@ -271,7 +273,7 @@ class MailboxView extends GetWidget<MailboxController> {
Expanded(child: (SearchAppBarWidget(context, _imagePaths, _responsiveUtils, controller.searchQuery.value,
controller.searchFocus, controller.searchInputController, hasBackButton: false, hasSearchButton: true)
..addPadding(EdgeInsets.zero)
..setMargin(EdgeInsets.only(right: 16))
..setMargin(const EdgeInsets.only(right: 16))
..addDecoration(BoxDecoration(borderRadius: BorderRadius.circular(12), color: AppColor.colorBgSearchBar))
..addIconClearText(SvgPicture.asset(_imagePaths.icClearTextSearch, width: 16, height: 16, fit: BoxFit.fill))
..setHintText(AppLocalizations.of(context).hint_search_mailboxes)
@@ -289,8 +291,8 @@ class MailboxView extends GetWidget<MailboxController> {
margin: EdgeInsets.zero,
color: _responsiveUtils.isDesktop(context) ? AppColor.colorBgDesktop : Colors.white,
child: ListView.builder(
padding: EdgeInsets.only(left: 16, right: 8),
key: Key('list_mailbox_searched'),
padding: const EdgeInsets.only(left: 16, right: 8),
key: const Key('list_mailbox_searched'),
itemCount: listMailbox.length,
shrinkWrap: true,
primary: false,
@@ -307,9 +309,9 @@ class MailboxView extends GetWidget<MailboxController> {
Widget _buildOptionSelectionMailbox(BuildContext context) {
return Column(children: [
Divider(color: AppColor.lineItemListColor, height: 1, thickness: 0.2),
const Divider(color: AppColor.lineItemListColor, height: 1, thickness: 0.2),
Padding(
padding: EdgeInsets.symmetric(vertical: 16),
padding: const EdgeInsets.symmetric(vertical: 16),
child: (BottomBarSelectionMailboxWidget(context, _imagePaths, controller.listMailboxSelected)
..addOnMailboxActionsClick((actions, listMailboxSelected) => controller.pressMailboxSelectionAction(context, actions, listMailboxSelected)))
.build()
@@ -319,11 +321,11 @@ class MailboxView extends GetWidget<MailboxController> {
Widget _buildVersionInformation(BuildContext context, PackageInfo packageInfo) {
return Container(
padding: EdgeInsets.only(top: 4),
padding: const EdgeInsets.only(top: 4),
child: Text(
'v.${packageInfo.version}',
textAlign: TextAlign.center,
style: TextStyle(fontSize: 13, color: AppColor.colorContentEmail, fontWeight: FontWeight.w500),
style: const TextStyle(fontSize: 13, color: AppColor.colorContentEmail, fontWeight: FontWeight.w500),
),
);
}