eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Handle keyboard shortcut FocusNode causing memory leak (#4158)

Browse Source
This commit is contained in:
Dat Dang
2025-11-21 09:53:40 +07:00
committed by GitHub
parent f526b39fae
commit 426977f603
4 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/thread_detail/presentation/extension/close_thread_detail_action.dart
+3
View File
@@ -1,5 +1,6 @@
import 'package:tmail_ui_user/features/email/presentation/action/email_ui_action.dart'; import 'package:tmail_ui_user/features/email/presentation/action/email_ui_action.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/model/dashboard_routes.dart'; import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/model/dashboard_routes.dart';
import 'package:tmail_ui_user/features/thread_detail/presentation/extension/handle_mail_shortcut_actions_extension.dart';
import 'package:tmail_ui_user/features/thread_detail/presentation/thread_detail_controller.dart'; import 'package:tmail_ui_user/features/thread_detail/presentation/thread_detail_controller.dart';
extension CloseThreadDetailAction on ThreadDetailController { extension CloseThreadDetailAction on ThreadDetailController {
@@ -15,6 +16,8 @@ extension CloseThreadDetailAction on ThreadDetailController {
mailboxDashBoardController.dispatchEmailUIAction(EmailUIAction()); mailboxDashBoardController.dispatchEmailUIAction(EmailUIAction());
}); });
onKeyboardShortcutDispose();
reset(); reset();
} }
} }
lib/features/thread_detail/presentation/extension/handle_mail_shortcut_actions_extension.dart
+1
View File
@@ -56,6 +56,7 @@ extension HandleMailShortcutActionsExtension on ThreadDetailController {
void onKeyboardShortcutDispose() { void onKeyboardShortcutDispose() {
if (PlatformInfo.isWeb) { if (PlatformInfo.isWeb) {
keyboardShortcutFocusNode?.dispose(); keyboardShortcutFocusNode?.dispose();
keyboardShortcutFocusNode = null;
shortcutActionEventSubscription?.cancel(); shortcutActionEventSubscription?.cancel();
shortcutActionEventController?.close(); shortcutActionEventController?.close();
} }
lib/features/thread_detail/presentation/extension/thread_detail_on_selected_email_updated.dart
+2
View File
@@ -10,6 +10,7 @@ import 'package:tmail_ui_user/features/thread_detail/domain/state/get_emails_by_
import 'package:tmail_ui_user/features/thread_detail/domain/state/get_thread_by_id_state.dart'; import 'package:tmail_ui_user/features/thread_detail/domain/state/get_thread_by_id_state.dart';
import 'package:tmail_ui_user/features/thread_detail/presentation/action/thread_detail_ui_action.dart'; import 'package:tmail_ui_user/features/thread_detail/presentation/action/thread_detail_ui_action.dart';
import 'package:tmail_ui_user/features/thread_detail/presentation/extension/close_thread_detail_action.dart'; import 'package:tmail_ui_user/features/thread_detail/presentation/extension/close_thread_detail_action.dart';
import 'package:tmail_ui_user/features/thread_detail/presentation/extension/handle_mail_shortcut_actions_extension.dart';
import 'package:tmail_ui_user/features/thread_detail/presentation/thread_detail_controller.dart'; import 'package:tmail_ui_user/features/thread_detail/presentation/thread_detail_controller.dart';
extension ThreadDetailOnSelectedEmailUpdated on ThreadDetailController { extension ThreadDetailOnSelectedEmailUpdated on ThreadDetailController {
@@ -23,6 +24,7 @@ extension ThreadDetailOnSelectedEmailUpdated on ThreadDetailController {
} }
emailIdsPresentation.clear(); emailIdsPresentation.clear();
onKeyboardShortcutInit();
scrollController ??= ScrollController(); scrollController ??= ScrollController();
if (currentExpandedEmailId.value == null) { if (currentExpandedEmailId.value == null) {
lib/features/thread_detail/presentation/thread_detail_controller.dart
-2
View File
@@ -212,8 +212,6 @@ class ThreadDetailController extends BaseController {
); );
} }
}); });
onKeyboardShortcutInit();
} }
bool _validateLoadThread(ThreadId? threadId) { bool _validateLoadThread(ThreadId? threadId) {