From 48c1247dfeda16d355c1efd20ff82b993117a5e7 Mon Sep 17 00:00:00 2001 From: dab246 Date: Fri, 28 Oct 2022 12:08:08 +0700 Subject: [PATCH] TF-1115 Implement catch exception for HtmlDataSource --- lib/features/composer/presentation/composer_bindings.dart | 6 +++--- .../email/data/datasource_impl/html_datasource_impl.dart | 8 +++++--- lib/features/email/presentation/email_bindings.dart | 6 +++--- .../presentation/bindings/mailbox_dashboard_bindings.dart | 6 +++--- lib/features/thread/presentation/thread_bindings.dart | 6 +++--- 5 files changed, 17 insertions(+), 15 deletions(-) diff --git a/lib/features/composer/presentation/composer_bindings.dart b/lib/features/composer/presentation/composer_bindings.dart index 216271dfb..7deb65db1 100644 --- a/lib/features/composer/presentation/composer_bindings.dart +++ b/lib/features/composer/presentation/composer_bindings.dart @@ -82,9 +82,9 @@ class ComposerBindings extends BaseBindings { Get.find(), Get.find())); Get.lazyPut(() => HtmlDataSourceImpl( - Get.find(), - Get.find() - )); + Get.find(), + Get.find(), + Get.find())); Get.lazyPut(() => StateDataSourceImpl(Get.find())); } diff --git a/lib/features/email/data/datasource_impl/html_datasource_impl.dart b/lib/features/email/data/datasource_impl/html_datasource_impl.dart index 94fb67403..11b557cbe 100644 --- a/lib/features/email/data/datasource_impl/html_datasource_impl.dart +++ b/lib/features/email/data/datasource_impl/html_datasource_impl.dart @@ -2,13 +2,15 @@ import 'package:core/core.dart'; import 'package:model/model.dart'; import 'package:tmail_ui_user/features/email/data/datasource/html_datasource.dart'; import 'package:tmail_ui_user/features/email/data/local/html_analyzer.dart'; +import 'package:tmail_ui_user/main/exceptions/exception_thrower.dart'; class HtmlDataSourceImpl extends HtmlDataSource { final HtmlAnalyzer _htmlAnalyzer; final DioClient _dioClient; + final ExceptionThrower _exceptionThrower; - HtmlDataSourceImpl(this._htmlAnalyzer, this._dioClient); + HtmlDataSourceImpl(this._htmlAnalyzer, this._dioClient, this._exceptionThrower); @override Future transformEmailContent( @@ -18,7 +20,7 @@ class HtmlDataSourceImpl extends HtmlDataSource { return Future.sync(() async { return await _htmlAnalyzer.transformEmailContent(emailContent, mapUrlDownloadCID, _dioClient); }).catchError((error) { - throw error; + _exceptionThrower.throwException(error); }); } @@ -27,7 +29,7 @@ class HtmlDataSourceImpl extends HtmlDataSource { return Future.sync(() async { return await _htmlAnalyzer.addTooltipWhenHoverOnLink(emailContent); }).catchError((error) { - throw error; + _exceptionThrower.throwException(error); }); } } \ No newline at end of file diff --git a/lib/features/email/presentation/email_bindings.dart b/lib/features/email/presentation/email_bindings.dart index c4f55e798..3392a1f20 100644 --- a/lib/features/email/presentation/email_bindings.dart +++ b/lib/features/email/presentation/email_bindings.dart @@ -90,9 +90,9 @@ class EmailBindings extends BaseBindings { Get.find())); Get.lazyPut(() => HiveAccountDatasourceImpl(Get.find())); Get.lazyPut(() => HtmlDataSourceImpl( - Get.find(), - Get.find(), - )); + Get.find(), + Get.find(), + Get.find())); Get.lazyPut(() => StateDataSourceImpl(Get.find())); Get.lazyPut(() => AuthenticationOIDCDataSourceImpl( Get.find(), diff --git a/lib/features/mailbox_dashboard/presentation/bindings/mailbox_dashboard_bindings.dart b/lib/features/mailbox_dashboard/presentation/bindings/mailbox_dashboard_bindings.dart index 8777a41a8..2ef20c4ad 100644 --- a/lib/features/mailbox_dashboard/presentation/bindings/mailbox_dashboard_bindings.dart +++ b/lib/features/mailbox_dashboard/presentation/bindings/mailbox_dashboard_bindings.dart @@ -149,9 +149,9 @@ class MailboxDashBoardBindings extends BaseBindings { Get.find(), Get.find())); Get.lazyPut(() => HtmlDataSourceImpl( - Get.find(), - Get.find() - )); + Get.find(), + Get.find(), + Get.find())); Get.lazyPut(() => SearchDataSourceImpl(Get.find())); Get.lazyPut(() => ThreadDataSourceImpl( Get.find(), diff --git a/lib/features/thread/presentation/thread_bindings.dart b/lib/features/thread/presentation/thread_bindings.dart index 1cc8b2634..f38f609c3 100644 --- a/lib/features/thread/presentation/thread_bindings.dart +++ b/lib/features/thread/presentation/thread_bindings.dart @@ -96,9 +96,9 @@ class ThreadBindings extends BaseBindings { Get.find(), Get.find())); Get.lazyPut(() => HtmlDataSourceImpl( - Get.find(), - Get.find(), - )); + Get.find(), + Get.find(), + Get.find())); } @override