Fix AI scribe menu going off screen to the top

If it was opened at the top of the composer, it could go off screen to the top. modalHeight was missing so the calculateModalPosition method could not protect the AI scribe menu to go off screen from the top.
2025-12-11 13:55:30 +01:00
parent c7886614cd
commit 4d8d688afb
2 changed files with 75 additions and 1 deletions
@@ -4,7 +4,66 @@ import 'package:scribe/scribe/ai/presentation/styles/ai_scribe_styles.dart';
 import 'package:scribe/scribe/ai/presentation/widgets/ai_scribe.dart';

 void main() {
-    group('calculateModalPosition::', () {
+  group('calculateMenuDialogHeight::', () {
+    test('should calculate correct height with content and default 4 categories', () {
+      // Arrange
+      const hasContent = true;
+      const categoryCount = 4;
+
+      // Act
+      final height = calculateMenuDialogHeight(
+        hasContent: hasContent,
+        categoryCount: categoryCount,
+      );
+
+      // Assert
+      // 4 categories × 40px + 8px spacing + 48px bar = 216px
+      const expectedHeight = (4 * AIScribeSizes.menuItemHeight) +
+          AIScribeSizes.fieldSpacing +
+          AIScribeSizes.barHeight;
+      expect(height, expectedHeight);
+      expect(height, 216.0);
+    });
+
+    test('should calculate correct height with content and custom categories', () {
+      // Arrange
+      const hasContent = true;
+      const categoryCount = 2;
+
+      // Act
+      final height = calculateMenuDialogHeight(
+        hasContent: hasContent,
+        categoryCount: categoryCount,
+      );
+
+      // Assert
+      // 2 categories × 40px + 8px spacing + 48px bar = 136px
+      const expectedHeight = (2 * AIScribeSizes.menuItemHeight) +
+          AIScribeSizes.fieldSpacing +
+          AIScribeSizes.barHeight;
+      expect(height, expectedHeight);
+      expect(height, 136.0);
+    });
+
+    test('should calculate correct height without content (bar only)', () {
+      // Arrange
+      const hasContent = false;
+      const categoryCount = 4; // Should be ignored when hasContent is false
+
+      // Act
+      final height = calculateMenuDialogHeight(
+        hasContent: hasContent,
+        categoryCount: categoryCount,
+      );
+
+      // Assert
+      // Only the bar height
+      expect(height, AIScribeSizes.barHeight);
+      expect(height, 48.0);
+    });
+  });
+
+  group('calculateModalPosition::', () {
    testWidgets('should adjust left position when modal would go off-screen to the right', (tester) async {
      // Arrange
      const screenSize = Size(800, 600);