eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-1984 Move Get.find() outside the build method

Browse Source 
(cherry picked from commit 22b810dfda89f19dfb54f632ed6c390bf81ca326)
This commit is contained in:
dab246
2023-08-30 16:19:46 +07:00
committed by Dat Vu
parent 3c173caa4e
commit 5c7eb62eb7
4 changed files with 43 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/mailbox_dashboard/presentation/mailbox_dashboard_view_web.dart
+2 -7
View File
@@ -292,15 +292,10 @@ class MailboxDashBoardView extends BaseMailboxDashBoardView {
Widget _buildRightHeader(BuildContext context) { Widget _buildRightHeader(BuildContext context) {
return LayoutBuilder(builder: (context, constraint) { return LayoutBuilder(builder: (context, constraint) {
return Row(children: [ return Row(children: [
Container( SizedBox(
width: constraint.maxWidth / 2, width: constraint.maxWidth / 2,
height: 52, height: 52,
color: Colors.transparent, child: SearchInputFormWidget()
child: SearchInputFormWidget(
maxWidth: constraint.maxWidth / 2,
dashBoardController: controller,
imagePaths: imagePaths
)
), ),
const Spacer(), const Spacer(),
AppConfig.appGridDashboardAvailable AppConfig.appGridDashboardAvailable
lib/features/mailbox_dashboard/presentation/widgets/advanced_search/advanced_search_filter_overlay.dart
+1 -7
View File
@@ -7,12 +7,7 @@ import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/widgets/ad
class AdvancedSearchFilterOverlay extends StatelessWidget { class AdvancedSearchFilterOverlay extends StatelessWidget {
final double? maxWidth; const AdvancedSearchFilterOverlay({Key? key}) : super(key: key);
const AdvancedSearchFilterOverlay({
Key? key,
this.maxWidth
}) : super(key: key);
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
@@ -25,7 +20,6 @@ class AdvancedSearchFilterOverlay extends StatelessWidget {
constraints: BoxConstraints( constraints: BoxConstraints(
maxHeight: _getHeightOverlay(context, responsiveUtils), maxHeight: _getHeightOverlay(context, responsiveUtils),
), ),
width: maxWidth ?? 660,
margin: const EdgeInsetsDirectional.only(top: 4, bottom: 16, end: 22), margin: const EdgeInsetsDirectional.only(top: 4, bottom: 16, end: 22),
padding: const EdgeInsets.symmetric(horizontal: 8), padding: const EdgeInsets.symmetric(horizontal: 8),
decoration: BoxDecoration( decoration: BoxDecoration(
lib/features/mailbox_dashboard/presentation/widgets/search_input_form_widget.dart
+36 -45
View File
@@ -22,34 +22,28 @@ import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/widgets/em
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/widgets/recent_search_item_tile_widget.dart'; import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/widgets/recent_search_item_tile_widget.dart';
import 'package:tmail_ui_user/main/localizations/app_localizations.dart'; import 'package:tmail_ui_user/main/localizations/app_localizations.dart';
import 'package:tmail_ui_user/main/utils/app_utils.dart'; import 'package:tmail_ui_user/main/utils/app_utils.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/controller/search_controller.dart' as search;
class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin { class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
final MailboxDashBoardController dashBoardController; final _searchController = Get.find<search.SearchController>();
final ImagePaths imagePaths; final _dashBoardController = Get.find<MailboxDashBoardController>();
final double maxWidth; final _imagePaths = Get.find<ImagePaths>();
SearchInputFormWidget({ SearchInputFormWidget({Key? key}) : super(key: key);
Key? key,
required this.dashBoardController,
required this.imagePaths,
required this.maxWidth,
}) : super(key: key);
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final controller = dashBoardController.searchController;
return Obx(() { return Obx(() {
return PortalTarget( return PortalTarget(
visible: controller.isAdvancedSearchViewOpen.isTrue, visible: _searchController.isAdvancedSearchViewOpen.isTrue,
portalFollower: PointerInterceptor( portalFollower: PointerInterceptor(
child: GestureDetector( child: GestureDetector(
behavior: HitTestBehavior.opaque, behavior: HitTestBehavior.opaque,
onTap: () => controller.selectOpenAdvanceSearch() onTap: () => _searchController.selectOpenAdvanceSearch()
), ),
), ),
child: PortalTarget( child: PortalTarget(
visible: controller.isAdvancedSearchViewOpen.isTrue, visible: _searchController.isAdvancedSearchViewOpen.isTrue,
anchor: const Aligned( anchor: const Aligned(
follower: Alignment.topRight, follower: Alignment.topRight,
target: Alignment.bottomRight, target: Alignment.bottomRight,
@@ -60,15 +54,14 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
widthFactor: 1, widthFactor: 1,
), ),
), ),
portalFollower: AdvancedSearchFilterOverlay(maxWidth: maxWidth), portalFollower: const AdvancedSearchFilterOverlay(),
child: QuickSearchInputForm<PresentationEmail, RecentSearch>( child: QuickSearchInputForm<PresentationEmail, RecentSearch>(
maxHeight: 52, maxHeight: 52,
suggestionsBoxVerticalOffset: 0.0, suggestionsBoxVerticalOffset: 0.0,
textFieldConfiguration: _createConfiguration(context), textFieldConfiguration: _createConfiguration(context),
suggestionsBoxDecoration: QuickSearchSuggestionsBoxDecoration( suggestionsBoxDecoration: const QuickSearchSuggestionsBoxDecoration(
color: Colors.white, color: Colors.white,
borderRadius: const BorderRadius.all(Radius.circular(16)), borderRadius: BorderRadius.all(Radius.circular(16)),
constraints: BoxConstraints(maxWidth: maxWidth)
), ),
debounceDuration: const Duration(milliseconds: 300), debounceDuration: const Duration(milliseconds: 300),
listActionButton: QuickSearchFilter.values, listActionButton: QuickSearchFilter.values,
@@ -81,7 +74,7 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
}, },
buttonActionCallback: (filterAction) { buttonActionCallback: (filterAction) {
if (filterAction is QuickSearchFilter) { if (filterAction is QuickSearchFilter) {
dashBoardController.addFilterToSuggestionForm(filterAction); _dashBoardController.addFilterToSuggestionForm(filterAction);
} }
}, },
listActionPadding: const EdgeInsets.only(left: 12, right: 12, top: 12, bottom: 6), listActionPadding: const EdgeInsets.only(left: 12, right: 12, top: 12, bottom: 6),
@@ -107,11 +100,11 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
padding: const EdgeInsets.only(bottom: 16), padding: const EdgeInsets.only(bottom: 16),
child: loadingWidget child: loadingWidget
), ),
fetchRecentActionCallback: controller.getAllRecentSearchAction, fetchRecentActionCallback: _searchController.getAllRecentSearchAction,
itemRecentBuilder: (context, recent) => RecentSearchItemTileWidget(recent), itemRecentBuilder: (context, recent) => RecentSearchItemTileWidget(recent),
onRecentSelected: (recent) => _invokeSelectRecentItem(context, recent), onRecentSelected: (recent) => _invokeSelectRecentItem(context, recent),
suggestionsCallback: dashBoardController.quickSearchEmails, suggestionsCallback: _dashBoardController.quickSearchEmails,
itemBuilder: (context, email) => EmailQuickSearchItemTileWidget(email, dashBoardController.selectedMailbox.value), itemBuilder: (context, email) => EmailQuickSearchItemTileWidget(email, _dashBoardController.selectedMailbox.value),
onSuggestionSelected: (presentationEmail) => _invokeSelectSuggestionItem(context, presentationEmail)) onSuggestionSelected: (presentationEmail) => _invokeSelectSuggestionItem(context, presentationEmail))
), ),
); );
@@ -119,23 +112,23 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
} }
void _invokeSearchEmailAction(BuildContext context, String query) { void _invokeSearchEmailAction(BuildContext context, String query) {
dashBoardController.searchController.searchFocus.unfocus(); _searchController.searchFocus.unfocus();
dashBoardController.searchController.enableSearch(); _searchController.enableSearch();
if (query.isNotEmpty) { if (query.isNotEmpty) {
dashBoardController.searchController.saveRecentSearch(RecentSearch.now(query)); _searchController.saveRecentSearch(RecentSearch.now(query));
} }
if (query.isNotEmpty || dashBoardController.searchController.listFilterOnSuggestionForm.isNotEmpty) { if (query.isNotEmpty || _searchController.listFilterOnSuggestionForm.isNotEmpty) {
dashBoardController.searchController.applyFilterSuggestionToSearchFilter(dashBoardController.userProfile.value); _searchController.applyFilterSuggestionToSearchFilter(_dashBoardController.userProfile.value);
dashBoardController.searchEmail(context, queryString: query); _dashBoardController.searchEmail(context, queryString: query);
} else { } else {
dashBoardController.clearSearchEmail(); _dashBoardController.clearSearchEmail();
} }
} }
void _invokeSelectSuggestionItem(BuildContext context, PresentationEmail presentationEmail) { void _invokeSelectSuggestionItem(BuildContext context, PresentationEmail presentationEmail) {
dashBoardController.dispatchAction( _dashBoardController.dispatchAction(
OpenEmailDetailedFromSuggestionQuickSearchAction( OpenEmailDetailedFromSuggestionQuickSearchAction(
context, context,
presentationEmail presentationEmail
@@ -144,12 +137,12 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
} }
void _invokeSelectRecentItem(BuildContext context, RecentSearch recent) { void _invokeSelectRecentItem(BuildContext context, RecentSearch recent) {
dashBoardController.searchController.searchInputController.text = recent.value; _searchController.searchInputController.text = recent.value;
dashBoardController.searchController.searchFocus.unfocus(); _searchController.searchFocus.unfocus();
dashBoardController.searchController.enableSearch(); _searchController.enableSearch();
dashBoardController.searchController.applyFilterSuggestionToSearchFilter(dashBoardController.userProfile.value); _searchController.applyFilterSuggestionToSearchFilter(_dashBoardController.userProfile.value);
dashBoardController.searchEmail(context, queryString: recent.value); _dashBoardController.searchEmail(context, queryString: recent.value);
} }
Widget _buildShowAllResultButton(BuildContext context, String keyword) { Widget _buildShowAllResultButton(BuildContext context, String keyword) {
@@ -181,11 +174,9 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
} }
QuickSearchTextFieldConfiguration _createConfiguration(BuildContext context) { QuickSearchTextFieldConfiguration _createConfiguration(BuildContext context) {
final controller = dashBoardController.searchController;
return QuickSearchTextFieldConfiguration( return QuickSearchTextFieldConfiguration(
controller: controller.searchInputController, controller: _searchController.searchInputController,
focusNode: controller.searchFocus, focusNode: _searchController.searchFocus,
textInputAction: TextInputAction.done, textInputAction: TextInputAction.done,
textDirection: DirectionUtils.getDirectionByLanguage(context), textDirection: DirectionUtils.getDirectionByLanguage(context),
onSubmitted: (keyword) => _invokeSearchEmailAction(context, keyword.trim()), onSubmitted: (keyword) => _invokeSearchEmailAction(context, keyword.trim()),
@@ -206,18 +197,18 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
child: buildIconWeb( child: buildIconWeb(
minSize: 40, minSize: 40,
iconPadding: EdgeInsets.zero, iconPadding: EdgeInsets.zero,
icon: SvgPicture.asset(imagePaths.icSearchBar, fit: BoxFit.fill), icon: SvgPicture.asset(_imagePaths.icSearchBar, fit: BoxFit.fill),
onTap: () => _invokeSearchEmailAction(context, controller.searchInputController.text.trim()) onTap: () => _invokeSearchEmailAction(context, _searchController.searchInputController.text.trim())
) )
), ),
clearTextButton: buildIconWeb( clearTextButton: buildIconWeb(
icon: SvgPicture.asset( icon: SvgPicture.asset(
imagePaths.icClearTextSearch, _imagePaths.icClearTextSearch,
width: 16, width: 16,
height: 16, height: 16,
fit: BoxFit.fill fit: BoxFit.fill
), ),
onTap: controller.clearTextSearch onTap: _searchController.clearTextSearch
), ),
rightButton: IconOpenAdvancedSearchWidget(context) rightButton: IconOpenAdvancedSearchWidget(context)
); );
@@ -225,7 +216,7 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
Widget buildListButtonForQuickSearchForm(BuildContext context, QuickSearchFilter filter) { Widget buildListButtonForQuickSearchForm(BuildContext context, QuickSearchFilter filter) {
return Obx(() { return Obx(() {
final isFilterSelected = filter.isApplied(dashBoardController.searchController.listFilterOnSuggestionForm); final isFilterSelected = filter.isApplied(_searchController.listFilterOnSuggestionForm);
return Chip( return Chip(
labelPadding: EdgeInsets.only( labelPadding: EdgeInsets.only(
@@ -242,7 +233,7 @@ class SearchInputFormWidget extends StatelessWidget with AppLoaderMixin {
style: filter.getTextStyle(isFilterSelected: isFilterSelected), style: filter.getTextStyle(isFilterSelected: isFilterSelected),
), ),
avatar: SvgPicture.asset( avatar: SvgPicture.asset(
filter.getIcon(imagePaths, isFilterSelected: isFilterSelected), filter.getIcon(_imagePaths, isFilterSelected: isFilterSelected),
width: 16, width: 16,
height: 16, height: 16,
fit: BoxFit.fill), fit: BoxFit.fill),
lib/features/manage_account/presentation/language_and_region/widgets/language_menu_overlay.dart
+4 -3
View File
@@ -12,7 +12,9 @@ class LanguageRegionOverlay extends StatelessWidget {
final double? maxWidth; final double? maxWidth;
final OnSelectLanguageAction onSelectLanguageAction; final OnSelectLanguageAction onSelectLanguageAction;
const LanguageRegionOverlay({ final _responsiveUtils = Get.find<ResponsiveUtils>();
LanguageRegionOverlay({
Key? key, Key? key,
required this.listSupportedLanguages, required this.listSupportedLanguages,
required this.localeSelected, required this.localeSelected,
@@ -54,11 +56,10 @@ class LanguageRegionOverlay extends StatelessWidget {
} }
double _getHeightOverlay(BuildContext context) { double _getHeightOverlay(BuildContext context) {
final responsiveUtils = Get.find<ResponsiveUtils>();
const double maxHeightTopBar = 80; const double maxHeightTopBar = 80;
const double maxHeightTitleLanguage = 200; const double maxHeightTitleLanguage = 200;
const double paddingBottom = 16; const double paddingBottom = 16;
final currentHeight = responsiveUtils.getSizeScreenHeight(context); final currentHeight = _responsiveUtils.getSizeScreenHeight(context);
double maxHeightForm = currentHeight - maxHeightTopBar - maxHeightTitleLanguage - paddingBottom; double maxHeightForm = currentHeight - maxHeightTopBar - maxHeightTitleLanguage - paddingBottom;
return maxHeightForm; return maxHeightForm;
} }