diff --git a/docs/adr/0022-fix-double-vertical-scroll-bar-on-composer.md b/docs/adr/0022-fix-double-vertical-scroll-bar-on-composer.md new file mode 100644 index 000000000..ef40fde56 --- /dev/null +++ b/docs/adr/0022-fix-double-vertical-scroll-bar-on-composer.md @@ -0,0 +1,26 @@ +# 22. Fix double vertical scroll bar when hide status bar + +Date: 2023-04-21 + +## Status + +- Issue: [#1740](https://github.com/linagora/tmail-flutter/issues/1740) + +## Context + +- Root cause: + - When we using `html_editor_enhanced` lib can't auto resize `HTML Iframe` when changing the size of the screen + - `.note-editor.note-airframe .note-editing-area .note-editable,.note-editor.note-frame .note-editing-area .note-editable` has an overridden padding under the widgets + - When enabling `Code View` modem has an overridden padding under the widgets. Can't see break line + +## Decision + +- Use `setFullScreen` to `HTML Iframe` for the purpose of automatically resizing when there are changes +- Remove padding of `.note-editor.note-airframe .note-editing-area .note-editable,.note-editor.note-frame .note-editing-area .note-editable` +- Enable resize editor `disableResizeEditor: false` +- Remove padding of `.note-editor.note-airframe .note-editing-area .note-codable,.note-editor.note-frame .note-editing-area .note-codable` when enabling `Code View` mode + +## Consequences + +- No longer appear two vertical scroll bars of content on the editor +- Automatically resize `HTML Iframe` for dimensions \ No newline at end of file diff --git a/pubspec.lock b/pubspec.lock index 8316b1ba8..d293305cb 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -29,10 +29,10 @@ packages: dependency: transitive description: name: archive - sha256: "0c8368c9b3f0abbc193b9d6133649a614204b528982bebc7026372d61677ce3a" + sha256: d6347d54a2d8028e0437e3c099f66fdb8ae02c4720c1e7534c9f24c10351f85d url: "https://pub.dev" source: hosted - version: "3.3.7" + version: "3.3.6" args: dependency: transitive description: @@ -532,10 +532,10 @@ packages: dependency: transitive description: name: flex_seed_scheme - sha256: b3678d82403c13dec2ee2721e078b26f14577712411b6aa981b0f4269df3fabb + sha256: "7058288ef97d348657ac95cea25d65a9aac181ca08387ede891fd7230ad7600f" url: "https://pub.dev" source: hosted - version: "1.2.4" + version: "1.2.3" flutter: dependency: "direct main" description: flutter @@ -728,10 +728,10 @@ packages: dependency: transitive description: name: flutter_platform_widgets - sha256: a10d674f1135a885fbef69ed50dbc1fe9fb6c4435154804b598446290fa9b5c4 + sha256: b787f001d659ce1fb601332e908efdf44dbedab832387b33162abeed60c1eca2 url: "https://pub.dev" source: hosted - version: "3.3.1" + version: "3.2.0" flutter_plugin_android_lifecycle: dependency: transitive description: @@ -866,8 +866,8 @@ packages: dependency: "direct main" description: path: "." - ref: "hotfix/duplicate_vertical_scroll_bar" - resolved-ref: "91dcba5c31fb7509ba9d926a013fe57991f324ab" + ref: email_supported + resolved-ref: dc173eab51bfd4dc0c25b8de1c85b648fc3b1a2f url: "https://github.com/linagora/html-editor-enhanced.git" source: git version: "2.5.1" @@ -1051,10 +1051,10 @@ packages: dependency: transitive description: name: numberpicker - sha256: "4c129154944b0f6b133e693f8749c3f8bfb67c4d07ef9dcab48b595c22d1f156" + sha256: "73723bd13c940ebcd9e5f0ed56b4874588c1748a9a6a38254f97ad627715142e" url: "https://pub.dev" source: hosted - version: "2.1.2" + version: "2.1.1" package_config: dependency: transitive description: @@ -1107,18 +1107,18 @@ packages: dependency: transitive description: name: path_provider_android - sha256: da97262be945a72270513700a92b39dd2f4a54dad55d061687e2e37a6390366a + sha256: "019f18c9c10ae370b08dce1f3e3b73bc9f58e7f087bb5e921f06529438ac0ae7" url: "https://pub.dev" source: hosted - version: "2.0.25" + version: "2.0.24" path_provider_foundation: dependency: transitive description: name: path_provider_foundation - sha256: ad4c4d011830462633f03eb34445a45345673dfd4faf1ab0b4735fbd93b19183 + sha256: "818b2dc38b0f178e0ea3f7cf3b28146faab11375985d815942a68eee11c2d0f7" url: "https://pub.dev" source: hosted - version: "2.2.2" + version: "2.2.1" path_provider_linux: dependency: transitive description: @@ -1235,10 +1235,10 @@ packages: dependency: transitive description: name: pointycastle - sha256: "7c1e5f0d23c9016c5bbd8b1473d0d3fb3fc851b876046039509e18e0c7485f2c" + sha256: c3120a968135aead39699267f4c74bc9a08e4e909e86bc1b0af5bfd78691123c url: "https://pub.dev" source: hosted - version: "3.7.3" + version: "3.7.2" pool: dependency: transitive description: @@ -1324,10 +1324,10 @@ packages: dependency: transitive description: name: share_plus_platform_interface - sha256: "0c6e61471bd71b04a138b8b588fa388e66d8b005e6f2deda63371c5c505a0981" + sha256: "82ddd4ab9260c295e6e39612d4ff00390b9a7a21f1bb1da771e2f232d80ab8a1" url: "https://pub.dev" source: hosted - version: "3.2.1" + version: "3.2.0" shared_preferences: dependency: "direct main" description: @@ -1340,18 +1340,18 @@ packages: dependency: transitive description: name: shared_preferences_android - sha256: "7fa90471a6875d26ad78c7e4a675874b2043874586891128dc5899662c97db46" + sha256: "8304d8a1f7d21a429f91dee552792249362b68a331ac5c3c1caf370f658873f6" url: "https://pub.dev" source: hosted - version: "2.1.2" + version: "2.1.0" shared_preferences_foundation: dependency: transitive description: name: shared_preferences_foundation - sha256: "0c1c16c56c9708aa9c361541a6f0e5cc6fc12a3232d866a687a7b7db30032b07" + sha256: cf2a42fb20148502022861f71698db12d937c7459345a1bdaa88fc91a91b3603 url: "https://pub.dev" source: hosted - version: "2.2.1" + version: "2.2.0" shared_preferences_linux: dependency: transitive description: @@ -1529,10 +1529,10 @@ packages: dependency: transitive description: name: timezone - sha256: "1cfd8ddc2d1cfd836bc93e67b9be88c3adaeca6f40a00ca999104c30693cdca0" + sha256: "24c8fcdd49a805d95777a39064862133ff816ebfffe0ceff110fb5960e557964" url: "https://pub.dev" source: hosted - version: "0.9.2" + version: "0.9.1" timing: dependency: transitive description: @@ -1585,18 +1585,18 @@ packages: dependency: transitive description: name: url_launcher_android - sha256: a52628068d282d01a07cd86e6ba99e497aa45ce8c91159015b2416907d78e411 + sha256: dd729390aa936bf1bdf5cd1bc7468ff340263f80a2c4f569416507667de8e3c8 url: "https://pub.dev" source: hosted - version: "6.0.27" + version: "6.0.26" url_launcher_ios: dependency: transitive description: name: url_launcher_ios - sha256: "9af7ea73259886b92199f9e42c116072f05ff9bea2dcb339ab935dfc957392c2" + sha256: "3dedc66ca3c0bef9e6a93c0999aee102556a450afcc1b7bcfeace7a424927d92" url: "https://pub.dev" source: hosted - version: "6.1.4" + version: "6.1.3" url_launcher_linux: dependency: transitive description: @@ -1609,10 +1609,10 @@ packages: dependency: transitive description: name: url_launcher_macos - sha256: "91ee3e75ea9dadf38036200c5d3743518f4a5eb77a8d13fda1ee5764373f185e" + sha256: "0ef2b4f97942a16523e51256b799e9aa1843da6c60c55eefbfa9dbc2dcb8331a" url: "https://pub.dev" source: hosted - version: "3.0.5" + version: "3.0.4" url_launcher_platform_interface: dependency: transitive description: @@ -1649,26 +1649,26 @@ packages: dependency: transitive description: name: vector_graphics - sha256: ea8d3fc7b2e0f35de38a7465063ecfcf03d8217f7962aa2a6717132cb5d43a79 + sha256: "4cf8e60dbe4d3a693d37dff11255a172594c0793da542183cbfe7fe978ae4aaa" url: "https://pub.dev" source: hosted - version: "1.1.5" + version: "1.1.4" vector_graphics_codec: dependency: transitive description: name: vector_graphics_codec - sha256: a5eaa5d19e123ad4f61c3718ca1ed921c4e6254238d9145f82aa214955d9aced + sha256: "278ad5f816f58b1967396d1f78ced470e3e58c9fe4b27010102c0a595c764468" url: "https://pub.dev" source: hosted - version: "1.1.5" + version: "1.1.4" vector_graphics_compiler: dependency: transitive description: name: vector_graphics_compiler - sha256: "15edc42f7eaa478ce854eaf1fbb9062a899c0e4e56e775dd73b7f4709c97c4ca" + sha256: "0bf61ad56e6fd6688a2865d3ceaea396bc6a0a90ea0d7ad5049b1b76c09d6163" url: "https://pub.dev" source: hosted - version: "1.1.5" + version: "1.1.4" vector_math: dependency: transitive description: @@ -1697,18 +1697,18 @@ packages: dependency: transitive description: name: web_socket_channel - sha256: d88238e5eac9a42bb43ca4e721edba3c08c6354d4a53063afaa568516217621b + sha256: ca49c0bc209c687b887f30527fb6a9d80040b072cc2990f34b9bec3e7663101b url: "https://pub.dev" source: hosted - version: "2.4.0" + version: "2.3.0" win32: dependency: transitive description: name: win32 - sha256: a6f0236dbda0f63aa9a25ad1ff9a9d8a4eaaa5012da0dc59d21afdb1dc361ca4 + sha256: c9ebe7ee4ab0c2194e65d3a07d8c54c5d00bb001b76081c4a04cdb8448b59e46 url: "https://pub.dev" source: hosted - version: "3.1.4" + version: "3.1.3" worker_manager: dependency: "direct main" description: diff --git a/pubspec.yaml b/pubspec.yaml index caf4ae2e5..13a9d78f3 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -54,7 +54,7 @@ dependencies: html_editor_enhanced: git: url: https://github.com/linagora/html-editor-enhanced.git - ref: hotfix/duplicate_vertical_scroll_bar + ref: email_supported jmap_dart_client: git: