diff --git a/core/lib/presentation/views/dialog/modal_list_action_button_widget.dart b/core/lib/presentation/views/dialog/modal_list_action_button_widget.dart index f33d3c8e0..afcaa4037 100644 --- a/core/lib/presentation/views/dialog/modal_list_action_button_widget.dart +++ b/core/lib/presentation/views/dialog/modal_list_action_button_widget.dart @@ -55,14 +55,17 @@ class ModalListActionButtonWidget extends StatelessWidget { ), ); - Widget progressingButton = const SizedBox( + Widget progressingButton = SizedBox( height: 48, width: 153, child: ConfirmDialogButton( - label: '', + label: positiveLabel, padding: EdgeInsets.zero, backgroundColor: AppColor.primaryMain, - child: CupertinoLoadingWidget(color: Colors.white), + child: CupertinoLoadingWidget( + color: Colors.white, + semanticLabel: positiveLabel, + ), ), ); diff --git a/integration_test/scenarios/labels/create_a_new_tag_from_an_email_scenario.dart b/integration_test/scenarios/labels/create_a_new_tag_from_an_email_scenario.dart index a8c2757f9..21e3b6b25 100644 --- a/integration_test/scenarios/labels/create_a_new_tag_from_an_email_scenario.dart +++ b/integration_test/scenarios/labels/create_a_new_tag_from_an_email_scenario.dart @@ -49,7 +49,7 @@ class CreateANewTagFromAnEmailScenario extends BaseTestScenario await addLabelModalRobot.tapCreateANewLabel(); await _expectCreateNewLabelModalVisible(); - const newLabelName = 'New Label 1'; + final newLabelName = 'New Label ${DateTime.now().microsecondsSinceEpoch}'; await createLabelModalRobot.enterNewLabelName(newLabelName); await createLabelModalRobot.tapPositiveActionButton(LabelActionType.create); await _expectLabelAsToEmailToastMessageSuccessVisible( diff --git a/lib/features/email/presentation/controller/single_email_controller.dart b/lib/features/email/presentation/controller/single_email_controller.dart index 55e59152f..339e9a533 100644 --- a/lib/features/email/presentation/controller/single_email_controller.dart +++ b/lib/features/email/presentation/controller/single_email_controller.dart @@ -952,6 +952,9 @@ class SingleEmailController extends BaseController with AppLoaderMixin { pressEmailAction(actionType, presentationEmail); break; case EmailActionType.labelAs: + if (!isLabelAvailable) { + return; + } mailboxDashBoardController.openAddLabelToEmailDialogModal( email: presentationEmail, onCreateANewLabelAction: () { diff --git a/lib/features/labels/presentation/label_controller.dart b/lib/features/labels/presentation/label_controller.dart index 160ef8d53..95822deff 100644 --- a/lib/features/labels/presentation/label_controller.dart +++ b/lib/features/labels/presentation/label_controller.dart @@ -107,10 +107,10 @@ class LabelController extends BaseController } @override - CreateNewLabelInteractor? get createNewLabelInteractor => _createNewLabelInteractor; + CreateNewLabelInteractor get createNewLabelInteractor => _createNewLabelInteractor!; @override - EditLabelInteractor? get editLabelInteractor => _editLabelInteractor; + EditLabelInteractor get editLabelInteractor => _editLabelInteractor!; DeleteALabelInteractor? get deleteALabelInteractor => _deleteALabelInteractor; @@ -221,9 +221,6 @@ class LabelController extends BaseController bool shouldPop = false, }) { toastManager.showMessageFailure(failure); - if (shouldPop) { - popBack(); - } } void _addLabelToList(Label newLabel) { diff --git a/lib/features/labels/presentation/mixin/label_modal_mixin.dart b/lib/features/labels/presentation/mixin/label_modal_mixin.dart index 59e39ad14..983a836d9 100644 --- a/lib/features/labels/presentation/mixin/label_modal_mixin.dart +++ b/lib/features/labels/presentation/mixin/label_modal_mixin.dart @@ -12,8 +12,8 @@ import 'package:tmail_ui_user/main/routes/dialog_router.dart'; mixin LabelModalMixin { List