From 6b1c7e23dca5268b0c77aa3a0ee1ce1d9c667a6a Mon Sep 17 00:00:00 2001 From: dab246 Date: Wed, 10 Dec 2025 12:10:17 +0700 Subject: [PATCH] TF-4193 Fix all `Nitpick comments` from coderabbit --- .../download_datasource_impl.dart | 10 ++-------- .../label_datasource_impl.dart | 10 ++-------- .../authentication_oidc_datasource_impl.dart | 5 +---- .../delete_authority_oidc_interactor.dart | 2 -- .../delete_credential_interactor.dart | 2 -- .../usecases/get_credential_interactor.dart | 2 -- .../mailbox_datasource_impl.dart | 5 +---- ...t_all_recent_search_latest_interactor.dart | 2 -- .../save_recent_search_interactor.dart | 2 -- .../manage_account_datasource_impl.dart | 19 +++++-------------- .../data/local/setting_cache_manager.dart | 3 +-- ...reate_new_default_identity_interactor.dart | 2 -- ...eate_new_email_rule_filter_interactor.dart | 2 -- .../create_new_identity_interactor.dart | 2 -- .../delete_email_rule_interactor.dart | 2 -- .../usecases/delete_identity_interactor.dart | 2 -- .../edit_default_identity_interactor.dart | 2 -- .../edit_email_rule_filter_interactor.dart | 2 -- .../usecases/edit_identity_interactor.dart | 2 -- .../get_all_identities_interactor.dart | 2 -- .../usecases/get_all_rules_interactor.dart | 2 -- .../usecases/get_all_vacation_interactor.dart | 2 -- .../usecases/get_forward_interactor.dart | 2 -- .../get_label_setting_state_interactor.dart | 4 ++-- .../get_label_visibility_interactor.dart | 2 -- .../save_label_visibility_interactor.dart | 2 -- .../usecases/save_language_interactor.dart | 1 - .../transform_list_signature_interactor.dart | 2 -- .../usecases/update_vacation_interactor.dart | 2 -- ...label_visibility_in_setting_extension.dart | 4 ++-- .../manage_account_dashboard_controller.dart | 2 +- .../menu/settings/settings_view.dart | 2 +- .../preferences/preferences_view.dart | 4 ++-- 33 files changed, 20 insertions(+), 91 deletions(-) diff --git a/lib/features/download/data/datasource_impl/download_datasource_impl.dart b/lib/features/download/data/datasource_impl/download_datasource_impl.dart index cbc789f2b..2608b6b27 100644 --- a/lib/features/download/data/datasource_impl/download_datasource_impl.dart +++ b/lib/features/download/data/datasource_impl/download_datasource_impl.dart @@ -40,10 +40,7 @@ class DownloadDatasourceImpl extends DownloadDatasource { onReceiveController: onReceiveController, cancelToken: cancelToken, ); - }).catchError((error, stackTrace) async { - await _exceptionThrower.throwException(error, stackTrace); - throw error; - }); + }).catchError(_exceptionThrower.throwException); } @override @@ -67,9 +64,6 @@ class DownloadDatasourceImpl extends DownloadDatasource { onReceiveController: onReceiveController, cancelToken: cancelToken, ); - }).catchError((error, stackTrace) async { - await _exceptionThrower.throwException(error, stackTrace); - throw error; - }); + }).catchError(_exceptionThrower.throwException); } } diff --git a/lib/features/labels/data/datasource_impl/label_datasource_impl.dart b/lib/features/labels/data/datasource_impl/label_datasource_impl.dart index 22ad004c4..22351bbc3 100644 --- a/lib/features/labels/data/datasource_impl/label_datasource_impl.dart +++ b/lib/features/labels/data/datasource_impl/label_datasource_impl.dart @@ -14,19 +14,13 @@ class LabelDatasourceImpl extends LabelDatasource { Future> getAllLabels(AccountId accountId) { return Future.sync(() async { return await _labelApi.getAllLabels(accountId); - }).catchError((error, stackTrace) async { - await _exceptionThrower.throwException(error, stackTrace); - throw error; - }); + }).catchError(_exceptionThrower.throwException); } @override Future