TF-4368 Add named parameters to mock setup for consistency.

This commit is contained in:
dab246
2026-03-11 13:11:06 +07:00
committed by Dat H. Pham
parent 2d45909ad1
commit 72aceff481
@@ -1060,32 +1060,38 @@ void main() {
}); });
group('ThreadRepositoryImpl::refreshChanges', () { group('ThreadRepositoryImpl::refreshChanges', () {
late ThreadRepositoryImpl threadRepository; late ThreadRepositoryImpl refreshChangesThreadRepository;
late MockThreadDataSource networkDataSource; late MockThreadDataSource networkDataSource;
late MockThreadDataSource localDataSource; late MockThreadDataSource localDataSource;
late MockStateDataSource stateDataSource; late MockStateDataSource refreshChangesStateDataSource;
setUp(() { setUp(() {
networkDataSource = MockThreadDataSource(); networkDataSource = MockThreadDataSource();
localDataSource = MockThreadDataSource(); localDataSource = MockThreadDataSource();
stateDataSource = MockStateDataSource(); refreshChangesStateDataSource = MockStateDataSource();
threadRepository = ThreadRepositoryImpl( refreshChangesThreadRepository = ThreadRepositoryImpl(
{ {
DataSourceType.network: networkDataSource, DataSourceType.network: networkDataSource,
DataSourceType.local: localDataSource, DataSourceType.local: localDataSource,
}, },
stateDataSource, refreshChangesStateDataSource,
); );
}); });
test( test(
'should call network when cache is empty', 'should call network when cache is empty',
() async { () async {
when(localDataSource.getAllEmailCache(any, any)) when(localDataSource.getAllEmailCache(
.thenAnswer((_) async => []); any,
any,
filterOption: anyNamed('filterOption'),
inMailboxId: anyNamed('inMailboxId'),
limit: anyNamed('limit'),
sort: anyNamed('sort'),
)).thenAnswer((_) async => []);
when(stateDataSource.getState(any, any, any)) when(refreshChangesStateDataSource.getState(any, any, any))
.thenAnswer((_) async => State('cache_state')); .thenAnswer((_) async => State('cache_state'));
when(networkDataSource.getChanges( when(networkDataSource.getChanges(
@@ -1111,7 +1117,7 @@ void main() {
state: State('network_state'), state: State('network_state'),
)); ));
final result = await threadRepository final result = await refreshChangesThreadRepository
.refreshChanges( .refreshChanges(
SessionFixtures.aliceSession, SessionFixtures.aliceSession,
AccountFixtures.aliceAccountId, AccountFixtures.aliceAccountId,
@@ -1141,10 +1147,16 @@ void main() {
(i) => Email(id: EmailId(Id('cache_$i'))), (i) => Email(id: EmailId(Id('cache_$i'))),
); );
when(localDataSource.getAllEmailCache(any, any)) when(localDataSource.getAllEmailCache(
.thenAnswer((_) async => cacheEmails); any,
any,
filterOption: anyNamed('filterOption'),
inMailboxId: anyNamed('inMailboxId'),
limit: anyNamed('limit'),
sort: anyNamed('sort'),
)).thenAnswer((_) async => cacheEmails);
when(stateDataSource.getState(any, any, any)) when(refreshChangesStateDataSource.getState(any, any, any))
.thenAnswer((_) async => State('cache_state')); .thenAnswer((_) async => State('cache_state'));
when(networkDataSource.getChanges( when(networkDataSource.getChanges(
@@ -1170,7 +1182,7 @@ void main() {
state: State('network_state'), state: State('network_state'),
)); ));
await threadRepository await refreshChangesThreadRepository
.refreshChanges( .refreshChanges(
SessionFixtures.aliceSession, SessionFixtures.aliceSession,
AccountFixtures.aliceAccountId, AccountFixtures.aliceAccountId,
@@ -1198,10 +1210,16 @@ void main() {
(i) => Email(id: EmailId(Id('cache_$i'))), (i) => Email(id: EmailId(Id('cache_$i'))),
); );
when(localDataSource.getAllEmailCache(any, any)) when(localDataSource.getAllEmailCache(
.thenAnswer((_) async => cacheEmails); any,
any,
filterOption: anyNamed('filterOption'),
inMailboxId: anyNamed('inMailboxId'),
limit: anyNamed('limit'),
sort: anyNamed('sort'),
)).thenAnswer((_) async => cacheEmails);
when(stateDataSource.getState(any, any, any)) when(refreshChangesStateDataSource.getState(any, any, any))
.thenAnswer((_) async => State('cache_state')); .thenAnswer((_) async => State('cache_state'));
when(networkDataSource.getChanges( when(networkDataSource.getChanges(
@@ -1214,7 +1232,7 @@ void main() {
hasMoreChanges: false, hasMoreChanges: false,
)); ));
final result = await threadRepository final result = await refreshChangesThreadRepository
.refreshChanges( .refreshChanges(
SessionFixtures.aliceSession, SessionFixtures.aliceSession,
AccountFixtures.aliceAccountId, AccountFixtures.aliceAccountId,
@@ -1244,10 +1262,16 @@ void main() {
(i) => Email(id: EmailId(Id('cache_$i'))), (i) => Email(id: EmailId(Id('cache_$i'))),
); );
when(localDataSource.getAllEmailCache(any, any)) when(localDataSource.getAllEmailCache(
.thenAnswer((_) async => cacheEmails); any,
any,
filterOption: anyNamed('filterOption'),
inMailboxId: anyNamed('inMailboxId'),
limit: anyNamed('limit'),
sort: anyNamed('sort'),
)).thenAnswer((_) async => cacheEmails);
when(stateDataSource.getState(any, any, any)) when(refreshChangesStateDataSource.getState(any, any, any))
.thenAnswer((_) async => State('cache_state')); .thenAnswer((_) async => State('cache_state'));
int callCount = 0; int callCount = 0;
@@ -1276,7 +1300,7 @@ void main() {
); );
}); });
final result = await threadRepository final result = await refreshChangesThreadRepository
.refreshChanges( .refreshChanges(
SessionFixtures.aliceSession, SessionFixtures.aliceSession,
AccountFixtures.aliceAccountId, AccountFixtures.aliceAccountId,
@@ -1293,6 +1317,11 @@ void main() {
)).called(2); )).called(2);
expect(result.emailChangeResponse, isNotNull); expect(result.emailChangeResponse, isNotNull);
expect(
result.emailChangeResponse?.created?.length,
equals(2),
reason: 'Should merge created emails from both pages',
);
}, },
); );
@@ -1304,10 +1333,16 @@ void main() {
(i) => Email(id: EmailId(Id('cache_$i'))), (i) => Email(id: EmailId(Id('cache_$i'))),
); );
when(localDataSource.getAllEmailCache(any, any)) when(localDataSource.getAllEmailCache(
.thenAnswer((_) async => cacheEmails); any,
any,
filterOption: anyNamed('filterOption'),
inMailboxId: anyNamed('inMailboxId'),
limit: anyNamed('limit'),
sort: anyNamed('sort'),
)).thenAnswer((_) async => cacheEmails);
when(stateDataSource.getState(any, any, any)) when(refreshChangesStateDataSource.getState(any, any, any))
.thenAnswer((_) async => State('cache_state')); .thenAnswer((_) async => State('cache_state'));
when(networkDataSource.getChanges( when(networkDataSource.getChanges(
@@ -1320,7 +1355,7 @@ void main() {
hasMoreChanges: false, hasMoreChanges: false,
)); ));
final result = await threadRepository final result = await refreshChangesThreadRepository
.refreshChanges( .refreshChanges(
SessionFixtures.aliceSession, SessionFixtures.aliceSession,
AccountFixtures.aliceAccountId, AccountFixtures.aliceAccountId,