TF-1749 Handle delete old email after update draft email

(cherry picked from commit 1a1331a723e191e3cae8db138f2d0fec71b4c87a)
This commit is contained in:
dab246
2023-04-07 18:28:09 +07:00
committed by Dat Vu
parent 60b6a0022a
commit 89d7f605d2
7 changed files with 44 additions and 25 deletions
@@ -1,13 +1,19 @@
import 'dart:async';
import 'dart:typed_data';
import 'package:core/core.dart';
import 'package:core/data/network/download/downloaded_response.dart';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
import 'package:dio/dio.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
import 'package:jmap_dart_client/jmap/core/session/session.dart';
import 'package:jmap_dart_client/jmap/mail/email/email.dart';
import 'package:model/model.dart';
import 'package:model/account/account_request.dart';
import 'package:model/download/download_task_id.dart';
import 'package:model/email/attachment.dart';
import 'package:model/email/mark_star_action.dart';
import 'package:model/email/read_actions.dart';
import 'package:tmail_ui_user/features/composer/domain/model/email_request.dart';
import 'package:tmail_ui_user/features/email/domain/model/move_to_mailbox_request.dart';
import 'package:tmail_ui_user/features/mailbox/domain/model/create_new_mailbox_request.dart';
@@ -61,7 +67,7 @@ abstract class EmailDataSource {
Future<bool> removeEmailDrafts(Session session, AccountId accountId, EmailId emailId);
Future<Email> updateEmailDrafts(Session session, AccountId accountId, Email newEmail, EmailId oldEmailId);
Future<Email> updateEmailDrafts(Session session, AccountId accountId, Email newEmail);
Future<List<EmailId>> deleteMultipleEmailsPermanently(Session session, AccountId accountId, List<EmailId> emailIds);
@@ -109,9 +109,9 @@ class EmailDataSourceImpl extends EmailDataSource {
}
@override
Future<Email> updateEmailDrafts(Session session, AccountId accountId, Email newEmail, EmailId oldEmailId) {
Future<Email> updateEmailDrafts(Session session, AccountId accountId, Email newEmail) {
return Future.sync(() async {
return await emailAPI.updateEmailDrafts(session, accountId, newEmail, oldEmailId);
return await emailAPI.updateEmailDrafts(session, accountId, newEmail);
}).catchError(_exceptionThrower.throwException);
}
@@ -528,13 +528,11 @@ class EmailAPI with HandleSetErrorMixin {
Future<Email> updateEmailDrafts(
Session session,
AccountId accountId,
Email newEmail,
EmailId oldEmailId
Email newEmail
) async {
final idCreateMethod = Id(_uuid.v1());
final setEmailMethod = SetEmailMethod(accountId)
..addCreate(idCreateMethod, newEmail)
..addDestroy({oldEmailId.id});
..addCreate(idCreateMethod, newEmail);
final requestBuilder = JmapRequestBuilder(_httpClient, ProcessingInvocation());
@@ -554,11 +552,10 @@ class EmailAPI with HandleSetErrorMixin {
);
final emailUpdated = setEmailResponse?.created?[idCreateMethod];
final isEmailDestroyedSuccess = setEmailResponse?.destroyed?.contains(oldEmailId.id) ?? false;
final listEntriesErrors = _handleSetEmailResponse(response: setEmailResponse);
final mapErrors = Map.fromEntries(listEntriesErrors);
if (emailUpdated != null && isEmailDestroyedSuccess && mapErrors.isEmpty) {
if (emailUpdated != null && mapErrors.isEmpty) {
return emailUpdated;
} else {
throw SetEmailMethodException(mapErrors);
@@ -131,8 +131,8 @@ class EmailRepositoryImpl extends EmailRepository {
}
@override
Future<Email> updateEmailDrafts(Session session, AccountId accountId, Email newEmail, EmailId oldEmailId) {
return emailDataSource.updateEmailDrafts(session, accountId, newEmail, oldEmailId);
Future<Email> updateEmailDrafts(Session session, AccountId accountId, Email newEmail) {
return emailDataSource.updateEmailDrafts(session, accountId, newEmail);
}
@override