TF-4178 Fix Nitpick comments from coderabbit

This commit is contained in:
dab246
2025-12-10 10:30:09 +07:00
committed by Dat H. Pham
parent 833df56cd8
commit 95831054b2
4 changed files with 9 additions and 4 deletions
@@ -320,7 +320,12 @@ class _ColorPickerModalState extends State<ColorPickerModal> {
} }
void _onHexColorChanged(String value) { void _onHexColorChanged(String value) {
_hsvColorNotifier.value = HSVColor.fromColor(value.toColor); final hex = value.trim();
if (hex.isEmpty) return;
try {
_hsvColorNotifier.value = HSVColor.fromColor(hex.toColor);
} catch (_) {}
} }
@override @override
@@ -11,6 +11,6 @@ extension ListLabelExtension on List<Label> {
} }
List<String> get displayNameNotNullList => map((label) => label.safeDisplayName) List<String> get displayNameNotNullList => map((label) => label.safeDisplayName)
.where((name) => name.isNotEmpty) .where((name) => name.trim().isNotEmpty)
.toList(); .toList();
} }
+1 -1
View File
@@ -5250,7 +5250,7 @@
"placeholders_order": [], "placeholders_order": [],
"placeholders": {} "placeholders": {}
}, },
"createLabelSuccessfullyMessage": "You successfully created {labelName} label", "createLabelSuccessfullyMessage": "You successfully created the {labelName} label",
"@createLabelSuccessfullyMessage": { "@createLabelSuccessfullyMessage": {
"type": "text", "type": "text",
"placeholders_order": [ "placeholders_order": [
@@ -5579,7 +5579,7 @@ class AppLocalizations {
String createLabelSuccessfullyMessage(String labelName) { String createLabelSuccessfullyMessage(String labelName) {
return Intl.message( return Intl.message(
'You successfully created $labelName label', 'You successfully created the $labelName label',
name: 'createLabelSuccessfullyMessage', name: 'createLabelSuccessfullyMessage',
args: [labelName], args: [labelName],
); );