eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-2046 Use controller cached in GetWidget instead of using Get.find<LoginController>()

Browse Source 
(cherry picked from commit 4403e2871d6486e693b6c4052df92b7634eadb25)
This commit is contained in:
dab246
2023-07-20 16:02:52 +07:00
committed by Dat Vu
parent efddcc0ae5
commit 980f7e34f3
3 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/login/presentation/login_view.dart
+10 -10
View File
@@ -32,8 +32,8 @@ class LoginView extends BaseLoginView {
scrollDirection: Axis.vertical,
child: _buildCenterForm(context))),
Obx(() {
if (loginController.loginFormType.value == LoginFormType.credentialForm
|| loginController.loginFormType.value == LoginFormType.ssoForm) {
if (controller.loginFormType.value == LoginFormType.credentialForm
|| controller.loginFormType.value == LoginFormType.ssoForm) {
return _buildBackButton(context);
}
return const SizedBox.shrink();
@@ -42,8 +42,8 @@ class LoginView extends BaseLoginView {
: Stack(children: [
_buildCenterForm(context),
Obx(() {
if (loginController.loginFormType.value == LoginFormType.credentialForm
|| loginController.loginFormType.value == LoginFormType.ssoForm) {
if (controller.loginFormType.value == LoginFormType.credentialForm
|| controller.loginFormType.value == LoginFormType.ssoForm) {
return _buildBackButton(context);
}
return const SizedBox.shrink();
@@ -72,7 +72,7 @@ class LoginView extends BaseLoginView {
style: const TextStyle(fontSize: 32, color: AppColor.colorNameEmail, fontWeight: FontWeight.w900)
)
),
Obx(() => buildLoginMessage(context, loginController.viewState.value)),
Obx(() => buildLoginMessage(context, controller.viewState.value)),
Obx(() {
switch (controller.loginFormType.value) {
case LoginFormType.baseUrlForm:
@@ -114,7 +114,7 @@ class LoginView extends BaseLoginView {
return Padding(
padding: const EdgeInsets.only(right: 24, left: 24, bottom: 24),
child: TypeAheadFormFieldBuilder<RecentLoginUrl>(
controller: loginController.urlInputController,
controller: controller.urlInputController,
textInputAction: TextInputAction.next,
keyboardType: TextInputType.url,
onTextSubmitted: (value) => controller.handleNextInUrlInputFormPress(),
@@ -124,8 +124,8 @@ class LoginView extends BaseLoginView {
.build(),
debounceDuration: const Duration(milliseconds: 300),
suggestionsCallback: (pattern) async {
loginController.formatUrl(pattern);
return loginController.getAllRecentLoginUrlAction(pattern);
controller.formatUrl(pattern);
return controller.getAllRecentLoginUrlAction(pattern);
},
itemBuilder: (context, loginUrl) => RecentItemTileWidget(loginUrl, imagePath: imagePaths),
onSuggestionSelected: (loginUrl) => controller.formatUrl(loginUrl.url),
@@ -165,7 +165,7 @@ class LoginView extends BaseLoginView {
style: const TextStyle(fontSize: 16, color: Colors.white)
),
onPressed: () {
loginController.handleNextInUrlInputFormPress();
controller.handleNextInUrlInputFormPress();
}
)
);
@@ -188,7 +188,7 @@ class LoginView extends BaseLoginView {
}
Widget _buildLoadingProgress(BuildContext context) {
return Obx(() => loginController.viewState.value.fold(
return Obx(() => controller.viewState.value.fold(
(failure) {
switch (controller.loginFormType.value) {
case LoginFormType.baseUrlForm: