Fix avoid creating a white overlay on email content when scrolling the thread

Signed-off-by: dab246 <tdvu@linagora.com>

lib/features/email/presentation/email_view.dart

@@ -63,32 +63,26 @@ class EmailView extends GetWidget<SingleEmailController> {
 
   @override
   Widget build(BuildContext context) {
-    return ColoredBox(
+    final bodyWidget = Container(
-      color: controller.responsiveUtils.isWebDesktop(context)
-        ? AppColor.colorBgDesktop
-        : Colors.white,
-      child: SafeArea(
-        right: controller.responsiveUtils.isLandscapeMobile(context),
-        left: controller.responsiveUtils.isLandscapeMobile(context),
-        bottom: !PlatformInfo.isIOS,
-        child: Container(
-          clipBehavior: Clip.antiAlias,
       decoration: _getDecorationEmailView(context),
       margin: _getMarginEmailView(context),
       child: Obx(() {
         final currentEmailListener = Rxn(controller.currentEmail);
         final currentEmail = currentEmailListener.value;
         if (currentEmail != null) {
-              return Column(children: [
+          return Column(
+            children: [
               if (!isInsideThreadDetailView)
-                  Obx(() => EmailViewAppBarWidget(
+                Obx(
+                  () => EmailViewAppBarWidget(
                     key: const Key('email_view_app_bar_widget'),
                     presentationEmail: currentEmail,
                     mailboxContain: _getMailboxContain(currentEmail),
                     isSearchActivated: controller.mailboxDashBoardController.searchController.isSearchEmailRunning,
                     onBackAction: () => controller.closeEmailView(context: context),
                     onEmailActionClick: (email, action) => controller.handleEmailAction(context, email, action),
-                    onMoreActionClick: (presentationEmail, position) => controller.emailActionReactor.handleMoreEmailAction(
+                    onMoreActionClick: (presentationEmail, position) {
+                      return controller.emailActionReactor.handleMoreEmailAction(
                         mailboxContain: controller.getMailboxContain(presentationEmail),
                         presentationEmail: presentationEmail,
                         position: position,
@@ -100,30 +94,44 @@ class EmailView extends GetWidget<SingleEmailController> {
                         emailIsRead: presentationEmail.hasRead,
                         openBottomSheetContextMenu: controller.mailboxDashBoardController.openBottomSheetContextMenu,
                         openPopupMenu: controller.mailboxDashBoardController.openPopupMenu,
-                    ),
+                      );
+                    },
                     supportBackAction: !isInsideThreadDetailView,
                     appBarDecoration: isInsideThreadDetailView
-                      ? const BoxDecoration(border: Border(bottom: BorderSide(
+                        ? const BoxDecoration(
+                            border: Border(
+                              bottom: BorderSide(
                                 color: AppColor.colorDividerEmailView,
-                        )))
+                              ),
+                            ),
+                          )
                         : null,
                     emailLoaded: controller.currentEmailLoaded.value,
                     isInsideThreadDetailView: isInsideThreadDetailView,
-                  )),
+                  ),
+                ),
               Obx(() {
                 final vacation = controller.mailboxDashBoardController.vacationResponse.value;
-                  if (vacation?.vacationResponderIsValid == true &&
+
-                      (
+                bool isPlatformSupportVacationVisible =
                     controller.responsiveUtils.isMobile(context) ||
                         controller.responsiveUtils.isTablet(context) ||
-                        controller.responsiveUtils.isLandscapeMobile(context)
+                        controller.responsiveUtils.isLandscapeMobile(context);
-                      )
+
-                  ) {
+                bool isVacationBannerVisible =
+                    vacation?.vacationResponderIsValid == true &&
+                        isPlatformSupportVacationVisible;
+
+                if (isVacationBannerVisible) {
                   return VacationNotificationMessageWidget(
-                      margin: const EdgeInsetsDirectional.only(start: 12, end: 12, top: 8),
+                    margin: const EdgeInsetsDirectional.only(
+                      start: 12,
+                      end: 12,
+                      top: 8,
+                    ),
                     vacationResponse: vacation!,
                     actionGotoVacationSetting: controller.mailboxDashBoardController.goToVacationSetting,
-                      actionEndNow: controller.mailboxDashBoardController.disableVacationResponder
+                    actionEndNow: controller.mailboxDashBoardController.disableVacationResponder,
                   );
                 } else {
                   return const SizedBox.shrink();
@@ -139,20 +147,24 @@ class EmailView extends GetWidget<SingleEmailController> {
                         width: double.infinity,
                         alignment: Alignment.center,
                         color: Colors.white,
-                          child: Obx(() => _buildEmailMessage(
+                        child: Obx(
+                          () => _buildEmailMessage(
                             context: context,
                             presentationEmail: currentEmail,
                             calendarEvent: controller.calendarEvent,
-                            maxBodyHeight: constraints.maxHeight
+                            maxBodyHeight: constraints.maxHeight,
-                          ))
+                          ),
-                        )
+                        ),
+                      ),
                     );
                   } else {
                     return Obx(() {
                       final calendarEvent = controller.calendarEvent;
                       if (currentEmail.hasCalendarEvent && calendarEvent != null) {
                         return Padding(
-                            padding: const EdgeInsetsDirectional.symmetric(horizontal: 4),
+                          padding: const EdgeInsetsDirectional.symmetric(
+                            horizontal: 4,
+                          ),
                           child: OptionalScroll(
                             scrollEnabled: !isInsideThreadDetailView,
                             child: Container(
@@ -164,16 +176,16 @@ class EmailView extends GetWidget<SingleEmailController> {
                                 presentationEmail: currentEmail,
                                 calendarEvent: calendarEvent,
                                 emailAddressSender: currentEmail.listEmailAddressSender.getListAddress(),
-                                  maxBodyHeight: constraints.maxHeight
+                                maxBodyHeight: constraints.maxHeight,
-                                )
+                              ),
-                              )
+                            ),
                           ),
                         );
                       } else {
                         return _buildEmailMessage(
                           context: context,
                           presentationEmail: currentEmail,
-                            maxBodyHeight: constraints.maxHeight
+                          maxBodyHeight: constraints.maxHeight,
                         );
                       }
                     });
@@ -197,14 +209,29 @@ class EmailView extends GetWidget<SingleEmailController> {
                   emailActionCallback: controller.pressEmailAction,
                 );
               }),
-              ]);
+            ],
+          );
         } else {
           return const EmailViewEmptyWidget();
         }
-          })
+      }),
-        )
-      )
     );
+
+    if (PlatformInfo.isMobile) {
+      return ColoredBox(
+        color: controller.responsiveUtils.isWebDesktop(context)
+          ? AppColor.colorBgDesktop
+          : Colors.white,
+        child: SafeArea(
+          right: controller.responsiveUtils.isLandscapeMobile(context),
+          left: controller.responsiveUtils.isLandscapeMobile(context),
+          bottom: !PlatformInfo.isIOS,
+          child: bodyWidget,
+        ),
+      );
+    } else {
+      return bodyWidget;
+    }
   }
 
   BoxDecoration _getDecorationEmailView(BuildContext context) {

lib/features/thread_detail/presentation/thread_detail_view.dart

@@ -29,8 +29,7 @@ class ThreadDetailView extends GetWidget<ThreadDetailController> {
   
   @override
   Widget build(BuildContext context) {
-    final child = SelectionArea(child: SafeArea(
+    Widget bodyWidget = Column(
-      child: Column(
       children: [
         Obx(() {
           final isLoading = showLoadingView(controller.viewState.value);
@@ -195,12 +194,19 @@ class ThreadDetailView extends GetWidget<ThreadDetailController> {
         if (controller.responsiveUtils.isDesktop(context))
           const SizedBox(height: 16),
       ],
-      ),
+    );
-    ));
+
+    if (PlatformInfo.isMobile) {
+      bodyWidget = SafeArea(child: bodyWidget);
+    }
+
+    if (PlatformInfo.isWeb) {
+      bodyWidget = SelectionArea(child: bodyWidget);
+    }
 
     return ClipRRect(
       borderRadius: const BorderRadius.vertical(bottom: Radius.circular(20)),
-      child: child,
+      child: bodyWidget,
     );
   }