eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-624 Remove null-aware of instance WidgetsBinding/SchedulerBinding on flutter 3.0

Browse Source
This commit is contained in:
dab246
2022-06-08 10:39:45 +07:00
committed by Dat H. Pham
parent 2b4270003e
commit a30dd68b1b
6 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/lib/presentation/views/quick_search/quick_search_input_form.dart
+3 -3
View File
@@ -591,7 +591,7 @@ class _TypeAheadFieldQuickSearchState<T, R> extends State<TypeAheadFieldQuickSea
void dispose() { void dispose() {
this._suggestionsBox!.close(); this._suggestionsBox!.close();
this._suggestionsBox!.widgetMounted = false; this._suggestionsBox!.widgetMounted = false;
WidgetsBinding.instance?.removeObserver(this); WidgetsBinding.instance.removeObserver(this);
_keyboardVisibilitySubscription?.cancel(); _keyboardVisibilitySubscription?.cancel();
_effectiveFocusNode!.removeListener(_focusNodeListener); _effectiveFocusNode!.removeListener(_focusNodeListener);
_focusNode?.dispose(); _focusNode?.dispose();
@@ -604,7 +604,7 @@ class _TypeAheadFieldQuickSearchState<T, R> extends State<TypeAheadFieldQuickSea
@override @override
void initState() { void initState() {
super.initState(); super.initState();
WidgetsBinding.instance?.addObserver(this); WidgetsBinding.instance.addObserver(this);
if (widget.textFieldConfiguration.controller == null) { if (widget.textFieldConfiguration.controller == null) {
this._textEditingController = TextEditingController(); this._textEditingController = TextEditingController();
@@ -643,7 +643,7 @@ class _TypeAheadFieldQuickSearchState<T, R> extends State<TypeAheadFieldQuickSea
} }
}); });
WidgetsBinding.instance?.addPostFrameCallback((duration) { WidgetsBinding.instance.addPostFrameCallback((duration) {
if (mounted) { if (mounted) {
this._initOverlayEntry(); this._initOverlayEntry();
// calculate initial suggestions list size // calculate initial suggestions list size
core/lib/utils/fps_manager.dart
+2 -2
View File
@@ -49,7 +49,7 @@ class FpsManager {
void start() async { void start() async {
if (BuildUtils.isDebugMode || BuildUtils.isProfileMode) { if (BuildUtils.isDebugMode || BuildUtils.isProfileMode) {
if (!_started) { if (!_started) {
SchedulerBinding.instance?.addTimingsCallback(_onTimingsCallback); SchedulerBinding.instance.addTimingsCallback(_onTimingsCallback);
_started = true; _started = true;
} }
} }
@@ -58,7 +58,7 @@ class FpsManager {
void stop() { void stop() {
if (BuildUtils.isDebugMode || BuildUtils.isProfileMode) { if (BuildUtils.isDebugMode || BuildUtils.isProfileMode) {
if (_started) { if (_started) {
SchedulerBinding.instance?.removeTimingsCallback(_onTimingsCallback); SchedulerBinding.instance.removeTimingsCallback(_onTimingsCallback);
_started = false; _started = false;
} }
} }
lib/features/composer/presentation/composer_controller.dart
+1 -1
View File
@@ -144,7 +144,7 @@ class ComposerController extends BaseController {
void onInit() { void onInit() {
super.onInit(); super.onInit();
if (!BuildUtils.isWeb) { if (!BuildUtils.isWeb) {
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) async { WidgetsBinding.instance.addPostFrameCallback((timeStamp) async {
await FkUserAgent.init(); await FkUserAgent.init();
}); });
} }
lib/features/login/data/network/authentication_client/authentication_client_web.dart
-2
View File
@@ -65,8 +65,6 @@ class AuthenticationClientWeb implements AuthenticationClientBase {
grantType: 'refresh_token', grantType: 'refresh_token',
scopes: scopes)); scopes: scopes));
log('AuthenticationClientMobile::refreshingTokensOIDC(): refreshToken: ${tokenResponse?.accessToken}');
if (tokenResponse != null) { if (tokenResponse != null) {
final tokenOIDC = tokenResponse.toTokenOIDC(); final tokenOIDC = tokenResponse.toTokenOIDC();
if (tokenOIDC.isTokenValid()) { if (tokenOIDC.isTokenValid()) {
lib/features/mailbox_dashboard/presentation/mailbox_dashboard_view_web.dart
+1 -1
View File
@@ -28,7 +28,7 @@ class MailboxDashBoardView extends BaseMailboxDashBoardView {
Widget build(BuildContext context) { Widget build(BuildContext context) {
if (controller.isDrawerOpen && (responsiveUtils.isDesktop(context) if (controller.isDrawerOpen && (responsiveUtils.isDesktop(context)
|| responsiveUtils.isTabletLarge(context))) { || responsiveUtils.isTabletLarge(context))) {
WidgetsBinding.instance?.addPostFrameCallback((_) { WidgetsBinding.instance.addPostFrameCallback((_) {
controller.closeMailboxMenuDrawer(); controller.closeMailboxMenuDrawer();
}); });
} }
lib/features/manage_account/presentation/manage_account_dashboard_view.dart
+1 -1
View File
@@ -22,7 +22,7 @@ class ManageAccountDashBoardView extends GetWidget<ManageAccountDashBoardControl
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
if (controller.isMenuDrawerOpen && _responsiveUtils.isDesktop(context)) { if (controller.isMenuDrawerOpen && _responsiveUtils.isDesktop(context)) {
WidgetsBinding.instance?.addPostFrameCallback((_) { WidgetsBinding.instance.addPostFrameCallback((_) {
controller.closeMenuDrawer(); controller.closeMenuDrawer();
}); });
} }