TF-4195 Fix comments of coderabbit

This commit is contained in:
dab246
2025-12-26 12:22:18 +07:00
committed by Dat H. Pham
parent 0076a7af57
commit e8b2c1d2a5
32 changed files with 235 additions and 146 deletions
@@ -206,6 +206,7 @@ abstract class EmailDataSource {
Future<String> generateEntireMessageAsDocument(ViewEntireMessageRequest entireMessageRequest);
Future<void> addLabelToEmail(
Session session,
AccountId accountId,
EmailId emailId,
KeyWordIdentifier labelKeyword,
@@ -556,12 +556,18 @@ class EmailDataSourceImpl extends EmailDataSource {
@override
Future<void> addLabelToEmail(
Session session,
AccountId accountId,
EmailId emailId,
KeyWordIdentifier labelKeyword,
) {
return Future.sync(() async {
return await emailAPI.addLabelToEmail(accountId, emailId, labelKeyword);
return await emailAPI.addLabelToEmail(
session,
accountId,
emailId,
labelKeyword,
);
}).catchError(_exceptionThrower.throwException);
}
}
@@ -577,7 +577,7 @@ class EmailHiveCacheDataSourceImpl extends EmailDataSource {
}
@override
Future<void> addLabelToEmail(AccountId accountId, EmailId emailId, KeyWordIdentifier labelKeyword) {
Future<void> addLabelToEmail(Session session, AccountId accountId, EmailId emailId, KeyWordIdentifier labelKeyword) {
throw UnimplementedError();
}
}
@@ -353,7 +353,7 @@ class EmailLocalStorageDataSourceImpl extends EmailDataSource {
}
@override
Future<void> addLabelToEmail(AccountId accountId, EmailId emailId, KeyWordIdentifier labelKeyword) {
Future<void> addLabelToEmail(Session session, AccountId accountId, EmailId emailId, KeyWordIdentifier labelKeyword) {
throw UnimplementedError();
}
}
@@ -267,7 +267,7 @@ class EmailSessionStorageDatasourceImpl extends EmailDataSource {
}
@override
Future<void> addLabelToEmail(AccountId accountId, EmailId emailId, KeyWordIdentifier labelKeyword) {
Future<void> addLabelToEmail(Session session, AccountId accountId, EmailId emailId, KeyWordIdentifier labelKeyword) {
throw UnimplementedError();
}
}
@@ -938,6 +938,7 @@ class EmailAPI with HandleSetErrorMixin, MailAPIMixin {
}
Future<void> addLabelToEmail(
Session session,
AccountId accountId,
EmailId emailId,
KeyWordIdentifier labelKeyword,
@@ -948,8 +949,9 @@ class EmailAPI with HandleSetErrorMixin, MailAPIMixin {
final builder = JmapRequestBuilder(_httpClient, ProcessingInvocation());
final invocation = builder.invocation(method);
final result =
await (builder..usings(method.requiredCapabilities)).build().execute();
final capabilities = method.requiredCapabilities
.toCapabilitiesSupportTeamMailboxes(session, accountId);
final result = await (builder..usings(capabilities)).build().execute();
final response = result.parse<SetEmailResponse>(
invocation.methodCallId,
@@ -483,11 +483,13 @@ class EmailRepositoryImpl extends EmailRepository {
@override
Future<void> addLabelToEmail(
Session session,
AccountId accountId,
EmailId emailId,
KeyWordIdentifier labelKeyword,
) {
return emailDataSource[DataSourceType.network]!.addLabelToEmail(
session,
accountId,
emailId,
labelKeyword,