From ef90aac1226ff3d0d02fd675ced1738ef16a4faa Mon Sep 17 00:00:00 2001 From: dab246 Date: Tue, 27 Aug 2024 15:12:20 +0700 Subject: [PATCH] Write unit test for sMimeStatus method --- .../list_email_header_extension_test.dart | 48 +++ .../extensions/email_extension_test.dart | 279 ++++++++++++++++++ ...nder_and_receiver_builder_widget_test.dart | 142 +-------- 3 files changed, 339 insertions(+), 130 deletions(-) create mode 100644 model/test/extensions/list_email_header_extension_test.dart create mode 100644 test/features/email/presentation/extensions/email_extension_test.dart diff --git a/model/test/extensions/list_email_header_extension_test.dart b/model/test/extensions/list_email_header_extension_test.dart new file mode 100644 index 000000000..11938247f --- /dev/null +++ b/model/test/extensions/list_email_header_extension_test.dart @@ -0,0 +1,48 @@ +import 'package:flutter_test/flutter_test.dart'; +import 'package:jmap_dart_client/jmap/mail/email/email_header.dart'; +import 'package:model/email/email_property.dart'; +import 'package:model/extensions/list_email_header_extension.dart'; + +void main() { + group('ListEmailHeaderExtension::test', () { + test('sMimeStatus returns correct value when header `X-SMIME-Status` is present', () { + final emailHeaders = { + EmailHeader(EmailProperty.headerSMimeStatusKey, 'Good signature') + }; + expect(emailHeaders.sMimeStatus, 'Good signature'); + }); + + test('sMimeStatus returns empty string when header is absent', () { + final emailHeaders = { + EmailHeader('OtherHeader', 'Value') + }; + expect(emailHeaders.sMimeStatus, ''); + }); + + test('sMimeStatus returns empty string for null set', () { + Set? emailHeaders; + expect(emailHeaders.sMimeStatus, ''); + }); + + test('sMimeStatus trims start whitespace from the value', () { + final emailHeaders = { + EmailHeader(EmailProperty.headerSMimeStatusKey, ' Good signature') + }; + expect(emailHeaders.sMimeStatus, 'Good signature'); + }); + + test('sMimeStatus trims end whitespace from the value', () { + final emailHeaders = { + EmailHeader(EmailProperty.headerSMimeStatusKey, 'Good signature ') + }; + expect(emailHeaders.sMimeStatus, 'Good signature'); + }); + + test('sMimeStatus trims start-end whitespace from the value', () { + final emailHeaders = { + EmailHeader(EmailProperty.headerSMimeStatusKey, ' Good signature ') + }; + expect(emailHeaders.sMimeStatus, 'Good signature'); + }); + }); +} diff --git a/test/features/email/presentation/extensions/email_extension_test.dart b/test/features/email/presentation/extensions/email_extension_test.dart new file mode 100644 index 000000000..7c6891c3c --- /dev/null +++ b/test/features/email/presentation/extensions/email_extension_test.dart @@ -0,0 +1,279 @@ +import 'package:flutter_test/flutter_test.dart'; +import 'package:jmap_dart_client/jmap/mail/email/email.dart'; +import 'package:jmap_dart_client/jmap/mail/email/email_header.dart'; +import 'package:jmap_dart_client/jmap/mail/email/individual_header_identifier.dart'; +import 'package:model/email/email_property.dart'; +import 'package:tmail_ui_user/features/email/presentation/extensions/email_extension.dart'; +import 'package:tmail_ui_user/features/email/presentation/model/smime_signature_status.dart'; + +void main() { + group('EmailExtension::sMimeStatus::test', () { + test( + 'SHOULD returns `SMimeSignatureStatus.goodSignature`\n' + 'WHEN email has sMimeStatusHeader is `Good signature`\n' + 'AND headers is null', () { + final email = Email( + sMimeStatusHeader: { + IndividualHeaderIdentifier.sMimeStatusHeader: 'Good signature' + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.goodSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.goodSignature`\n' + 'WHEN email has headers is `Good signature`\n' + 'AND sMimeStatusHeader is null', () { + final email = Email( + headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + 'Good signature') + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.goodSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.badSignature`\n' + 'WHEN sMimeStatusHeader is `Bad signature`', + () { + final email = Email( + sMimeStatusHeader: { + IndividualHeaderIdentifier.sMimeStatusHeader: 'Bad signature' + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.badSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.badSignature`\n' + 'WHEN headers is `Bad signature`', + () { + final email = Email( + headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + 'Bad signature') + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.badSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN sMimeStatusHeader is not `Good signature` or `Bad signature`', + () { + final email = Email( + sMimeStatusHeader: { + IndividualHeaderIdentifier.sMimeStatusHeader: 'SomeOtherValue' + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headers is not `Good signature` or `Bad signature`', + () { + final email = Email(headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + 'SomeOtherValue') + }); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headers is `Good signatures`', + () { + final email = Email(headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + 'Good signatures') + }); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headers is `Good Signatures`', + () { + final email = Email(headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + 'Good Signatures') + }); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headers is `Bad signatures`', + () { + final email = Email(headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + 'Bad signatures') + }); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headers is `Bad Signatures`', + () { + final email = Email(headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + 'Bad Signatures') + }); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headers is null AND sMimeStatusHeader is NULL', + () { + final email = Email(headers: null, sMimeStatusHeader: null); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headers is empty AND sMimeStatusHeader is null', + () { + final email = Email(headers: {}, sMimeStatusHeader: null); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.goodSignature`\n' + 'WHEN sMimeStatusHeader is ` Good signature`', + () { + final email = Email( + sMimeStatusHeader: { + IndividualHeaderIdentifier.sMimeStatusHeader: ' Good signature' + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.goodSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.badSignature`\n' + 'WHEN sMimeStatusHeader is ` Bad signature`', + () { + final email = Email( + sMimeStatusHeader: { + IndividualHeaderIdentifier.sMimeStatusHeader: ' Bad signature' + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.badSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.goodSignature`\n' + 'WHEN headerSMimeStatusKey has value is ` Good signature`', + () { + final email = Email( + headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + ' Good signature' + ) + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.goodSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.badSignature`\n' + 'WHEN headerSMimeStatusKey has value is ` Bad signature`', + () { + final email = Email( + headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + ' Bad signature' + ) + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.badSignature); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN sMimeStatusHeader is ` Good signatures`', + () { + final email = Email( + sMimeStatusHeader: { + IndividualHeaderIdentifier.sMimeStatusHeader: ' Good signatures' + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN sMimeStatusHeader is ` Bad signatures`', + () { + final email = Email( + sMimeStatusHeader: { + IndividualHeaderIdentifier.sMimeStatusHeader: ' Bad signatures' + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headerSMimeStatusKey has value is ` Good signatures`', + () { + final email = Email( + headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + ' Good signatures' + ) + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + + test( + 'SHOULD returns `SMimeSignatureStatus.notSigned`\n' + 'WHEN headerSMimeStatusKey has value is ` Bad signatures`', + () { + final email = Email( + headers: { + EmailHeader( + EmailProperty.headerSMimeStatusKey, + ' Bad signatures' + ) + } + ); + + expect(email.sMimeStatus, SMimeSignatureStatus.notSigned); + }); + }); +} diff --git a/test/features/email/presentation/information_sender_and_receiver_builder_widget_test.dart b/test/features/email/presentation/information_sender_and_receiver_builder_widget_test.dart index 60d358c66..f2edf69e1 100644 --- a/test/features/email/presentation/information_sender_and_receiver_builder_widget_test.dart +++ b/test/features/email/presentation/information_sender_and_receiver_builder_widget_test.dart @@ -7,9 +7,8 @@ import 'package:get/get.dart'; import 'package:jmap_dart_client/jmap/core/id.dart'; import 'package:jmap_dart_client/jmap/mail/email/email.dart'; import 'package:jmap_dart_client/jmap/mail/email/email_address.dart'; -import 'package:jmap_dart_client/jmap/mail/email/email_header.dart'; -import 'package:model/email/email_property.dart'; import 'package:model/email/presentation_email.dart'; +import 'package:tmail_ui_user/features/email/presentation/model/smime_signature_status.dart'; import 'package:tmail_ui_user/features/email/presentation/widgets/information_sender_and_receiver_builder.dart'; import 'package:tmail_ui_user/main/localizations/app_localizations_delegate.dart'; import 'package:tmail_ui_user/main/localizations/localization_service.dart'; @@ -34,19 +33,17 @@ void main() { } group('SMimeSignatureStatusIcon::test', () { - testWidgets('should be displayed when email header has X-SMIME-Status', (tester) async { + testWidgets('should be displayed when sMimeStatus is `SMimeSignatureStatus.goodSignature`', (tester) async { final presentationEmail = PresentationEmail( id: EmailId(Id('a123')), from: { EmailAddress('example', 'example@linagora.com') - }, - emailHeader: [ - EmailHeader(EmailProperty.headerSMimeStatusKey, 'Good signature') - ] + } ); final widget = makeTestableWidget( child: InformationSenderAndReceiverBuilder( emailSelected: presentationEmail, + sMimeStatus: SMimeSignatureStatus.goodSignature, responsiveUtils: responsiveUtils, imagePaths: imagePaths, emailUnsubscribe: null, @@ -64,20 +61,18 @@ void main() { testWidgets( 'should be displayed and have good message \n' - 'when email header has X-SMIME-Status = "Good signature"', + 'when sMimeStatus is `SMimeSignatureStatus.goodSignature`', (tester) async { final presentationEmail = PresentationEmail( id: EmailId(Id('a123')), from: { EmailAddress('example', 'example@linagora.com') - }, - emailHeader: [ - EmailHeader(EmailProperty.headerSMimeStatusKey, 'Good signature') - ] + } ); final widget = makeTestableWidget( child: InformationSenderAndReceiverBuilder( emailSelected: presentationEmail, + sMimeStatus: SMimeSignatureStatus.goodSignature, responsiveUtils: responsiveUtils, imagePaths: imagePaths, emailUnsubscribe: null, @@ -101,20 +96,18 @@ void main() { testWidgets( 'should be displayed and have bad message \n' - 'when email header has X-SMIME-Status = "Bad signature"', + 'when sMimeStatus is `SMimeSignatureStatus.badSignature`', (tester) async { final presentationEmail = PresentationEmail( id: EmailId(Id('a123')), from: { EmailAddress('example', 'example@linagora.com') - }, - emailHeader: [ - EmailHeader(EmailProperty.headerSMimeStatusKey, 'Bad signature') - ] + } ); final widget = makeTestableWidget( child: InformationSenderAndReceiverBuilder( emailSelected: presentationEmail, + sMimeStatus: SMimeSignatureStatus.badSignature, responsiveUtils: responsiveUtils, imagePaths: imagePaths, emailUnsubscribe: null, @@ -136,7 +129,7 @@ void main() { 'This message failed SMime signature verification.'); }); - testWidgets('should not be displayed when email header do not have X-SMIME-Status', (tester) async { + testWidgets('should not be displayed when sMimeStatus is `SMimeSignatureStatus.notSigned`', (tester) async { final presentationEmail = PresentationEmail( id: EmailId(Id('a123')), from: { @@ -146,118 +139,7 @@ void main() { final widget = makeTestableWidget( child: InformationSenderAndReceiverBuilder( emailSelected: presentationEmail, - responsiveUtils: responsiveUtils, - imagePaths: imagePaths, - emailUnsubscribe: null, - ), - ); - - await tester.pumpWidget(widget); - - await tester.pumpAndSettle(); - - expect( - find.byKey(const Key('smime_signature_status_icon')), - findsNothing); - }); - - testWidgets('should not be displayed when email header have X-SMIME-Status = "Good Signatures"', (tester) async { - final presentationEmail = PresentationEmail( - id: EmailId(Id('a123')), - from: { - EmailAddress('example', 'example@linagora.com') - }, - emailHeader: [ - EmailHeader(EmailProperty.headerSMimeStatusKey, 'Good Signatures') - ] - ); - final widget = makeTestableWidget( - child: InformationSenderAndReceiverBuilder( - emailSelected: presentationEmail, - responsiveUtils: responsiveUtils, - imagePaths: imagePaths, - emailUnsubscribe: null, - ), - ); - - await tester.pumpWidget(widget); - - await tester.pumpAndSettle(); - - expect( - find.byKey(const Key('smime_signature_status_icon')), - findsNothing); - }); - - testWidgets('should not be displayed when email header have X-SMIME-Status = "Good signatures"', (tester) async { - final presentationEmail = PresentationEmail( - id: EmailId(Id('a123')), - from: { - EmailAddress('example', 'example@linagora.com') - }, - emailHeader: [ - EmailHeader(EmailProperty.headerSMimeStatusKey, 'Good signatures') - ] - ); - final widget = makeTestableWidget( - child: InformationSenderAndReceiverBuilder( - emailSelected: presentationEmail, - responsiveUtils: responsiveUtils, - imagePaths: imagePaths, - emailUnsubscribe: null, - ), - ); - - await tester.pumpWidget(widget); - - await tester.pumpAndSettle(); - - expect( - find.byKey(const Key('smime_signature_status_icon')), - findsNothing); - }); - - testWidgets('should not be displayed when email header have X-SMIME-Status = "Bad Signatures"', (tester) async { - final presentationEmail = PresentationEmail( - id: EmailId(Id('a123')), - from: { - EmailAddress('example', 'example@linagora.com') - }, - emailHeader: [ - EmailHeader(EmailProperty.headerSMimeStatusKey, 'Bad Signatures') - ] - ); - final widget = makeTestableWidget( - child: InformationSenderAndReceiverBuilder( - emailSelected: presentationEmail, - responsiveUtils: responsiveUtils, - imagePaths: imagePaths, - emailUnsubscribe: null, - ), - ); - - await tester.pumpWidget(widget); - - await tester.pumpAndSettle(); - - expect( - find.byKey(const Key('smime_signature_status_icon')), - findsNothing); - }); - - testWidgets('should not be displayed when email header have X-SMIME-Status = "Bad signatures"', (tester) async { - final presentationEmail = PresentationEmail( - id: EmailId(Id('a123')), - from: { - EmailAddress('example', 'example@linagora.com') - }, - emailHeader: [ - EmailHeader(EmailProperty.headerSMimeStatusKey, 'Bad signatures') - ] - ); - final widget = makeTestableWidget( - child: InformationSenderAndReceiverBuilder( - emailSelected: presentationEmail, + sMimeStatus: SMimeSignatureStatus.notSigned, responsiveUtils: responsiveUtils, imagePaths: imagePaths, emailUnsubscribe: null,