Fix padding item email in Thread and Search

Signed-off-by: dab246 <tdvu@linagora.com>
(cherry picked from commit 377085ba9054c6eb4c8e3d8388821473b3335962)

lib/features/mailbox_dashboard/presentation/mailbox_dashboard_view_web.dart

@@ -61,10 +61,7 @@ class MailboxDashBoardView extends BaseMailboxDashBoardView {
                       Container(
                         width: ResponsiveUtils.defaultSizeMenu,
                         color: Colors.white,
-                        padding: EdgeInsets.only(
-                          left: AppUtils.isDirectionRTL(context) ? 0 : 28,
-                          right: AppUtils.isDirectionRTL(context) ? 28 : 0,
-                        ),
+                        padding: const EdgeInsetsDirectional.only(start: 28),
                         alignment: Alignment.center,
                         height: 80,
                         child: Row(children: [
@@ -246,26 +243,21 @@ class MailboxDashBoardView extends BaseMailboxDashBoardView {
 
   Widget _buildThreadViewForWebDesktop(BuildContext context) {
     return Container(
-      margin: EdgeInsets.only(
-        right: AppUtils.isDirectionRTL(context) ? 0 : 16,
-        left: AppUtils.isDirectionRTL(context) ? 16 : 0,
-        top: 8,
-        bottom: 16
-      ),
+      margin: const EdgeInsetsDirectional.only(end: 16, top: 8, bottom: 16),
       decoration: BoxDecoration(
-        borderRadius: BorderRadius.circular(20),
+        borderRadius: const BorderRadius.all(Radius.circular(20)),
         border: Border.all(color: AppColor.colorBorderBodyThread, width: 1),
         color: Colors.white),
       child: ClipRRect(
-        borderRadius: BorderRadius.circular(20),
+        borderRadius: const BorderRadius.all(Radius.circular(20)),
         child: Column(children: [
           Obx(() {
-            if (controller.isSelectionEnabled()) {
+            final listEmailSelected = controller.listEmailSelected;
+            if (controller.isSelectionEnabled() && listEmailSelected.isNotEmpty) {
               return Padding(
-                padding: const EdgeInsets.all(12.0),
+                padding: const EdgeInsets.symmetric(vertical: 8.5, horizontal: 16),
                 child: TopBarThreadSelection(
-                  context,
-                  controller.listEmailSelected,
+                  listEmailSelected,
                   controller.mapMailboxById,
                   onCancelSelection: () =>
                     controller.dispatchAction(CancelSelectionAllEmailAction()),
@@ -275,11 +267,11 @@ class MailboxDashBoardView extends BaseMailboxDashBoardView {
                       listEmails,
                       actionType
                     )),
-                ).build(),
+                ),
               );
             } else {
               return Padding(
-                padding: const EdgeInsets.all(16.0),
+                padding: const EdgeInsets.symmetric(vertical: 12, horizontal: 16),
                 child: _buildListButtonTopBar(context),
               );
             }

lib/features/mailbox_dashboard/presentation/widgets/top_bar_thread_selection.dart

@@ -1,9 +1,8 @@
 
 import 'package:core/presentation/extensions/color_extension.dart';
 import 'package:core/presentation/resources/image_paths.dart';
-import 'package:core/presentation/views/button/icon_button_web.dart';
-import 'package:flutter/widgets.dart';
-import 'package:flutter_svg/flutter_svg.dart';
+import 'package:core/presentation/views/button/tmail_button_widget.dart';
+import 'package:flutter/material.dart';
 import 'package:get/get.dart';
 import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart';
 import 'package:model/email/email_action_type.dart';
@@ -14,125 +13,138 @@ import 'package:tmail_ui_user/main/localizations/app_localizations.dart';
 
 typedef OnEmailActionTypeAction = Function(List<PresentationEmail> listEmail, EmailActionType actionType);
 
-class TopBarThreadSelection {
+class TopBarThreadSelection extends StatelessWidget{
 
   final imagePaths = Get.find<ImagePaths>();
 
-  final BuildContext context;
   final List<PresentationEmail> listEmail;
   final Map<MailboxId, PresentationMailbox> mapMailbox;
   final OnEmailActionTypeAction? onEmailActionTypeAction;
   final VoidCallback? onCancelSelection;
 
   TopBarThreadSelection(
-    this.context,
     this.listEmail,
-    this.mapMailbox, {
-    this.onEmailActionTypeAction,
-    this.onCancelSelection,
-  });
+    this.mapMailbox,
+    {
+      super.key,
+      this.onEmailActionTypeAction,
+      this.onCancelSelection,
+    }
+  );
 
-  Widget build() {
+  @override
+  Widget build(BuildContext context) {
     final canDeletePermanently = listEmail.isAllCanDeletePermanently(mapMailbox);
     final canSpamAndMove = listEmail.isAllCanSpamAndMove(mapMailbox);
     final isAllSpam = listEmail.isAllSpam(mapMailbox);
     final isAllBelongToTheSameMailbox = listEmail.isAllBelongToTheSameMailbox(mapMailbox);
 
     return Row(children: [
-      buildIconWeb(
-          icon: SvgPicture.asset(
-              imagePaths.icClose,
-              colorFilter: AppColor.colorTextButton.asFilter(),
-              fit: BoxFit.fill),
-          tooltip: AppLocalizations.of(context).cancel,
-          onTap: onCancelSelection),
-      Text(AppLocalizations.of(context).count_email_selected(listEmail.length),
-          style: const TextStyle(
-              fontSize: 17,
-              fontWeight: FontWeight.w500,
-              color: AppColor.colorTextButton)),
+      TMailButtonWidget.fromIcon(
+        icon: imagePaths.icClose,
+        iconColor: AppColor.primaryColor,
+        tooltipMessage: AppLocalizations.of(context).cancel,
+        backgroundColor: Colors.transparent,
+        iconSize: 28,
+        padding: const EdgeInsets.all(3),
+        onTapActionCallback: onCancelSelection
+      ),
+      Text(
+        AppLocalizations.of(context).count_email_selected(listEmail.length),
+        style: const TextStyle(
+          fontSize: 17,
+          fontWeight: FontWeight.w500,
+          color: AppColor.colorTextButton
+        )
+      ),
       const SizedBox(width: 30),
-      buildIconWeb(
-          icon: SvgPicture.asset(
-              listEmail.isAllEmailRead
-                  ? imagePaths.icUnread
-                  : imagePaths.icRead,
-              fit: BoxFit.fill),
-          tooltip: listEmail.isAllEmailRead
-              ? AppLocalizations.of(context).mark_as_unread
-              : AppLocalizations.of(context).mark_as_read,
-          onTap: () => onEmailActionTypeAction?.call(
-              List.from(listEmail),
-              listEmail.isAllEmailRead
-                  ? EmailActionType.markAsUnread
-                  : EmailActionType.markAsRead)),
-      buildIconWeb(
-          icon: SvgPicture.asset(
-              listEmail.isAllEmailStarred
-                  ? imagePaths.icUnStar
-                  : imagePaths.icStar,
-              fit: BoxFit.fill),
-          tooltip: listEmail.isAllEmailStarred
-              ? AppLocalizations.of(context).un_star
-              : AppLocalizations.of(context).star,
-          onTap: () => onEmailActionTypeAction?.call(
-              List.from(listEmail),
-              listEmail.isAllEmailStarred
-                  ? EmailActionType.unMarkAsStarred
-                  : EmailActionType.markAsStarred)),
+      TMailButtonWidget.fromIcon(
+        icon:  listEmail.isAllEmailRead
+          ? imagePaths.icUnread
+          : imagePaths.icRead,
+        tooltipMessage: listEmail.isAllEmailRead
+          ? AppLocalizations.of(context).mark_as_unread
+          : AppLocalizations.of(context).mark_as_read,
+        backgroundColor: Colors.transparent,
+        iconSize: 24,
+        onTapActionCallback: () => onEmailActionTypeAction?.call(
+          List.from(listEmail),
+          listEmail.isAllEmailRead ? EmailActionType.markAsUnread : EmailActionType.markAsRead
+        )
+      ),
+      TMailButtonWidget.fromIcon(
+        icon: listEmail.isAllEmailStarred
+          ? imagePaths.icUnStar
+          : imagePaths.icStar,
+        tooltipMessage: listEmail.isAllEmailStarred
+          ? AppLocalizations.of(context).un_star
+          : AppLocalizations.of(context).star,
+        backgroundColor: Colors.transparent,
+        iconSize: 24,
+        onTapActionCallback: () => onEmailActionTypeAction?.call(
+          List.from(listEmail),
+          listEmail.isAllEmailStarred ? EmailActionType.unMarkAsStarred : EmailActionType.markAsStarred
+        )
+      ),
     if (canSpamAndMove)
      ...[
-       buildIconWeb(
-           icon: SvgPicture.asset(imagePaths.icMove, fit: BoxFit.fill),
-           tooltip: AppLocalizations.of(context).move,
-           onTap: () => onEmailActionTypeAction?.call(
+       TMailButtonWidget.fromIcon(
+         icon: imagePaths.icMove,
+         iconSize: 22,
+         tooltipMessage: AppLocalizations.of(context).move,
+         backgroundColor: Colors.transparent,
+         onTapActionCallback: () => onEmailActionTypeAction?.call(
+           List.from(listEmail),
+           EmailActionType.moveToMailbox
+         )
+       ),
+       TMailButtonWidget.fromIcon(
+         icon: isAllSpam ? imagePaths.icNotSpam : imagePaths.icSpam,
+         backgroundColor: Colors.transparent,
+         iconSize: 24,
+         tooltipMessage: isAllSpam
+           ? AppLocalizations.of(context).un_spam
+           : AppLocalizations.of(context).mark_as_spam,
+         onTapActionCallback: () {
+           if (isAllSpam) {
+             onEmailActionTypeAction?.call(
                List.from(listEmail),
-               EmailActionType.moveToMailbox)),
-       buildIconWeb(
-           icon: SvgPicture.asset(
-               isAllSpam ? imagePaths.icNotSpam : imagePaths.icSpam,
-               fit: BoxFit.fill),
-           tooltip: isAllSpam
-               ? AppLocalizations.of(context).un_spam
-               : AppLocalizations.of(context).mark_as_spam,
-           onTap: () {
-             if (isAllSpam) {
-               onEmailActionTypeAction?.call(
-                   List.from(listEmail),
-                   EmailActionType.unSpam);
-             } else {
-               onEmailActionTypeAction?.call(
-                   List.from(listEmail.listEmailCanSpam(mapMailbox)),
-                   EmailActionType.moveToSpam);
-             }
-           })
+               EmailActionType.unSpam
+             );
+           } else {
+             onEmailActionTypeAction?.call(
+               List.from(listEmail.listEmailCanSpam(mapMailbox)),
+               EmailActionType.moveToSpam
+             );
+           }
+         }
+       )
       ],
       if (isAllBelongToTheSameMailbox)
-        buildIconWeb(
-          icon: SvgPicture.asset(
-              canDeletePermanently
-                  ? imagePaths.icDeleteComposer
-                  : imagePaths.icDelete,
-              colorFilter: canDeletePermanently
-                  ? AppColor.colorDeletePermanentlyButton.asFilter()
-                  : AppColor.primaryColor.asFilter(),
-              width: 20,
-              height: 20,
-              fit: BoxFit.fill),
-          tooltip: canDeletePermanently
-              ? AppLocalizations.of(context).delete_permanently
-              : AppLocalizations.of(context).move_to_trash,
-          onTap: () {
+        TMailButtonWidget.fromIcon(
+          icon: imagePaths.icDeleteComposer,
+          backgroundColor: Colors.transparent,
+          iconSize: 20,
+          iconColor: canDeletePermanently
+            ? AppColor.colorDeletePermanentlyButton
+            : AppColor.primaryColor,
+          tooltipMessage: canDeletePermanently
+            ? AppLocalizations.of(context).delete_permanently
+            : AppLocalizations.of(context).move_to_trash,
+          onTapActionCallback: () {
             if (canDeletePermanently) {
               onEmailActionTypeAction?.call(
-                  List.from(listEmail),
-                  EmailActionType.deletePermanently);
+                List.from(listEmail),
+                EmailActionType.deletePermanently
+              );
             } else {
               onEmailActionTypeAction?.call(
-                  List.from(listEmail),
-                  EmailActionType.moveToTrash);
+                List.from(listEmail),
+                EmailActionType.moveToTrash
+              );
             }
-          }),
+          }
+        ),
     ]);
   }
 }