TF-2311 Sync use variables in BaseController to avoid wasting memory

Signed-off-by: dab246 <tdvu@linagora.com> Signed-off-by: dab246 <tdvu@linagora.com> (cherry picked from commit 21ac80615f7bc9e832fd72cb8ae6875c967d3cea)
2023-11-14 17:33:17 +07:00
parent 4ff601b4fc
commit fb47832225
57 changed files with 727 additions and 958 deletions
@@ -62,6 +62,7 @@ import 'package:tmail_ui_user/features/email/presentation/widgets/attachment_lis
 import 'package:tmail_ui_user/features/email/presentation/widgets/attachment_list/attachment_list_dialog_builder.dart';
 import 'package:tmail_ui_user/features/email/presentation/widgets/email_address_bottom_sheet_builder.dart';
 import 'package:tmail_ui_user/features/email/presentation/widgets/email_address_dialog_builder.dart';
+import 'package:tmail_ui_user/features/home/data/exceptions/session_exceptions.dart';
 import 'package:tmail_ui_user/features/mailbox/presentation/action/mailbox_ui_action.dart';
 import 'package:tmail_ui_user/features/mailbox/presentation/model/mailbox_actions.dart';
 import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/controller/mailbox_dashboard_controller.dart';
@@ -74,7 +75,6 @@ import 'package:tmail_ui_user/features/manage_account/domain/usecases/create_new
 import 'package:tmail_ui_user/features/manage_account/domain/usecases/get_all_identities_interactor.dart';
 import 'package:tmail_ui_user/features/manage_account/presentation/extensions/datetime_extension.dart';
 import 'package:tmail_ui_user/features/rules_filter_creator/presentation/model/rules_filter_creator_arguments.dart';
-import 'package:tmail_ui_user/features/session/data/exceptions/session_exceptions.dart';
 import 'package:tmail_ui_user/features/thread/domain/constants/thread_constants.dart';
 import 'package:tmail_ui_user/features/thread/presentation/model/delete_action_type.dart';
 import 'package:tmail_ui_user/main/error/capability_validator.dart';
@@ -85,18 +85,12 @@ import 'package:tmail_ui_user/main/routes/navigation_router.dart';
 import 'package:tmail_ui_user/main/routes/route_navigation.dart';
 import 'package:tmail_ui_user/main/routes/route_utils.dart';
 import 'package:tmail_ui_user/main/utils/app_utils.dart';
-import 'package:uuid/uuid.dart';

 class SingleEmailController extends BaseController with AppLoaderMixin {

  final mailboxDashBoardController = Get.find<MailboxDashBoardController>();
  final emailSupervisorController = Get.find<EmailSupervisorController>();
-  final responsiveUtils = Get.find<ResponsiveUtils>();
-  final imagePaths = Get.find<ImagePaths>();
-  final _appToast = Get.find<AppToast>();
-  final _uuid = Get.find<Uuid>();
  final _downloadManager = Get.find<DownloadManager>();
-  final _dynamicUrlInterceptors = Get.find<DynamicUrlInterceptors>();
  final _attachmentListScrollController = ScrollController();

  final GetEmailContentInteractor _getEmailContentInteractor;
@@ -297,7 +291,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
                    attachment: success.attachment));

              if (currentOverlayContext != null && currentContext != null) {
-                _appToast.showToastMessage(
+                appToast.showToastMessage(
                  currentOverlayContext!,
                  AppLocalizations.of(currentContext!).your_download_has_started,
                  leadingSVGIconColor: AppColor.primaryColor,
@@ -396,7 +390,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
      final session = mailboxDashBoardController.sessionCurrent;
      final accountId = mailboxDashBoardController.accountId.value;
      if (session != null && accountId != null) {
-        final baseDownloadUrl = mailboxDashBoardController.sessionCurrent?.getDownloadUrl(jmapUrl: _dynamicUrlInterceptors.jmapUrl) ?? '';
+        final baseDownloadUrl = mailboxDashBoardController.sessionCurrent?.getDownloadUrl(jmapUrl: dynamicUrlInterceptors.jmapUrl) ?? '';
        TransformConfiguration transformConfiguration = PlatformInfo.isWeb
          ? TransformConfiguration.forPreviewEmailOnWeb()
          : TransformConfiguration.forPreviewEmail();
@@ -570,7 +564,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
          break;
        case PermissionStatus.permanentlyDenied:
          if (context.mounted && currentOverlayContext != null && currentContext != null) {
-            _appToast.showToastMessage(
+            appToast.showToastMessage(
              currentOverlayContext!,
              AppLocalizations.of(context).you_need_to_grant_files_permission_to_download_attachments,
            );
@@ -584,7 +578,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
              break;
            default:
              if (context.mounted && currentOverlayContext != null && currentContext != null) {
-                _appToast.showToastMessage(
+                appToast.showToastMessage(
                  currentOverlayContext!,
                  AppLocalizations.of(context).you_need_to_grant_files_permission_to_download_attachments,
                );
@@ -601,14 +595,14 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
  void _downloadAttachmentsAction(List<Attachment> attachments) async {
    final accountId = mailboxDashBoardController.accountId.value;
    if (accountId != null && mailboxDashBoardController.sessionCurrent != null) {
-      final baseDownloadUrl = mailboxDashBoardController.sessionCurrent!.getDownloadUrl(jmapUrl: _dynamicUrlInterceptors.jmapUrl);
+      final baseDownloadUrl = mailboxDashBoardController.sessionCurrent!.getDownloadUrl(jmapUrl: dynamicUrlInterceptors.jmapUrl);
      consumeState(_downloadAttachmentsInteractor.execute(attachments, accountId, baseDownloadUrl));
    }
  }

  void _downloadAttachmentsFailure(DownloadAttachmentsFailure failure) {
    if (currentOverlayContext != null && currentContext != null) {
-      _appToast.showToastErrorMessage(
+      appToast.showToastErrorMessage(
        currentOverlayContext!,
        AppLocalizations.of(currentContext!).attachment_download_failed);
    }
@@ -650,7 +644,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
  void _exportAttachmentAction(Attachment attachment, CancelToken cancelToken) async {
    final accountId = mailboxDashBoardController.accountId.value;
    if (accountId != null && mailboxDashBoardController.sessionCurrent != null) {
-      final baseDownloadUrl = mailboxDashBoardController.sessionCurrent!.getDownloadUrl(jmapUrl: _dynamicUrlInterceptors.jmapUrl);
+      final baseDownloadUrl = mailboxDashBoardController.sessionCurrent!.getDownloadUrl(jmapUrl: dynamicUrlInterceptors.jmapUrl);
      consumeState(_exportAttachmentInteractor.execute(attachment, accountId, baseDownloadUrl, cancelToken));
    }
  }
@@ -660,7 +654,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
      popBack();

      if (currentOverlayContext != null && currentContext != null) {
-        _appToast.showToastErrorMessage(
+        appToast.showToastErrorMessage(
          currentOverlayContext!,
          AppLocalizations.of(currentContext!).attachment_download_failed);
      }
@@ -686,7 +680,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
    if (openResult.type != open_file.ResultType.done) {
      logError('SingleEmailController::_openDownloadedPreviewWorkGroupDocument(): no preview available');
      if (currentOverlayContext != null && currentContext != null) {
-        _appToast.showToastErrorMessage(
+        appToast.showToastErrorMessage(
          currentOverlayContext!,
          AppLocalizations.of(currentContext!).noPreviewAvailable);
      }
@@ -701,8 +695,8 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
    final accountId = mailboxDashBoardController.accountId.value;
    final session = mailboxDashBoardController.sessionCurrent;
    if (accountId != null && session != null) {
-      final baseDownloadUrl = session.getDownloadUrl(jmapUrl: _dynamicUrlInterceptors.jmapUrl);
-      final generateTaskId = DownloadTaskId(_uuid.v4());
+      final baseDownloadUrl = session.getDownloadUrl(jmapUrl: dynamicUrlInterceptors.jmapUrl);
+      final generateTaskId = DownloadTaskId(uuid.v4());
      consumeState(_downloadAttachmentForWebInteractor.execute(
          generateTaskId,
          attachment,
@@ -732,7 +726,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
    }

    if (currentOverlayContext != null && currentContext != null) {
-      _appToast.showToastErrorMessage(
+      appToast.showToastErrorMessage(
        currentOverlayContext!,
        AppLocalizations.of(currentContext!).attachment_download_failed);
    }
@@ -821,7 +815,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
  void _moveToMailboxSuccess(MoveToMailboxSuccess success) {
    mailboxDashBoardController.dispatchState(Right(success));
    if (success.moveAction == MoveAction.moving && currentContext != null && currentOverlayContext != null) {
-      _appToast.showToastMessage(
+      appToast.showToastMessage(
        currentOverlayContext!,
        success.emailActionType.getToastMessageMoveToMailboxSuccess(currentContext!, destinationPath: success.destinationPath),
        actionName: AppLocalizations.of(currentContext!).undo,
@@ -1063,21 +1057,21 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
    }

    if (_sendReceiptToSenderInteractor == null) {
-      _appToast.showToastErrorMessage(
+      appToast.showToastErrorMessage(
        currentOverlayContext!,
        AppLocalizations.of(context).toastMessageNotSupportMdnWhenSendReceipt);
      return;
    }

    if (_identitySelected == null || _identitySelected?.id == null) {
-      _appToast.showToastErrorMessage(
+      appToast.showToastErrorMessage(
        currentOverlayContext!,
        AppLocalizations.of(context).toastMessageCannotFoundIdentityWhenSendReceipt);
      return;
    }

    if (currentEmail == null || _currentEmailId == null) {
-      _appToast.showToastErrorMessage(
+      appToast.showToastErrorMessage(
        currentOverlayContext!,
        AppLocalizations.of(context).toastMessageCannotFoundEmailIdWhenSendReceipt);
      return;
@@ -1089,7 +1083,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
    final sendReceiptRequest = SendReceiptToSenderRequest(
        mdn: mdnToSender,
        identityId: _identitySelected!.id!,
-        sendId: Id(_uuid.v1()));
+        sendId: Id(uuid.v1()));
    log('SingleEmailController::_handleSendReceiptToSenderAction(): sendReceiptRequest: $sendReceiptRequest');

    consumeState(_sendReceiptToSenderInteractor!.execute(accountId, sendReceiptRequest));
@@ -1129,7 +1123,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
  void _sendReceiptToSenderSuccess(SendReceiptToSenderSuccess success) {
    log('SingleEmailController::_sendReceiptToSenderSuccess(): ${success.mdn.toString()}');
    if (currentContext != null) {
-      _appToast.showToastSuccessMessage(
+      appToast.showToastSuccessMessage(
        currentOverlayContext!,
        AppLocalizations.of(currentContext!).toastMessageSendReceiptSuccess,
        leadingSVGIcon: imagePaths.icReadReceiptMessage);
@@ -1264,7 +1258,7 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
  void _createNewRuleFilterSuccess(CreateNewRuleFilterSuccess success) {
    if (success.newListRules.isNotEmpty == true) {
      if (currentOverlayContext != null && currentContext != null) {
-        _appToast.showToastSuccessMessage(
+        appToast.showToastSuccessMessage(
          currentOverlayContext!,
          AppLocalizations.of(currentContext!).newFilterWasCreated);
      }
@@ -1,11 +1,8 @@
 import 'package:core/presentation/extensions/color_extension.dart';
-import 'package:core/presentation/resources/image_paths.dart';
-import 'package:core/presentation/utils/responsive_utils.dart';
 import 'package:core/presentation/views/button/tmail_button_widget.dart';
 import 'package:core/presentation/views/html_viewer/html_content_viewer_on_web_widget.dart';
 import 'package:core/presentation/views/html_viewer/html_content_viewer_widget.dart';
 import 'package:core/presentation/views/html_viewer/html_viewer_controller_for_web.dart';
-import 'package:core/utils/app_logger.dart';
 import 'package:core/utils/direction_utils.dart';
 import 'package:core/utils/platform_info.dart';
 import 'package:flutter/material.dart';
@@ -42,17 +39,14 @@ import 'package:tmail_ui_user/main/utils/app_utils.dart';

 class EmailView extends GetWidget<SingleEmailController> {

-  final responsiveUtils = Get.find<ResponsiveUtils>();
-  final imagePaths = Get.find<ImagePaths>();
-
-  EmailView({Key? key}) : super(key: key);
+  const EmailView({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return WillPopScope(
      onWillPop: () => controller.backButtonPressedCallbackAction.call(context),
      child: Scaffold(
-        backgroundColor: responsiveUtils.isWebDesktop(context)
+        backgroundColor: controller.responsiveUtils.isWebDesktop(context)
          ? AppColor.colorBgDesktop
          : Colors.white,
        appBar: PlatformInfo.isIOS
@@ -93,12 +87,12 @@ class EmailView extends GetWidget<SingleEmailController> {
            )
          : null,
        body: SafeArea(
-          right: responsiveUtils.isLandscapeMobile(context),
-          left: responsiveUtils.isLandscapeMobile(context),
+          right: controller.responsiveUtils.isLandscapeMobile(context),
+          left: controller.responsiveUtils.isLandscapeMobile(context),
          bottom: !PlatformInfo.isIOS,
          child: Container(
            clipBehavior: Clip.antiAlias,
-            decoration: responsiveUtils.isWebDesktop(context)
+            decoration: controller.responsiveUtils.isWebDesktop(context)
              ? BoxDecoration(
                  borderRadius: BorderRadius.circular(20),
                  border: Border.all(color: AppColor.colorBorderBodyThread, width: 1),
@@ -139,9 +133,9 @@ class EmailView extends GetWidget<SingleEmailController> {
                    final vacation = controller.mailboxDashBoardController.vacationResponse.value;
                    if (vacation?.vacationResponderIsValid == true &&
                        (
-                          responsiveUtils.isMobile(context) ||
-                          responsiveUtils.isTablet(context) ||
-                          responsiveUtils.isLandscapeMobile(context)
+                          controller.responsiveUtils.isMobile(context) ||
+                          controller.responsiveUtils.isTablet(context) ||
+                          controller.responsiveUtils.isLandscapeMobile(context)
                        )
                    ) {
                      return VacationNotificationMessageWidget(
@@ -270,7 +264,7 @@ class EmailView extends GetWidget<SingleEmailController> {

  EdgeInsetsGeometry _getMarginEmailView(BuildContext context) {
    if (PlatformInfo.isWeb) {
-      if (responsiveUtils.isDesktop(context)) {
+      if (controller.responsiveUtils.isDesktop(context)) {
        return const EdgeInsetsDirectional.only(
          end: 16,
          top: 8,
@@ -292,8 +286,8 @@ class EmailView extends GetWidget<SingleEmailController> {
    return [
      TMailButtonWidget.fromIcon(
        icon: DirectionUtils.isDirectionRTLByLanguage(context)
-          ? imagePaths.icOlder
-          : imagePaths.icNewer,
+          ? controller.imagePaths.icOlder
+          : controller.imagePaths.icNewer,
        iconColor: controller.emailSupervisorController.nextEmailActivated
          ? AppColor.primaryColor
          : AppColor.colorAttachmentIcon,
@@ -305,8 +299,8 @@ class EmailView extends GetWidget<SingleEmailController> {
      ),
      TMailButtonWidget.fromIcon(
        icon: DirectionUtils.isDirectionRTLByLanguage(context)
-          ? imagePaths.icNewer
-          : imagePaths.icOlder,
+          ? controller.imagePaths.icNewer
+          : controller.imagePaths.icOlder,
        iconColor: controller.emailSupervisorController.previousEmailActivated
          ? AppColor.primaryColor
          : AppColor.colorAttachmentIcon,
@@ -332,22 +326,18 @@ class EmailView extends GetWidget<SingleEmailController> {
        InformationSenderAndReceiverBuilder(
          controller: controller,
          emailSelected: presentationEmail,
-          imagePaths: imagePaths,
-          responsiveUtils: responsiveUtils,
+          imagePaths: controller.imagePaths,
+          responsiveUtils: controller.responsiveUtils,
        ),
        Obx(() {
          final attachments = controller.attachments.listAttachmentsDisplayedOutSide;
          if (attachments.isNotEmpty) {
            return EmailAttachmentsWidget(
-              responsiveUtils: responsiveUtils,
+              responsiveUtils: controller.responsiveUtils,
              attachments: attachments,
-              imagePaths: imagePaths,
-              onDragStarted: () {
-                log('EmailView::_buildEmailMessage:onDragStarted:');
-                controller.mailboxDashBoardController.enableDraggableApp();
-              },
+              imagePaths: controller.imagePaths,
+              onDragStarted: controller.mailboxDashBoardController.enableDraggableApp,
              onDragEnd: (details) {
-                log('EmailView::_buildEmailMessage:onDragEnd:');
                controller.mailboxDashBoardController.disableDraggableApp();
              },
              downloadAttachmentAction: (attachment) {
@@ -463,7 +453,7 @@ class EmailView extends GetWidget<SingleEmailController> {
    return (EmailActionCupertinoActionSheetActionBuilder(
          const Key('mark_as_unread_action'),
          SvgPicture.asset(
-            imagePaths.icUnreadEmail,
+            controller.imagePaths.icUnreadEmail,
            width: 24,
            height: 24,
            fit: BoxFit.fill,
@@ -471,7 +461,7 @@ class EmailView extends GetWidget<SingleEmailController> {
          ),
          AppLocalizations.of(context).mark_as_unread,
          email,
-          iconLeftPadding: responsiveUtils.isMobile(context)
+          iconLeftPadding: controller.responsiveUtils.isMobile(context)
            ? EdgeInsets.only(
                left: AppUtils.isDirectionRTL(context) ? 16 : 12,
                right: AppUtils.isDirectionRTL(context) ? 12 : 16,
@@ -480,7 +470,7 @@ class EmailView extends GetWidget<SingleEmailController> {
                left: AppUtils.isDirectionRTL(context) ? 12 : 0,
                right: AppUtils.isDirectionRTL(context) ? 0 : 12,
              ),
-          iconRightPadding: responsiveUtils.isMobile(context)
+          iconRightPadding: controller.responsiveUtils.isMobile(context)
            ? EdgeInsets.only(
                left: AppUtils.isDirectionRTL(context) ? 12 : 0,
                right: AppUtils.isDirectionRTL(context) ? 0 : 12,
@@ -500,7 +490,7 @@ class EmailView extends GetWidget<SingleEmailController> {
    return (EmailActionCupertinoActionSheetActionBuilder(
          const Key('mark_as_spam_or_un_spam_action'),
          SvgPicture.asset(
-            currentMailbox?.isSpam == true ? imagePaths.icNotSpam : imagePaths.icSpam,
+            currentMailbox?.isSpam == true ? controller.imagePaths.icNotSpam : controller.imagePaths.icSpam,
            width: 24,
            height: 24,
            fit: BoxFit.fill,
@@ -510,7 +500,7 @@ class EmailView extends GetWidget<SingleEmailController> {
            ? AppLocalizations.of(context).remove_from_spam
            : AppLocalizations.of(context).mark_as_spam,
          email,
-          iconLeftPadding: responsiveUtils.isMobile(context)
+          iconLeftPadding: controller.responsiveUtils.isMobile(context)
            ? EdgeInsets.only(
                left: AppUtils.isDirectionRTL(context) ? 16 : 12,
                right: AppUtils.isDirectionRTL(context) ? 12 : 16,
@@ -519,7 +509,7 @@ class EmailView extends GetWidget<SingleEmailController> {
                left: AppUtils.isDirectionRTL(context) ? 12 : 0,
                right: AppUtils.isDirectionRTL(context) ? 0 : 12,
              ),
-          iconRightPadding: responsiveUtils.isMobile(context)
+          iconRightPadding: controller.responsiveUtils.isMobile(context)
            ? EdgeInsets.only(
                left: AppUtils.isDirectionRTL(context) ? 12 : 0,
                right: AppUtils.isDirectionRTL(context) ? 0 : 12,
@@ -537,14 +527,14 @@ class EmailView extends GetWidget<SingleEmailController> {
    return (EmailActionCupertinoActionSheetActionBuilder(
          const Key('quick_creating_rule_action'),
          SvgPicture.asset(
-            imagePaths.icQuickCreatingRule,
+            controller.imagePaths.icQuickCreatingRule,
            width: 24,
            height: 24,
            fit: BoxFit.fill,
            colorFilter: AppColor.colorTextButton.asFilter()),
          AppLocalizations.of(context).quickCreatingRule,
          email,
-          iconLeftPadding: responsiveUtils.isMobile(context)
+          iconLeftPadding: controller.responsiveUtils.isMobile(context)
            ? EdgeInsets.only(
                left: AppUtils.isDirectionRTL(context) ? 16 : 12,
                right: AppUtils.isDirectionRTL(context) ? 12 : 16,
@@ -553,7 +543,7 @@ class EmailView extends GetWidget<SingleEmailController> {
                left: AppUtils.isDirectionRTL(context) ? 12 : 0,
                right: AppUtils.isDirectionRTL(context) ? 0 : 12,
              ),
-          iconRightPadding: responsiveUtils.isMobile(context)
+          iconRightPadding: controller.responsiveUtils.isMobile(context)
            ? EdgeInsets.only(
                left: AppUtils.isDirectionRTL(context) ? 12 : 0,
                right: AppUtils.isDirectionRTL(context) ? 0 : 12,
@@ -577,7 +567,7 @@ class EmailView extends GetWidget<SingleEmailController> {
    return PopupMenuItem(
      padding: EdgeInsets.zero,
      child: PopupItemWidget(
-        imagePaths.icUnreadEmail,
+        controller.imagePaths.icUnreadEmail,
        AppLocalizations.of(context).mark_as_unread,
        colorIcon: AppColor.colorTextButton,
        padding: const EdgeInsetsDirectional.only(start: 12),
@@ -603,7 +593,7 @@ class EmailView extends GetWidget<SingleEmailController> {
    return PopupMenuItem(
      padding: EdgeInsets.zero,
      child: PopupItemWidget(
-        mailboxContain?.isSpam == true ? imagePaths.icNotSpam : imagePaths.icSpam,
+        mailboxContain?.isSpam == true ? controller.imagePaths.icNotSpam : controller.imagePaths.icSpam,
        mailboxContain?.isSpam == true
          ? AppLocalizations.of(context).remove_from_spam
          : AppLocalizations.of(context).mark_as_spam,
@@ -627,7 +617,7 @@ class EmailView extends GetWidget<SingleEmailController> {
    return PopupMenuItem(
      padding: EdgeInsets.zero,
      child: PopupItemWidget(
-        imagePaths.icQuickCreatingRule,
+        controller.imagePaths.icQuickCreatingRule,
        AppLocalizations.of(context).quickCreatingRule,
        colorIcon: AppColor.colorTextButton,
        padding: const EdgeInsetsDirectional.only(start: 12),