TF-2311 Sync use variables in BaseController to avoid wasting memory

Signed-off-by: dab246 <tdvu@linagora.com>

Signed-off-by: dab246 <tdvu@linagora.com>
(cherry picked from commit 21ac80615f7bc9e832fd72cb8ae6875c967d3cea)

lib/features/manage_account/presentation/menu/settings/settings_controller.dart

@@ -1,3 +1,5 @@
+import 'package:core/presentation/resources/image_paths.dart';
+import 'package:core/presentation/utils/responsive_utils.dart';
 import 'package:core/utils/app_logger.dart';
 import 'package:get/get.dart';
 import 'package:tmail_ui_user/features/manage_account/presentation/manage_account_dashboard_controller.dart';
@@ -6,6 +8,8 @@ import 'package:tmail_ui_user/features/manage_account/presentation/model/setting
 
 class SettingsController extends GetxController {
   final manageAccountDashboardController = Get.find<ManageAccountDashBoardController>();
+  final responsiveUtils = Get.find<ResponsiveUtils>();
+  final imagePaths = Get.find<ImagePaths>();
 
   void selectSettings(AccountMenuItem accountMenuItem) {
     log('SettingsController::selectSettings(): $accountMenuItem');

lib/features/manage_account/presentation/menu/settings/settings_first_level_view.dart

@@ -1,6 +1,4 @@
 import 'package:core/presentation/extensions/color_extension.dart';
-import 'package:core/presentation/resources/image_paths.dart';
-import 'package:core/presentation/utils/responsive_utils.dart';
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
 import 'package:tmail_ui_user/features/mailbox/presentation/widgets/user_information_widget.dart';
@@ -11,10 +9,7 @@ import 'package:tmail_ui_user/features/manage_account/presentation/model/account
 import 'package:tmail_ui_user/main/localizations/app_localizations.dart';
 
 class SettingsFirstLevelView extends GetWidget<SettingsController> {
-  SettingsFirstLevelView({Key? key}) : super(key: key);
-
-  final _responsiveUtils = Get.find<ResponsiveUtils>();
-  final _imagePaths = Get.find<ImagePaths>();
+  const SettingsFirstLevelView({Key? key}) : super(key: key);
 
   @override
   Widget build(BuildContext context) {
@@ -22,40 +17,40 @@ class SettingsFirstLevelView extends GetWidget<SettingsController> {
       child: Column(children: [
         Obx(() => UserInformationWidget(
           userProfile: controller.manageAccountDashboardController.userProfile.value,
-          padding: SettingsUtils.getPaddingInFirstLevel(context, _responsiveUtils),
+          padding: SettingsUtils.getPaddingInFirstLevel(context, controller.responsiveUtils),
           titlePadding: const EdgeInsetsDirectional.only(start: 16))),
         Divider(
           color: AppColor.colorDividerComposer,
           height: 1,
-          indent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils),
-          endIndent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils)
+          indent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils),
+          endIndent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils)
         ),
         SettingFirstLevelTileBuilder(
           AppLocalizations.of(context).profiles,
-          AccountMenuItem.profiles.getIcon(_imagePaths),
+          AccountMenuItem.profiles.getIcon(controller.imagePaths),
           subtitle: AppLocalizations.of(context).profilesSettingExplanation,
           () => controller.selectSettings(AccountMenuItem.profiles)
         ),
         Divider(
           color: AppColor.colorDividerComposer,
           height: 1,
-          indent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils),
-          endIndent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils)
+          indent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils),
+          endIndent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils)
         ),
         Obx(() {
           if (controller.manageAccountDashboardController.isRuleFilterCapabilitySupported) {
             return Column(children: [
               SettingFirstLevelTileBuilder(
                 AccountMenuItem.emailRules.getName(context),
-                AccountMenuItem.emailRules.getIcon(_imagePaths),
+                AccountMenuItem.emailRules.getIcon(controller.imagePaths),
                 subtitle: AppLocalizations.of(context).emailRuleSettingExplanation,
                 () => controller.selectSettings(AccountMenuItem.emailRules)
               ),
               Divider(
                 color: AppColor.colorDividerComposer,
                 height: 1,
-                indent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils),
-                endIndent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils)
+                indent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils),
+                endIndent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils)
               ),
             ]);
           } else {
@@ -67,15 +62,15 @@ class SettingsFirstLevelView extends GetWidget<SettingsController> {
             return Column(children: [
               SettingFirstLevelTileBuilder(
                 AccountMenuItem.forward.getName(context),
-                AccountMenuItem.forward.getIcon(_imagePaths),
+                AccountMenuItem.forward.getIcon(controller.imagePaths),
                 subtitle: AppLocalizations.of(context).forwardingSettingExplanation,
                 () => controller.selectSettings(AccountMenuItem.forward)
               ),
               Divider(
                 color: AppColor.colorDividerComposer,
                 height: 1,
-                indent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils),
-                endIndent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils)
+                indent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils),
+                endIndent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils)
               ),
             ]);
           } else {
@@ -87,15 +82,15 @@ class SettingsFirstLevelView extends GetWidget<SettingsController> {
             return Column(children: [
               SettingFirstLevelTileBuilder(
                 AccountMenuItem.vacation.getName(context),
-                AccountMenuItem.vacation.getIcon(_imagePaths),
+                AccountMenuItem.vacation.getIcon(controller.imagePaths),
                 subtitle: AppLocalizations.of(context).vacationSettingExplanation,
                 () => controller.selectSettings(AccountMenuItem.vacation)
               ),
               Divider(
                 color: AppColor.colorDividerComposer,
                 height: 1,
-                indent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils),
-                endIndent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils)
+                indent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils),
+                endIndent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils)
               ),
             ]);
           } else {
@@ -105,31 +100,31 @@ class SettingsFirstLevelView extends GetWidget<SettingsController> {
         Column(children: [
           SettingFirstLevelTileBuilder(
             AccountMenuItem.mailboxVisibility.getName(context),
-            AccountMenuItem.mailboxVisibility.getIcon(_imagePaths),
+            AccountMenuItem.mailboxVisibility.getIcon(controller.imagePaths),
             subtitle: AppLocalizations.of(context).folderVisibilitySubtitle,
             () => controller.selectSettings(AccountMenuItem.mailboxVisibility)
           ),
           Divider(
             color: AppColor.colorDividerComposer,
             height: 1,
-            indent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils),
-            endIndent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils)
+            indent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils),
+            endIndent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils)
           ),
         ]),
         SettingFirstLevelTileBuilder(
           AccountMenuItem.languageAndRegion.getName(context),
-          AccountMenuItem.languageAndRegion.getIcon(_imagePaths),
+          AccountMenuItem.languageAndRegion.getIcon(controller.imagePaths),
           () => controller.selectSettings(AccountMenuItem.languageAndRegion)
         ),
         Divider(
           color: AppColor.colorDividerComposer,
           height: 1,
-          indent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils),
-          endIndent: SettingsUtils.getHorizontalPadding(context, _responsiveUtils)
+          indent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils),
+          endIndent: SettingsUtils.getHorizontalPadding(context, controller.responsiveUtils)
         ),
         SettingFirstLevelTileBuilder(
           AppLocalizations.of(context).sign_out,
-          _imagePaths.icSignOut,
+          controller.imagePaths.icSignOut,
           () => controller.manageAccountDashboardController.logout(
               controller.manageAccountDashboardController.sessionCurrent,
               controller.manageAccountDashboardController.accountId.value)

lib/features/manage_account/presentation/menu/settings/settings_view.dart

@@ -1,6 +1,4 @@
 import 'package:core/presentation/extensions/color_extension.dart';
-import 'package:core/presentation/resources/image_paths.dart';
-import 'package:core/presentation/utils/responsive_utils.dart';
 import 'package:core/presentation/utils/style_utils.dart';
 import 'package:core/presentation/views/button/icon_button_web.dart';
 import 'package:core/utils/direction_utils.dart';
@@ -27,10 +25,8 @@ import 'package:tmail_ui_user/main/utils/app_utils.dart';
 typedef CloseSettingsViewAction = void Function();
 
 class SettingsView extends GetWidget<SettingsController> {
-  SettingsView({Key? key, this.closeAction}) : super(key: key);
+  const SettingsView({Key? key, this.closeAction}) : super(key: key);
 
-  final _responsiveUtils = Get.find<ResponsiveUtils>();
-  final _imagePaths = Get.find<ImagePaths>();
   final CloseSettingsViewAction? closeAction;
 
   @override
@@ -44,7 +40,7 @@ class SettingsView extends GetWidget<SettingsController> {
             SizedBox.fromSize(
               size: const Size.fromHeight(52),
               child: Padding(
-                padding: SettingsUtils.getPaddingAppBar(context, _responsiveUtils),
+                padding: SettingsUtils.getPaddingAppBar(context, controller.responsiveUtils),
                 child: _buildAppbar(context))),
             const Divider(color: AppColor.colorDividerComposer, height: 1),
             Obx(() {
@@ -138,8 +134,8 @@ class SettingsView extends GetWidget<SettingsController> {
               child: Row(mainAxisSize: MainAxisSize.min, children: [
                 SvgPicture.asset(
                   DirectionUtils.isDirectionRTLByLanguage(context)
-                    ? _imagePaths.icCollapseFolder
-                    : _imagePaths.icBack,
+                    ? controller.imagePaths.icCollapseFolder
+                    : controller.imagePaths.icBack,
                   colorFilter: AppColor.colorTextButton.asFilter(),
                   fit: BoxFit.fill),
                 Container(
@@ -179,7 +175,7 @@ class SettingsView extends GetWidget<SettingsController> {
 
   Widget _buildCloseSettingButton(BuildContext context) {
     return buildIconWeb(
-      icon: SvgPicture.asset(_imagePaths.icClose, width: 28, height: 28, fit: BoxFit.fill),
+      icon: SvgPicture.asset(controller.imagePaths.icClose, width: 28, height: 28, fit: BoxFit.fill),
       tooltip: AppLocalizations.of(context).close,
       onTap: closeAction);
   }
@@ -188,7 +184,7 @@ class SettingsView extends GetWidget<SettingsController> {
     return Obx(() {
       switch (controller.manageAccountDashboardController.settingsPageLevel.value) {
         case SettingsPageLevel.universal:
-          return SettingsFirstLevelView();
+          return const SettingsFirstLevelView();
         case SettingsPageLevel.level1:
           return _viewDisplayedOfAccountMenuItem();
       }
@@ -201,7 +197,7 @@ class SettingsView extends GetWidget<SettingsController> {
         case AccountMenuItem.profiles:
           return ProfilesView();
         case AccountMenuItem.languageAndRegion:
-          return LanguageAndRegionView();
+          return const LanguageAndRegionView();
         case AccountMenuItem.emailRules:
           if (controller.manageAccountDashboardController.isRuleFilterCapabilitySupported) {
             return EmailRulesView();