TF-4136 Apply early exit to prevent string operation in log
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
import 'package:core/presentation/extensions/color_extension.dart';
|
||||
import 'package:core/utils/application_manager.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:get/get.dart';
|
||||
|
||||
class ApplicationVersionWidget extends StatefulWidget {
|
||||
|
||||
@@ -22,13 +21,12 @@ class ApplicationVersionWidget extends StatefulWidget {
|
||||
|
||||
class _ApplicationVersionWidgetState extends State<ApplicationVersionWidget> {
|
||||
|
||||
final ApplicationManager _applicationManager = Get.find<ApplicationManager>();
|
||||
Future<String>? _versionStream;
|
||||
|
||||
@override
|
||||
void initState() {
|
||||
super.initState();
|
||||
_versionStream = _applicationManager.getVersion();
|
||||
_versionStream = ApplicationManager().getAppVersion();
|
||||
}
|
||||
|
||||
@override
|
||||
|
||||
@@ -24,14 +24,12 @@ class ComposerRepositoryImpl extends ComposerRepository {
|
||||
final AttachmentUploadDataSource _attachmentUploadDataSource;
|
||||
final ComposerDataSource _composerDataSource;
|
||||
final HtmlDataSource _htmlDataSource;
|
||||
final ApplicationManager _applicationManager;
|
||||
final Uuid _uuid;
|
||||
|
||||
ComposerRepositoryImpl(
|
||||
this._attachmentUploadDataSource,
|
||||
this._composerDataSource,
|
||||
this._htmlDataSource,
|
||||
this._applicationManager,
|
||||
this._uuid,
|
||||
);
|
||||
|
||||
@@ -74,7 +72,7 @@ class ComposerRepositoryImpl extends ComposerRepository {
|
||||
|
||||
emailContent = HtmlUtils.wrapPlainTextLinks(emailContent);
|
||||
|
||||
final userAgent = await _applicationManager.generateApplicationUserAgent();
|
||||
final userAgent = await ApplicationManager().generateApplicationUserAgent();
|
||||
final emailBodyPartId = PartId(_uuid.v1());
|
||||
|
||||
final emailObject = createEmailRequest.generateEmail(
|
||||
|
||||
@@ -196,7 +196,6 @@ class ComposerBindings extends BaseBindings {
|
||||
Get.find<AttachmentUploadDataSource>(tag: composerId),
|
||||
Get.find<ComposerDataSource>(tag: composerId),
|
||||
Get.find<HtmlDataSource>(tag: composerId),
|
||||
Get.find<ApplicationManager>(),
|
||||
Get.find<Uuid>(),
|
||||
), tag: composerId);
|
||||
Get.lazyPut(
|
||||
|
||||
@@ -1,5 +1,4 @@
|
||||
import 'package:core/data/network/download/download_client.dart';
|
||||
import 'package:core/utils/application_manager.dart';
|
||||
import 'package:get/get.dart';
|
||||
import 'package:jmap_dart_client/http/http_client.dart';
|
||||
import 'package:tmail_ui_user/features/base/base_bindings.dart';
|
||||
@@ -11,12 +10,12 @@ import 'package:tmail_ui_user/features/composer/domain/usecases/upload_attachmen
|
||||
import 'package:tmail_ui_user/features/email/data/datasource/html_datasource.dart';
|
||||
import 'package:tmail_ui_user/features/email/data/datasource_impl/html_datasource_impl.dart';
|
||||
import 'package:tmail_ui_user/features/email/data/local/html_analyzer.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/domain/usecase/create_public_asset_interactor.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/data/datasource/public_asset_datasource.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/data/datasource_impl/remote_public_asset_datasource_impl.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/data/network/public_asset_api.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/data/repository/public_asset_repository_impl.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/domain/repository/public_asset_repository.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/domain/usecase/create_public_asset_interactor.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/domain/usecase/delete_public_assets_interactor.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/presentation/model/public_asset_arguments.dart';
|
||||
import 'package:tmail_ui_user/features/public_asset/presentation/public_asset_controller.dart';
|
||||
@@ -124,7 +123,6 @@ class PublicAssetBindings extends BaseBindings {
|
||||
Get.find<AttachmentUploadDataSource>(tag: BindingTag.publicAssetBindingsTag),
|
||||
Get.find<ComposerDataSource>(tag: BindingTag.publicAssetBindingsTag),
|
||||
Get.find<HtmlDataSource>(tag: BindingTag.publicAssetBindingsTag),
|
||||
Get.find<ApplicationManager>(),
|
||||
Get.find<Uuid>()),
|
||||
tag: BindingTag.publicAssetBindingsTag);
|
||||
Get.lazyPut(
|
||||
|
||||
Reference in New Issue
Block a user