Merge pull request #1351 from pateljannat/billing-flow-changes

fix: redirect to FC dashboard when login to FC
2025-03-03 14:59:21 +05:30
parent b510cbce7f 07d30647d8
commit 4224580d6f
9 changed files with 2567 additions and 3163 deletions
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -39,7 +39,7 @@ jobs:
        node-version: '18'
        check-latest: true
    - name: setup cache for bench
-      uses: actions/cache@v2
+      uses: actions/cache@v4
      with:
        path: ~/bench-cache
        key: ${{ runner.os }}
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -26,7 +26,7 @@
    "codemirror-editor-vue3": "^2.8.0",
    "dayjs": "^1.11.6",
    "feather-icons": "^4.28.0",
-    "frappe-ui": "^0.1.109",
+    "frappe-ui": "^0.1.112",
    "lucide-vue-next": "^0.383.0",
    "markdown-it": "^14.0.0",
    "pinia": "^2.0.33",
--- a/frontend/src/components/AppSidebar.vue
+++ b/frontend/src/components/AppSidebar.vue
@@ -65,8 +65,7 @@
 		<div>
 			<TrialBanner
 				v-if="
-					userResource.data?.user_type == 'System User' &&
-					userResource.data?.is_fc_site
+					userResource.data?.is_system_manager && userResource.data?.is_fc_site
 				"
 				:isSidebarCollapsed="sidebarStore.isSidebarCollapsed"
 			/>
--- a/frontend/src/components/Icons/FrappeCloudIcon.vue
+++ b/frontend/src/components/Icons/FrappeCloudIcon.vue
@@ -0,0 +1,23 @@
+<template>
+	<svg
+		width="32"
+		height="32"
+		viewBox="0 0 32 32"
+		fill="none"
+		xmlns="http://www.w3.org/2000/svg"
+	>
+		<rect
+			x="0.75"
+			y="0.75"
+			width="30.5"
+			height="30.5"
+			rx="6.25"
+			stroke="currentColor"
+			stroke-width="1.5"
+		/>
+		<path
+			d="M24.5011 14.1124C23.3954 12.4873 21.532 11.5477 19.594 11.6747C18.7616 10.1384 17.2211 9.12267 15.4198 9.0084C14.1651 8.93222 12.8979 9.3766 11.9165 10.24C11.2456 10.8367 10.7611 11.5223 10.463 12.2968C10.289 12.7539 9.89151 13.0459 9.46912 13.0459H6.5V15.5852H9.46912C10.9226 15.5852 12.2271 14.6584 12.7737 13.2237C12.9227 12.8301 13.1712 12.4873 13.5439 12.1571C14.0284 11.7255 14.662 11.4969 15.2583 11.535C16.1528 11.5985 16.7863 12.0175 17.1839 12.538C17.6063 13.0205 17.8423 13.7696 17.979 14.5187C18.774 14.2902 19.6437 14.0997 20.476 14.2394C21.1593 14.3536 21.7929 14.7218 22.2525 15.2678C22.327 15.3567 22.4016 15.4456 22.4637 15.5471C23.06 16.4232 23.1718 17.5024 22.7743 18.5689C22.414 19.5592 21.0847 20.4607 19.9791 20.4607H11.3326C10.1524 20.4607 9.18339 19.5592 9.03432 18.4038H6.54969C6.71119 20.9686 8.78585 23 11.3326 23H19.9915C22.1283 23 24.3769 21.451 25.1098 19.4704C25.7931 17.6167 25.5695 15.6614 24.5135 14.0997L24.5011 14.1124Z"
+			fill="currentColor"
+		/>
+	</svg>
+</template>
--- a/frontend/src/components/Modals/FCVerfiyCodeModal.vue
+++ b/frontend/src/components/Modals/FCVerfiyCodeModal.vue
@@ -1,94 +0,0 @@
-<template>
-	<Dialog
-		v-model="show"
-		:options="{
-			size: 'xl',
-			title: __('Login to Frappe Cloud'),
-			actions: [
-				{
-					label: __('Verify'),
-					variant: 'solid',
-					onClick: (close) => {
-						verifyCode(close)
-					},
-				},
-			],
-		}"
-	>
-		<template #body-content>
-			<div>
-				<p>
-					{{ __('We have sent the verificaton code to your email id ') }}
-					<b>{{ props.email }}</b>
-				</p>
-				<FormControl
-					v-model="code"
-					:label="__('Verification Code')"
-					class="mb-4"
-				/>
-				<p>
-					{{ __("Didn't receive the code?") }}
-					<a href="#" @click="resendCode">{{ __('Resend') }}</a>
-				</p>
-			</div>
-		</template>
-	</Dialog>
-</template>
-<script setup>
-import { call, Dialog } from 'frappe-ui'
-import { showToast } from '@/utils'
-
-const show = defineModel()
-const code = ref('')
-
-const props = defineProps({
-	email: {
-		type: String,
-		required: true,
-	},
-})
-
-const verifyCode = (close) => {
-	if (!code.value) {
-		return
-	}
-	call(
-		'frappe.integrations.frappe_providers.frappecloud_billing.verify_verification_code',
-		{
-			verification_code: code.value,
-			route: window.route,
-		}
-	)
-		.then((data) => {
-			if (data.message.login_token) {
-				close()
-				window.open(
-					`${frappeCloudBaseEndpoint}/api/method/press.api.developer.saas.login_to_fc?token=${data.message.login_token}`,
-					'_blank'
-				)
-				showToast(
-					__('Frappe Cloud Login Successful'),
-					`<p>${__('You will be redirected to Frappe Cloud soon.')}</p><p>${__(
-						"If you haven't been redirected,"
-					)} <a href="${frappeCloudBaseEndpoint}/api/method/press.api.developer.saas.login_to_fc?token=${
-						data.message.login_token
-					}" target="_blank">${__('Click here to login')}</a></p>`,
-					'check'
-				)
-			} else {
-				showToast(__('Login failed'), __('Please try again'), 'x')
-			}
-		})
-		.catch((err) => {
-			showToast(__('Login failed'), __('Please try again'), 'x')
-		})
-}
-
-const resendCode = () => {
-	call(
-		'frappe.integrations.frappe_providers.frappecloud_billing.send_verification_code'
-	).catch((err) => {
-		showToast(__('Failed to resend code'), __('Please try again'), 'x')
-	})
-}
-</script>
--- a/frontend/src/components/UserDropdown.vue
+++ b/frontend/src/components/UserDropdown.vue
@@ -59,22 +59,21 @@
 		v-if="userResource.data?.is_moderator"
 		v-model="showSettingsModal"
 	/>
-	<FCVerfiyCodeModal v-if="showFCLoginDialog" :email="verificationEmail" />
 </template>

 <script setup>
 import LMSLogo from '@/components/Icons/LMSLogo.vue'
 import { sessionStore } from '@/stores/session'
-import { call, Dropdown } from 'frappe-ui'
+import { Dropdown } from 'frappe-ui'
 import Apps from '@/components/Apps.vue'
 import { useRouter } from 'vue-router'
-import { convertToTitleCase, showToast } from '@/utils'
+import { convertToTitleCase } from '@/utils'
 import { usersStore } from '@/stores/user'
 import { useSettings } from '@/stores/settings'
 import { markRaw, watch, ref, onMounted, computed } from 'vue'
-import SettingsModal from '@/components/Modals/Settings.vue'
 import { createDialog } from '@/utils/dialogs'
-import FCVerfiyCodeModal from './Modals/FCVerfiyCodeModal.vue'
+import SettingsModal from '@/components/Modals/Settings.vue'
+import FrappeCloudIcon from '@/components/Icons/FrappeCloudIcon.vue'
 import {
 	ChevronDown,
 	LogIn,
@@ -83,7 +82,6 @@ import {
 	User,
 	Settings,
 	Sun,
-	LogInIcon,
 } from 'lucide-vue-next'

 const router = useRouter()
@@ -93,11 +91,8 @@ const settingsStore = useSettings()
 let { isLoggedIn } = sessionStore()
 const showSettingsModal = ref(false)
 const theme = ref('light')
-const $dialog = createDialog
 const frappeCloudBaseEndpoint = 'https://frappecloud.com'
-
-const showFCLoginDialog = ref(false)
-const verificationEmail = ref(null)
+const $dialog = createDialog

 const props = defineProps({
 	isCollapsed: {
@@ -166,15 +161,29 @@ const userDropdownOptions = computed(() => {
 			},
 		},
 		{
-			icon: LogInIcon,
+			icon: FrappeCloudIcon,
 			label: 'Login to Frappe Cloud',
 			onClick: () => {
-				initiateRequestForLoginToFrappeCloud()
+				$dialog({
+					title: __('Login to Frappe Cloud?'),
+					message: __(
+						'Are you sure you want to login to your Frappe Cloud dashboard?'
+					),
+					actions: [
+						{
+							label: __('Confirm'),
+							variant: 'solid',
+							onClick(close) {
+								loginToFrappeCloud()
+								close()
+							},
+						},
+					],
+				})
 			},
 			condition: () => {
 				return (
-					userResource.data?.user_type == 'System User' &&
-					userResource.data?.is_fc_site
+					userResource.data?.is_system_manager && userResource.data?.is_fc_site
 				)
 			},
 		},
@@ -203,47 +212,11 @@ const userDropdownOptions = computed(() => {
 	]
 })

-const initiateRequestForLoginToFrappeCloud = () => {
-	$dialog({
-		title: __('Login to Frappe Cloud?'),
-		message: __(
-			'Are you sure you want to login to your Frappe Cloud dashboard?'
-		),
-		actions: [
-			{
-				label: __('Confirm'),
-				variant: 'solid',
-				onClick(close) {
-					requestLoginToFC()
-					close()
-				},
-			},
-		],
-	})
-}
-
-const requestLoginToFC = () => {
-	call(
-		'frappe.integrations.frappe_providers.frappecloud_billing.send_verification_code'
-	)
-		.then((data) => {
-			if (data.message.is_user_logged_in) {
-				window.open(
-					`${frappeCloudBaseEndpoint}${data.message.redirect_to}`,
-					'_blank'
-				)
-				return
-			} else {
-				showFCLoginDialog.value = true
-				verificationEmail.value = data.message.email
-			}
-		})
-		.catch((err) => {
-			showToast(
-				__('Failed to login to Frappe Cloud'),
-				__('Please try again'),
-				'x'
-			)
-		})
+const loginToFrappeCloud = () => {
+	let redirect_to = '/dashboard/welcome'
+	if (userResource.data?.site_info.is_payment_method_added) {
+		redirect_to = '/dashboard/sites/' + userResource.data.sitename
+	}
+	window.open(`${frappeCloudBaseEndpoint}${redirect_to}`, '_blank')
 }
 </script>
--- a/frontend/yarn.lock
+++ b/frontend/yarn.lock
--- a/lms/lms/api.py
+++ b/lms/lms/api.py
@@ -23,7 +23,10 @@ from frappe.utils import (
 from lms.lms.utils import get_average_rating, get_lesson_count
 from xml.dom.minidom import parseString
 from lms.lms.doctype.course_lesson.course_lesson import save_progress
-from frappe.integrations.frappe_providers.frappecloud_billing import is_fc_site
+from frappe.integrations.frappe_providers.frappecloud_billing import (
+	is_fc_site,
+	current_site_info,
+)


@frappe.whitelist()
@@ -177,6 +180,10 @@ def get_user_info():
 	user.is_evaluator = "Batch Evaluator" in user.roles
 	user.is_student = "LMS Student" in user.roles
 	user.is_fc_site = is_fc_site()
+	user.is_system_manager = "System Manager" in user.roles
+	if user.is_fc_site and user.is_system_manager:
+		user.site_info = current_site_info()
+		user.sitename = frappe.local.site
 	return user


--- a/yarn.lock
+++ b/yarn.lock