Merge pull request #1529 from frappe/misc-fixes

frontend/src/App.vue

@@ -39,9 +39,9 @@ const Layout = computed(() => {
 	}
 	if (screenSize.width < 640) {
 		return MobileLayout
-	} else {
-		return DesktopLayout
 	}
+
+	return DesktopLayout
 })
 
 onMounted(async () => {

frontend/src/components/Modals/EvaluationModal.vue

@@ -66,7 +66,7 @@
 	</Dialog>
 </template>
 <script setup>
-import { Dialog, createResource, Select, FormControl } from 'frappe-ui'
+import { Dialog, createResource, Select, FormControl, toast } from 'frappe-ui'
 import { reactive, watch, inject } from 'vue'
 import { formatTime } from '@/utils/'
 
@@ -90,7 +90,7 @@ const props = defineProps({
 	},
 })
 
-let evaluation = reactive({
+const evaluation = reactive({
 	course: '',
 	date: '',
 	start_time: '',
@@ -139,7 +139,7 @@ function submitEvaluation(close) {
 			close()
 		},
 		onError(err) {
-			let message = err.messages?.[0] || err
+			const message = err.messages?.[0] || err
 			let unavailabilityMessage
 
 			if (typeof message === 'string') {
@@ -148,13 +148,13 @@ function submitEvaluation(close) {
 				unavailabilityMessage = false
 			}
 
-			toast.warning(__('Evaluator is unavailable'))
+			toast.warning(__(unavailabilityMessage || 'Evaluator is unavailable'))
 		},
 	})
 }
 
 const getCourses = () => {
-	let courses = []
+	const courses = []
 	for (const course of props.courses) {
 		if (course.evaluator) {
 			courses.push({
@@ -164,7 +164,7 @@ const getCourses = () => {
 		}
 	}
 
-	if (courses.length == 1) {
+	if (courses.length === 1) {
 		evaluation.course = courses[0].value
 	}