eduvia/workavia-drive
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

🧑‍💻 back: log diagnostic tool errors as last resort (#762)

Browse Source
This commit is contained in:
Eric Doughty-Papassideris
2024-12-08 22:53:39 +01:00
parent e6593986f1
commit 150dadeab5
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tdrive/backend/node/src/core/platform/framework/api/diagnostics.ts
+5 -3
View File
@@ -1,5 +1,6 @@
import assert from "node:assert"; import assert from "node:assert";
import config from "../../../config"; import config from "../../../config";
import { logger } from "../logger";
/** /**
* Values that can match a set of diagnostic providers. * Values that can match a set of diagnostic providers.
@@ -142,7 +143,7 @@ const runProvider = async provider => {
const startMs = now(); const startMs = now();
try { try {
const result = await provider.get(); const result = await provider.get();
if (!result.ok || result.warn) if (!result.ok)
logger.error( logger.error(
{ provider: provider.key, result }, { provider: provider.key, result },
"Got diagnostic provider result with ok=false", "Got diagnostic provider result with ok=false",
@@ -153,8 +154,9 @@ const runProvider = async provider => {
"Got diagnostic provider result with ok=true but a warning", "Got diagnostic provider result with ok=true but a warning",
); );
return recordDiagnostic(startMs, provider.key, result); return recordDiagnostic(startMs, provider.key, result);
} catch (error) { } catch (err) {
return recordDiagnostic(startMs, provider.key, undefined, error); logger.error({ err, provider: provider.key }, "Failed to read diagnostic provider");
return recordDiagnostic(startMs, provider.key, undefined, err);
} }
}; };