eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

HOTFIX Separate language from preference update (#4062)

Browse Source
This commit is contained in:
Dat Dang
2025-09-26 11:58:25 +07:00
committed by GitHub
parent eb73a0773c
commit 24095dc147
14 changed files with 65 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/features/server_settings/data/datasource_impl/remote_server_settings_data_source_impl_test.dart
+6 -3
View File
@@ -10,6 +10,7 @@ import 'package:tmail_ui_user/features/server_settings/data/network/server_setti
import 'package:tmail_ui_user/features/server_settings/domain/exceptions/server_settings_exception.dart';
import 'package:tmail_ui_user/main/exceptions/remote_exception_thrower.dart';
import '../../../../fixtures/session_fixtures.dart';
import 'remote_server_settings_data_source_impl_test.mocks.dart';
@GenerateNiceMocks([MockSpec<ServerSettingsAPI>()])
@@ -18,6 +19,7 @@ void main() {
id: ServerSettingsId(id: Id('123')),
settings: TMailServerSettingOptions(alwaysReadReceipts: true),
);
final session = SessionFixtures.aliceSession;
final accountId = AccountId(Id('321'));
final serverSettingsAPI = MockServerSettingsAPI();
final remoteServerSettingsDataSource = RemoteServerSettingsDataSourceImpl(
@@ -55,12 +57,12 @@ void main() {
group('update server settings', () {
test('should return value when ServerSettingsAPI returns value',() async {
// arrange
when(serverSettingsAPI.updateServerSettings(any, any))
when(serverSettingsAPI.updateServerSettings(any, any, any))
.thenAnswer((_) async => serverSettings);
// act
final result = await remoteServerSettingsDataSource
.updateServerSettings(accountId, serverSettings);
.updateServerSettings(session, accountId, serverSettings);
// assert
expect(result, serverSettings);
@@ -68,12 +70,13 @@ void main() {
test('should rethrow exception when ServerSettingsAPI throws exception',() async {
// arrange
when(serverSettingsAPI.updateServerSettings(any, any))
when(serverSettingsAPI.updateServerSettings(any, any, any))
.thenThrow(CanNotUpdateServerSettingsException());
// assert
expect(
() => remoteServerSettingsDataSource.updateServerSettings(
session,
accountId,
serverSettings),
throwsA(const TypeMatcher<CanNotUpdateServerSettingsException>()));
test/features/server_settings/data/network/server_settings_api_test.dart
+4
View File
@@ -9,6 +9,8 @@ import 'package:server_settings/server_settings/tmail_server_settings.dart';
import 'package:tmail_ui_user/features/server_settings/data/network/server_settings_api.dart';
import 'package:tmail_ui_user/features/server_settings/domain/exceptions/server_settings_exception.dart';
import '../../../../fixtures/session_fixtures.dart';
void main() {
final newServerSettings = TMailServerSettings(
id: ServerSettingsIdExtension.serverSettingsIdSingleton,
@@ -91,11 +93,13 @@ void main() {
final httpClient = HttpClient(dio);
final serverSettingsAPI = ServerSettingsAPI(httpClient);
final session = SessionFixtures.aliceSession;
final accountId = AccountId(Id('123'));
// assert
expect(
serverSettingsAPI.updateServerSettings(
session,
accountId,
newServerSettings),
throwsA(isA<CanNotUpdateServerSettingsException>()));
test/features/server_settings/data/repository/server_settings_repository_impl_test.dart
+6 -4
View File
@@ -8,11 +8,13 @@ import 'package:tmail_ui_user/features/server_settings/data/datasource/server_se
import 'package:tmail_ui_user/features/server_settings/data/repository/server_settings_repository_impl.dart';
import 'package:tmail_ui_user/features/server_settings/domain/exceptions/server_settings_exception.dart';
import '../../../../fixtures/session_fixtures.dart';
import 'server_settings_repository_impl_test.mocks.dart';
@GenerateNiceMocks([MockSpec<ServerSettingsDataSource>()])
void main() {
final serverSettings = TMailServerSettings();
final session = SessionFixtures.aliceSession;
final accountId = AccountId(Id('123'));
final serverSettingsDataSource = MockServerSettingsDataSource();
final serverSettingsRepository = ServerSettingsRepositoryImpl(
@@ -48,12 +50,12 @@ void main() {
group('update server settings', () {
test('should return value when ServerSettingsDataSource returns value', () async {
// arrange
when(serverSettingsDataSource.updateServerSettings(accountId, serverSettings))
when(serverSettingsDataSource.updateServerSettings(session, accountId, serverSettings))
.thenAnswer((_) async => serverSettings);
// act
final result = await serverSettingsRepository
.updateServerSettings(accountId, serverSettings);
.updateServerSettings(session, accountId, serverSettings);
// assert
expect(result, serverSettings);
@@ -61,12 +63,12 @@ void main() {
test('should rethrow exception when ServerSettingsDataSource throws exception', () async {
// arrange
when(serverSettingsDataSource.updateServerSettings(accountId, serverSettings))
when(serverSettingsDataSource.updateServerSettings(session, accountId, serverSettings))
.thenThrow(NotFoundServerSettingsException());
// assert
expect(
() => serverSettingsRepository.updateServerSettings(accountId, serverSettings),
() => serverSettingsRepository.updateServerSettings(session, accountId, serverSettings),
throwsA(const TypeMatcher<NotFoundServerSettingsException>()));
});
});