eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-4141 Fix nitpick comments from coderabbit

Browse Source
This commit is contained in:
dab246
2025-12-23 12:28:59 +07:00
committed by Dat H. Pham
parent 1661210e04
commit 2d1ecd4cc0
3 changed files with 20 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/mailbox/presentation/extensions/list_mailbox_node_extension.dart
+1 -1
View File
@@ -59,6 +59,6 @@ extension ListMailboxNodeExtension on List<MailboxNode> {
}
bool _equalsIgnoreCase(String? value, String expected) {
return value != null && value.toLowerCase() == expected;
return value != null && value.toLowerCase() == expected.toLowerCase();
}
}
lib/features/thread/presentation/thread_controller.dart
+1
View File
@@ -684,6 +684,7 @@ class ThreadController extends BaseController with EmailActionController {
{
EmailFilterCondition(
hasKeyword: KeyWordIdentifier.emailFlagged.value,
before: before,
),
EmailFilterCondition(
notKeyword: KeyWordIdentifier.emailSeen.value,
test/features/mailbox/presentation/extensions/list_mailbox_node_extension_test.dart
+18 -27
View File
@@ -6,18 +6,18 @@ import 'package:tmail_ui_user/features/mailbox/presentation/extensions/list_mail
import 'package:tmail_ui_user/features/mailbox/presentation/model/mailbox_node.dart';
void main() {
MailboxNode buildNode(String id, {String? name, String? role}) {
final mailbox = PresentationMailbox(
MailboxId(Id(id)),
name: name != null ? MailboxName(name) : null,
role: role != null ? Role(role) : null,
);
return MailboxNode(mailbox);
}
group('ListMailboxNodeExtension::insertAfterInbox', () {
late List<MailboxNode> nodes;
MailboxNode buildNode(String id, {String? name, String? role}) {
final mailbox = PresentationMailbox(
MailboxId(Id(id)),
name: name != null ? MailboxName(name) : null,
role: role != null ? Role(role) : null,
);
return MailboxNode(mailbox);
}
setUp(() {
nodes = [
buildNode('1', name: 'Sent'),
@@ -98,15 +98,6 @@ void main() {
group('ListMailboxNodeExtension::insertAfterStarredOrInbox', () {
late List<MailboxNode> nodes;
MailboxNode buildNode(String id, {String? name, String? role}) {
final mailbox = PresentationMailbox(
MailboxId(Id(id)),
name: name != null ? MailboxName(name) : null,
role: role != null ? Role(role) : null,
);
return MailboxNode(mailbox);
}
test('should insert after Starred when Starred exists (by role)', () {
nodes = [
buildNode('1', name: 'Inbox', role: 'inbox'),
@@ -177,20 +168,20 @@ void main() {
final ids = nodes.mailboxIds.map((id) => id.id.value).toList();
expect(ids, ['1', '2']);
});
test('should insert into empty list as first element', () {
nodes = [];
final newNode = buildNode('1', name: 'Starred', role: 'favorite');
nodes.insertAfterStarredOrInbox(newNode);
final ids = nodes.mailboxIds.map((id) => id.id.value).toList();
expect(ids, ['1']);
});
});
group('ListMailboxNodeExtension::insertAfterByPriority', () {
late List<MailboxNode> nodes;
MailboxNode buildNode(String id, {String? name, String? role}) {
final mailbox = PresentationMailbox(
MailboxId(Id(id)),
name: name != null ? MailboxName(name) : null,
role: role != null ? Role(role) : null,
);
return MailboxNode(mailbox);
}
bool isInbox(MailboxNode node) =>
node.item.role?.value == PresentationMailbox.inboxRole ||
node.item.name?.name.toLowerCase() == 'inbox';