TF-4141 Fix nitpick comments from coderabbit
This commit is contained in:
@@ -59,6 +59,6 @@ extension ListMailboxNodeExtension on List<MailboxNode> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool _equalsIgnoreCase(String? value, String expected) {
|
bool _equalsIgnoreCase(String? value, String expected) {
|
||||||
return value != null && value.toLowerCase() == expected;
|
return value != null && value.toLowerCase() == expected.toLowerCase();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -684,6 +684,7 @@ class ThreadController extends BaseController with EmailActionController {
|
|||||||
{
|
{
|
||||||
EmailFilterCondition(
|
EmailFilterCondition(
|
||||||
hasKeyword: KeyWordIdentifier.emailFlagged.value,
|
hasKeyword: KeyWordIdentifier.emailFlagged.value,
|
||||||
|
before: before,
|
||||||
),
|
),
|
||||||
EmailFilterCondition(
|
EmailFilterCondition(
|
||||||
notKeyword: KeyWordIdentifier.emailSeen.value,
|
notKeyword: KeyWordIdentifier.emailSeen.value,
|
||||||
|
|||||||
+18
-27
@@ -6,18 +6,18 @@ import 'package:tmail_ui_user/features/mailbox/presentation/extensions/list_mail
|
|||||||
import 'package:tmail_ui_user/features/mailbox/presentation/model/mailbox_node.dart';
|
import 'package:tmail_ui_user/features/mailbox/presentation/model/mailbox_node.dart';
|
||||||
|
|
||||||
void main() {
|
void main() {
|
||||||
|
MailboxNode buildNode(String id, {String? name, String? role}) {
|
||||||
|
final mailbox = PresentationMailbox(
|
||||||
|
MailboxId(Id(id)),
|
||||||
|
name: name != null ? MailboxName(name) : null,
|
||||||
|
role: role != null ? Role(role) : null,
|
||||||
|
);
|
||||||
|
return MailboxNode(mailbox);
|
||||||
|
}
|
||||||
|
|
||||||
group('ListMailboxNodeExtension::insertAfterInbox', () {
|
group('ListMailboxNodeExtension::insertAfterInbox', () {
|
||||||
late List<MailboxNode> nodes;
|
late List<MailboxNode> nodes;
|
||||||
|
|
||||||
MailboxNode buildNode(String id, {String? name, String? role}) {
|
|
||||||
final mailbox = PresentationMailbox(
|
|
||||||
MailboxId(Id(id)),
|
|
||||||
name: name != null ? MailboxName(name) : null,
|
|
||||||
role: role != null ? Role(role) : null,
|
|
||||||
);
|
|
||||||
return MailboxNode(mailbox);
|
|
||||||
}
|
|
||||||
|
|
||||||
setUp(() {
|
setUp(() {
|
||||||
nodes = [
|
nodes = [
|
||||||
buildNode('1', name: 'Sent'),
|
buildNode('1', name: 'Sent'),
|
||||||
@@ -98,15 +98,6 @@ void main() {
|
|||||||
group('ListMailboxNodeExtension::insertAfterStarredOrInbox', () {
|
group('ListMailboxNodeExtension::insertAfterStarredOrInbox', () {
|
||||||
late List<MailboxNode> nodes;
|
late List<MailboxNode> nodes;
|
||||||
|
|
||||||
MailboxNode buildNode(String id, {String? name, String? role}) {
|
|
||||||
final mailbox = PresentationMailbox(
|
|
||||||
MailboxId(Id(id)),
|
|
||||||
name: name != null ? MailboxName(name) : null,
|
|
||||||
role: role != null ? Role(role) : null,
|
|
||||||
);
|
|
||||||
return MailboxNode(mailbox);
|
|
||||||
}
|
|
||||||
|
|
||||||
test('should insert after Starred when Starred exists (by role)', () {
|
test('should insert after Starred when Starred exists (by role)', () {
|
||||||
nodes = [
|
nodes = [
|
||||||
buildNode('1', name: 'Inbox', role: 'inbox'),
|
buildNode('1', name: 'Inbox', role: 'inbox'),
|
||||||
@@ -177,20 +168,20 @@ void main() {
|
|||||||
final ids = nodes.mailboxIds.map((id) => id.id.value).toList();
|
final ids = nodes.mailboxIds.map((id) => id.id.value).toList();
|
||||||
expect(ids, ['1', '2']);
|
expect(ids, ['1', '2']);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('should insert into empty list as first element', () {
|
||||||
|
nodes = [];
|
||||||
|
final newNode = buildNode('1', name: 'Starred', role: 'favorite');
|
||||||
|
nodes.insertAfterStarredOrInbox(newNode);
|
||||||
|
|
||||||
|
final ids = nodes.mailboxIds.map((id) => id.id.value).toList();
|
||||||
|
expect(ids, ['1']);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
group('ListMailboxNodeExtension::insertAfterByPriority', () {
|
group('ListMailboxNodeExtension::insertAfterByPriority', () {
|
||||||
late List<MailboxNode> nodes;
|
late List<MailboxNode> nodes;
|
||||||
|
|
||||||
MailboxNode buildNode(String id, {String? name, String? role}) {
|
|
||||||
final mailbox = PresentationMailbox(
|
|
||||||
MailboxId(Id(id)),
|
|
||||||
name: name != null ? MailboxName(name) : null,
|
|
||||||
role: role != null ? Role(role) : null,
|
|
||||||
);
|
|
||||||
return MailboxNode(mailbox);
|
|
||||||
}
|
|
||||||
|
|
||||||
bool isInbox(MailboxNode node) =>
|
bool isInbox(MailboxNode node) =>
|
||||||
node.item.role?.value == PresentationMailbox.inboxRole ||
|
node.item.role?.value == PresentationMailbox.inboxRole ||
|
||||||
node.item.name?.name.toLowerCase() == 'inbox';
|
node.item.name?.name.toLowerCase() == 'inbox';
|
||||||
|
|||||||
Reference in New Issue
Block a user