eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-4301 Address code review comments on label feature

Browse Source 
- Make LabelModalMixin interactor getters non-nullable; remove force-unwraps at call sites
- Show positiveLabel and add semanticLabel in progressing button for accessibility
- Use timestamp-based label name in E2E scenario to prevent flakiness on reused accounts
- Guard labelAs action with isLabelAvailable check in SingleEmailController
- Don't pop back on label creation failure so users can retry without losing context
- Block modal dismissal while label creation request is in flight
- Null-guard email.id before toggling label in ThreadView::onCreateANewLabelAction
- Log stackTrace and rethrow in DialogRouter to distinguish errors from user cancel
This commit is contained in:
dab246
2026-04-16 17:10:43 +07:00
committed by Dat H. Pham
parent 232987ae0c
commit 660c4f40e2
8 changed files with 33 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration_test/scenarios/labels/create_a_new_tag_from_an_email_scenario.dart
+1 -1
View File
@@ -49,7 +49,7 @@ class CreateANewTagFromAnEmailScenario extends BaseTestScenario
await addLabelModalRobot.tapCreateANewLabel();
await _expectCreateNewLabelModalVisible();
const newLabelName = 'New Label 1';
final newLabelName = 'New Label ${DateTime.now().microsecondsSinceEpoch}';
await createLabelModalRobot.enterNewLabelName(newLabelName);
await createLabelModalRobot.tapPositiveActionButton(LabelActionType.create);
await _expectLabelAsToEmailToastMessageSuccessVisible(