TF-4301 Address code review comments on label feature

- Make LabelModalMixin interactor getters non-nullable; remove force-unwraps at call sites
- Show positiveLabel and add semanticLabel in progressing button for accessibility
- Use timestamp-based label name in E2E scenario to prevent flakiness on reused accounts
- Guard labelAs action with isLabelAvailable check in SingleEmailController
- Don't pop back on label creation failure so users can retry without losing context
- Block modal dismissal while label creation request is in flight
- Null-guard email.id before toggling label in ThreadView::onCreateANewLabelAction
- Log stackTrace and rethrow in DialogRouter to distinguish errors from user cancel
This commit is contained in:
dab246
2026-04-16 17:10:43 +07:00
committed by Dat H. Pham
parent 232987ae0c
commit 660c4f40e2
8 changed files with 33 additions and 20 deletions
@@ -952,6 +952,9 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
pressEmailAction(actionType, presentationEmail);
break;
case EmailActionType.labelAs:
if (!isLabelAvailable) {
return;
}
mailboxDashBoardController.openAddLabelToEmailDialogModal(
email: presentationEmail,
onCreateANewLabelAction: () {
@@ -107,10 +107,10 @@ class LabelController extends BaseController
}
@override
CreateNewLabelInteractor? get createNewLabelInteractor => _createNewLabelInteractor;
CreateNewLabelInteractor get createNewLabelInteractor => _createNewLabelInteractor!;
@override
EditLabelInteractor? get editLabelInteractor => _editLabelInteractor;
EditLabelInteractor get editLabelInteractor => _editLabelInteractor!;
DeleteALabelInteractor? get deleteALabelInteractor => _deleteALabelInteractor;
@@ -221,9 +221,6 @@ class LabelController extends BaseController
bool shouldPop = false,
}) {
toastManager.showMessageFailure(failure);
if (shouldPop) {
popBack();
}
}
void _addLabelToList(Label newLabel) {
@@ -12,8 +12,8 @@ import 'package:tmail_ui_user/main/routes/dialog_router.dart';
mixin LabelModalMixin {
List<Label> get labels;
ImagePaths get imagePaths;
CreateNewLabelInteractor? get createNewLabelInteractor;
EditLabelInteractor? get editLabelInteractor;
CreateNewLabelInteractor get createNewLabelInteractor;
EditLabelInteractor get editLabelInteractor;
Future<dynamic> openCreateNewLabelModal({
required AccountId accountId,
@@ -26,8 +26,8 @@ mixin LabelModalMixin {
accountId: accountId,
imagePaths: imagePaths,
verifyNameInteractor: verifyNameInteractor,
createNewLabelInteractor: createNewLabelInteractor!,
editLabelInteractor: editLabelInteractor!,
createNewLabelInteractor: createNewLabelInteractor,
editLabelInteractor: editLabelInteractor,
),
dialogLabel: 'create-new-label-modal',
);
@@ -47,8 +47,8 @@ mixin LabelModalMixin {
selectedLabel: selectedLabel,
actionType: LabelActionType.edit,
verifyNameInteractor: verifyNameInteractor,
createNewLabelInteractor: createNewLabelInteractor!,
editLabelInteractor: editLabelInteractor!,
createNewLabelInteractor: createNewLabelInteractor,
editLabelInteractor: editLabelInteractor,
),
dialogLabel: 'edit-label-modal',
);
@@ -422,6 +422,9 @@ class _CreateNewLabelModalState extends State<CreateNewLabelModal> {
}
void _onCloseModal() {
if (_createLabelStateNotifier.value == LabelPositiveButtonState.progressing) {
return;
}
_clearInputFocus();
popBack();
}
@@ -651,11 +651,16 @@ class ThreadView extends GetWidget<ThreadController>
dashboardController.toggleLabelToEmail(emailId, label, isSelected);
},
onCreateANewLabelAction: () {
final emailId = email.id;
if (emailId == null) {
logWarning('ThreadView::onCreateANewLabelAction: Email id is null');
return;
}
dashboardController.labelController.handleLabelActionType(
actionType: LabelActionType.create,
accountId: dashboardController.accountId.value,
onLabelActionCallback: (label) =>
dashboardController.toggleLabelToEmail(email.id!, label, true),
dashboardController.toggleLabelToEmail(emailId, label, true),
);
},
),