TF-4301 Address code review comments on label feature

- Make LabelModalMixin interactor getters non-nullable; remove force-unwraps at call sites
- Show positiveLabel and add semanticLabel in progressing button for accessibility
- Use timestamp-based label name in E2E scenario to prevent flakiness on reused accounts
- Guard labelAs action with isLabelAvailable check in SingleEmailController
- Don't pop back on label creation failure so users can retry without losing context
- Block modal dismissal while label creation request is in flight
- Null-guard email.id before toggling label in ThreadView::onCreateANewLabelAction
- Log stackTrace and rethrow in DialogRouter to distinguish errors from user cancel

core/lib/presentation/views/dialog/modal_list_action_button_widget.dart

@@ -55,14 +55,17 @@ class ModalListActionButtonWidget extends StatelessWidget {
       ),
     );
 
-    Widget progressingButton = const SizedBox(
+    Widget progressingButton = SizedBox(
       height: 48,
       width: 153,
       child: ConfirmDialogButton(
-        label: '',
+        label: positiveLabel,
         padding: EdgeInsets.zero,
         backgroundColor: AppColor.primaryMain,
-        child: CupertinoLoadingWidget(color: Colors.white),
+        child: CupertinoLoadingWidget(
+          color: Colors.white,
+          semanticLabel: positiveLabel,
+        ),
       ),
     );
 

integration_test/scenarios/labels/create_a_new_tag_from_an_email_scenario.dart

@@ -49,7 +49,7 @@ class CreateANewTagFromAnEmailScenario extends BaseTestScenario
     await addLabelModalRobot.tapCreateANewLabel();
     await _expectCreateNewLabelModalVisible();
 
-    const newLabelName = 'New Label 1';
+    final newLabelName = 'New Label ${DateTime.now().microsecondsSinceEpoch}';
     await createLabelModalRobot.enterNewLabelName(newLabelName);
     await createLabelModalRobot.tapPositiveActionButton(LabelActionType.create);
     await _expectLabelAsToEmailToastMessageSuccessVisible(

lib/features/email/presentation/controller/single_email_controller.dart

@@ -952,6 +952,9 @@ class SingleEmailController extends BaseController with AppLoaderMixin {
         pressEmailAction(actionType, presentationEmail);
         break;
       case EmailActionType.labelAs:
+        if (!isLabelAvailable) {
+          return;
+        }
         mailboxDashBoardController.openAddLabelToEmailDialogModal(
           email: presentationEmail,
           onCreateANewLabelAction: () {

lib/features/labels/presentation/label_controller.dart

@@ -107,10 +107,10 @@ class LabelController extends BaseController
   }
 
   @override
-  CreateNewLabelInteractor? get createNewLabelInteractor => _createNewLabelInteractor;
+  CreateNewLabelInteractor get createNewLabelInteractor => _createNewLabelInteractor!;
 
   @override
-  EditLabelInteractor? get editLabelInteractor => _editLabelInteractor;
+  EditLabelInteractor get editLabelInteractor => _editLabelInteractor!;
 
   DeleteALabelInteractor? get deleteALabelInteractor => _deleteALabelInteractor;
 
@@ -221,9 +221,6 @@ class LabelController extends BaseController
     bool shouldPop = false,
   }) {
     toastManager.showMessageFailure(failure);
-    if (shouldPop) {
-      popBack();
-    }
   }
 
   void _addLabelToList(Label newLabel) {

lib/features/labels/presentation/mixin/label_modal_mixin.dart

@@ -12,8 +12,8 @@ import 'package:tmail_ui_user/main/routes/dialog_router.dart';
 mixin LabelModalMixin {
   List<Label> get labels;
   ImagePaths get imagePaths;
-  CreateNewLabelInteractor? get createNewLabelInteractor;
-  EditLabelInteractor? get editLabelInteractor;
+  CreateNewLabelInteractor get createNewLabelInteractor;
+  EditLabelInteractor get editLabelInteractor;
 
   Future<dynamic> openCreateNewLabelModal({
     required AccountId accountId,
@@ -26,8 +26,8 @@ mixin LabelModalMixin {
         accountId: accountId,
         imagePaths: imagePaths,
         verifyNameInteractor: verifyNameInteractor,
-        createNewLabelInteractor: createNewLabelInteractor!,
-        editLabelInteractor: editLabelInteractor!,
+        createNewLabelInteractor: createNewLabelInteractor,
+        editLabelInteractor: editLabelInteractor,
       ),
       dialogLabel: 'create-new-label-modal',
     );
@@ -47,8 +47,8 @@ mixin LabelModalMixin {
         selectedLabel: selectedLabel,
         actionType: LabelActionType.edit,
         verifyNameInteractor: verifyNameInteractor,
-        createNewLabelInteractor: createNewLabelInteractor!,
-        editLabelInteractor: editLabelInteractor!,
+        createNewLabelInteractor: createNewLabelInteractor,
+        editLabelInteractor: editLabelInteractor,
       ),
       dialogLabel: 'edit-label-modal',
     );

lib/features/labels/presentation/widgets/create_new_label_modal.dart

@@ -422,6 +422,9 @@ class _CreateNewLabelModalState extends State<CreateNewLabelModal> {
   }
 
   void _onCloseModal() {
+    if (_createLabelStateNotifier.value == LabelPositiveButtonState.progressing) {
+      return;
+    }
     _clearInputFocus();
     popBack();
   }

lib/features/thread/presentation/thread_view.dart

@@ -651,11 +651,16 @@ class ThreadView extends GetWidget<ThreadController>
           dashboardController.toggleLabelToEmail(emailId, label, isSelected);
         },
         onCreateANewLabelAction: () {
+          final emailId = email.id;
+          if (emailId == null) {
+            logWarning('ThreadView::onCreateANewLabelAction: Email id is null');
+            return;
+          }
           dashboardController.labelController.handleLabelActionType(
             actionType: LabelActionType.create,
             accountId: dashboardController.accountId.value,
             onLabelActionCallback: (label) =>
-                dashboardController.toggleLabelToEmail(email.id!, label, true),
+                dashboardController.toggleLabelToEmail(emailId, label, true),
           );
         },
       ),

lib/main/routes/dialog_router.dart

@@ -41,8 +41,9 @@ class DialogRouter {
       );
 
       return returnedValue;
-    } catch (e) {
-      logWarning('DialogRouter::pushGeneralDialog: Exception = $e');
+    } catch (e, stackTrace) {
+      logWarning('DialogRouter::pushGeneralDialog: Exception = $e\n$stackTrace');
+      rethrow;
     } finally {
       if (PlatformInfo.isWeb) {
         _isMapDialogOpened.remove(routeName);
@@ -112,8 +113,9 @@ class DialogRouter {
         barrierLabel: dialogLabel,
         pageBuilder: (_, __, ___) => child,
       );
-    } catch (e) {
-      logWarning('DialogRouter::openDialogModal: Exception = $e');
+    } catch (e, stackTrace) {
+      logWarning('DialogRouter::openDialogModal: Exception = $e\n$stackTrace');
+      rethrow;
     } finally {
       if (PlatformInfo.isWeb && dialogLabel != null) {
         _isMapDialogOpened.remove(dialogLabel);