TF-3337 Fix open the setting page (Vacation method was call twice)

This commit is contained in:
dab246
2024-12-24 11:06:14 +07:00
committed by Dat H. Pham
parent 2118f3f849
commit ebbca0ee20
2 changed files with 3 additions and 35 deletions
@@ -8,9 +8,7 @@ import 'package:rich_text_composer/rich_text_composer.dart';
import 'package:rich_text_composer/views/commons/constants.dart';
import 'package:tmail_ui_user/features/base/base_controller.dart';
import 'package:tmail_ui_user/features/composer/presentation/controller/rich_text_web_controller.dart';
import 'package:tmail_ui_user/features/manage_account/domain/state/get_all_vacation_state.dart';
import 'package:tmail_ui_user/features/manage_account/domain/state/update_vacation_state.dart';
import 'package:tmail_ui_user/features/manage_account/domain/usecases/get_all_vacation_interactor.dart';
import 'package:tmail_ui_user/features/manage_account/domain/usecases/update_vacation_interactor.dart';
import 'package:tmail_ui_user/features/manage_account/presentation/extensions/vacation_response_extension.dart';
import 'package:tmail_ui_user/features/manage_account/presentation/manage_account_dashboard_controller.dart';
@@ -26,7 +24,6 @@ class VacationController extends BaseController {
final _accountDashBoardController = Get.find<ManageAccountDashBoardController>();
final _settingController = Get.find<SettingsController>();
final GetAllVacationInteractor _getAllVacationInteractor;
final UpdateVacationInteractor _updateVacationInteractor;
final RichTextWebController _richTextControllerForWeb;
@@ -46,7 +43,6 @@ class VacationController extends BaseController {
final ScrollController scrollController = ScrollController();
VacationController(
this._getAllVacationInteractor,
this._updateVacationInteractor,
this._richTextControllerForWeb
);
@@ -62,19 +58,12 @@ class VacationController extends BaseController {
super.onInit();
}
@override
void onReady() {
_getAllVacation();
super.onReady();
}
@override
void handleSuccessViewState(Success success) {
super.handleSuccessViewState(success);
if (success is GetAllVacationSuccess) {
_handleGetAllVacationSuccess(success);
} else if (success is UpdateVacationSuccess) {
if (success is UpdateVacationSuccess) {
_handleUpdateVacationSuccess(success);
} else {
super.handleSuccessViewState(success);
}
}
@@ -98,25 +87,6 @@ class VacationController extends BaseController {
}
}
void _getAllVacation() {
final accountId = _accountDashBoardController.accountId.value;
if (accountId != null) {
consumeState(_getAllVacationInteractor.execute(accountId));
}
}
void _handleGetAllVacationSuccess(GetAllVacationSuccess success) {
if (success.listVacationResponse.isNotEmpty) {
currentVacation = success.listVacationResponse.first;
log('VacationController::_handleGetAllVacationSuccess(): $currentVacation');
if (currentVacation != null) {
final newVacationPresentation = currentVacation!.toVacationPresentation();
_initializeValueForVacation(newVacationPresentation);
}
}
}
void _initializeValueForVacation(VacationPresentation newVacation) {
vacationPresentation.value = newVacation;
subjectTextController.text = newVacation.subject ?? '';
@@ -1,7 +1,6 @@
import 'package:get/get.dart';
import 'package:tmail_ui_user/features/composer/presentation/controller/rich_text_web_controller.dart';
import 'package:tmail_ui_user/features/mailbox_creator/domain/usecases/verify_name_interactor.dart';
import 'package:tmail_ui_user/features/manage_account/domain/usecases/get_all_vacation_interactor.dart';
import 'package:tmail_ui_user/features/manage_account/domain/usecases/update_vacation_interactor.dart';
import 'package:tmail_ui_user/features/manage_account/presentation/vacation/utils/vacation_utils.dart';
import 'package:tmail_ui_user/features/manage_account/presentation/vacation/vacation_controller.dart';
@@ -13,7 +12,6 @@ class VacationControllerBindings extends Bindings {
Get.lazyPut(() => VerifyNameInteractor());
Get.lazyPut(() => RichTextWebController(), tag: VacationUtils.vacationTagName);
Get.put(VacationController(
Get.find<GetAllVacationInteractor>(),
Get.find<UpdateVacationInteractor>(),
Get.find<RichTextWebController>(tag: VacationUtils.vacationTagName),
));