eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TF-4193 Fix all Nitpick comments from coderabbit

Browse Source
This commit is contained in:
dab246
2025-12-10 12:10:17 +07:00
committed by Dat H. Pham
parent ef2ab39a3a
commit 6b1c7e23dc
33 changed files with 20 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/download/data/datasource_impl/download_datasource_impl.dart
+2 -8
View File
@@ -40,10 +40,7 @@ class DownloadDatasourceImpl extends DownloadDatasource {
onReceiveController: onReceiveController,
cancelToken: cancelToken,
);
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
@override
@@ -67,9 +64,6 @@ class DownloadDatasourceImpl extends DownloadDatasource {
onReceiveController: onReceiveController,
cancelToken: cancelToken,
);
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
}
lib/features/labels/data/datasource_impl/label_datasource_impl.dart
+2 -8
View File
@@ -14,19 +14,13 @@ class LabelDatasourceImpl extends LabelDatasource {
Future<List<Label>> getAllLabels(AccountId accountId) {
return Future.sync(() async {
return await _labelApi.getAllLabels(accountId);
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
@override
Future<Label> createNewLabel(AccountId accountId, Label labelData) {
return Future.sync(() async {
return await _labelApi.createNewLabel(accountId, labelData);
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
}
lib/features/login/data/datasource_impl/authentication_oidc_datasource_impl.dart
+1 -4
View File
@@ -180,9 +180,6 @@ class AuthenticationOIDCDataSourceImpl extends AuthenticationOIDCDataSource {
Future<OidcUserInfo> fetchUserInfo(String userInfoEndpoint) {
return Future.sync(() async {
return await _oidcHttpClient.fetchUserInfo(userInfoEndpoint);
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
}
lib/features/login/domain/usecases/delete_authority_oidc_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/login/domain/usecases/delete_credential_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/core.dart';
import 'package:dartz/dartz.dart';
import 'package:tmail_ui_user/features/login/domain/repository/credential_repository.dart';
lib/features/login/domain/usecases/get_credential_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/mailbox/data/datasource_impl/mailbox_datasource_impl.dart
+1 -4
View File
@@ -187,9 +187,6 @@ class MailboxDataSourceImpl extends MailboxDataSource {
onProgressController: onProgressController,
);
}
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
}
lib/features/mailbox_dashboard/domain/usecases/get_all_recent_search_latest_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:core/utils/app_logger.dart';
lib/features/mailbox_dashboard/domain/usecases/save_recent_search_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/core.dart';
import 'package:dartz/dartz.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
lib/features/manage_account/data/datasource_impl/manage_account_datasource_impl.dart
+5 -14
View File
@@ -82,22 +82,16 @@ class ManageAccountDataSourceImpl extends ManageAccountDataSource {
@override
Future<bool> getLabelVisibility() {
return Future.sync(() async {
return await _settingCacheManager.getLabelVisibility();
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
return Future.sync(() {
return _settingCacheManager.getLabelVisibility();
}).catchError(_exceptionThrower.throwException);
}
@override
Future<void> saveLabelVisibility(bool visible) {
return Future.sync(() async {
return await _settingCacheManager.saveLabelVisibility(visible);
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
@override
@@ -105,9 +99,6 @@ class ManageAccountDataSourceImpl extends ManageAccountDataSource {
return Future.sync(() async {
final labelConfig = await _preferencesSettingManager.getLabelConfig();
return labelConfig.isEnabled;
}).catchError((error, stackTrace) async {
await _exceptionThrower.throwException(error, stackTrace);
throw error;
});
}).catchError(_exceptionThrower.throwException);
}
}
lib/features/manage_account/data/local/setting_cache_manager.dart
+1 -2
View File
@@ -7,8 +7,7 @@ class SettingCacheManager {
final SharedPreferences _sharedPreferences;
Future<bool> getLabelVisibility() async {
await _sharedPreferences.reload();
bool getLabelVisibility() {
return _sharedPreferences.getBool(_labelVisibilitySettingKey) ?? false;
}
lib/features/manage_account/domain/usecases/create_new_default_identity_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/create_new_email_rule_filter_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/create_new_identity_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/core.dart';
import 'package:dartz/dartz.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
lib/features/manage_account/domain/usecases/delete_email_rule_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/core.dart';
import 'package:dartz/dartz.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
lib/features/manage_account/domain/usecases/delete_identity_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/edit_default_identity_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/core.dart';
import 'package:dartz/dartz.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
lib/features/manage_account/domain/usecases/edit_email_rule_filter_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/edit_identity_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/get_all_identities_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/get_all_rules_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/core.dart';
import 'package:dartz/dartz.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
lib/features/manage_account/domain/usecases/get_all_vacation_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/get_forward_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/get_label_setting_state_interactor.dart
+2 -2
View File
@@ -13,8 +13,8 @@ class GetLabelSettingStateInteractor {
Stream<Either<Failure, Success>> execute(AccountId accountId) async* {
try {
yield Right(GettingLabelSettingState());
final isEnable = await _manageAccountRepository.getLabelSettingState();
yield Right(GetLabelSettingStateSuccess(isEnable, accountId));
final isEnabled = await _manageAccountRepository.getLabelSettingState();
yield Right(GetLabelSettingStateSuccess(isEnabled, accountId));
} catch (e) {
yield Left(GetLabelSettingStateFailure(e));
}
lib/features/manage_account/domain/usecases/get_label_visibility_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/save_label_visibility_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/domain/usecases/save_language_interactor.dart
-1
View File
@@ -1,4 +1,3 @@
import 'dart:core';
import 'dart:ui';
import 'package:core/presentation/state/failure.dart';
lib/features/manage_account/domain/usecases/transform_list_signature_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:core/utils/app_logger.dart';
lib/features/manage_account/domain/usecases/update_vacation_interactor.dart
-2
View File
@@ -1,5 +1,3 @@
import 'dart:core';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:dartz/dartz.dart';
lib/features/manage_account/presentation/extensions/handle_setup_label_visibility_in_setting_extension.dart
+2 -2
View File
@@ -18,7 +18,7 @@ extension HandleSetupLabelVisibilityInSettingExtension
}
void enableLabelVisibility() {
isLabelVisibility.value = true;
isLabelVisibilityEnabled.value = true;
saveLabelVisibilityInteractor = getBinding<SaveLabelVisibilityInteractor>();
if (saveLabelVisibilityInteractor != null) {
@@ -41,6 +41,6 @@ extension HandleSetupLabelVisibilityInSettingExtension
}
void handleGetLabelVisibilitySuccess(bool visible) {
isLabelVisibility.value = visible;
isLabelVisibilityEnabled.value = visible;
}
}
lib/features/manage_account/presentation/manage_account_dashboard_controller.dart
+1 -1
View File
@@ -77,7 +77,7 @@ class ManageAccountDashBoardController extends ReloadableController
final vacationResponse = Rxn<VacationResponse>();
final dashboardSettingAction = Rxn<UIAction>();
final octetsQuota = Rxn<Quota>();
final isLabelVisibility = RxBool(false);
final isLabelVisibilityEnabled = RxBool(false);
Uri? previousUri;
AccountMenuItem? selectedMenu;
lib/features/manage_account/presentation/menu/settings/settings_view.dart
+1 -1
View File
@@ -32,7 +32,7 @@ class SettingsView extends GetWidget<SettingsController> {
Obx(() {
final labelVisibility = controller
.manageAccountDashboardController
.isLabelVisibility
.isLabelVisibilityEnabled
.value;
final isLabelCapabilitySupported = controller
.manageAccountDashboardController
lib/features/manage_account/presentation/preferences/preferences_view.dart
+2 -2
View File
@@ -55,7 +55,7 @@ class PreferencesView extends GetWidget<PreferencesController> with AppLoaderMix
Obx(
() {
final labelVisibility = controller
.accountDashboardController.isLabelVisibility.value;
.accountDashboardController.isLabelVisibilityEnabled.value;
final isLabelCapabilitySupported = controller
.accountDashboardController
@@ -79,7 +79,7 @@ class PreferencesView extends GetWidget<PreferencesController> with AppLoaderMix
final localSettingOption = controller.localSettings.value;
final isLabelVisibility = controller
.accountDashboardController
.isLabelVisibility;
.isLabelVisibilityEnabled;
if (settingOption == null &&
localSettingOption.configs.isEmpty) {