eduvia/workavia-mail-front
11
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TF-4193 Fix all Nitpick comments from coderabbit

Browse Source
This commit is contained in:
dab246
2025-12-10 12:10:17 +07:00
committed by Dat H. Pham
parent ef2ab39a3a
commit 6b1c7e23dc
33 changed files with 20 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/features/manage_account/presentation/extensions/handle_setup_label_visibility_in_setting_extension.dart
+2 -2
View File
@@ -18,7 +18,7 @@ extension HandleSetupLabelVisibilityInSettingExtension
}
void enableLabelVisibility() {
isLabelVisibility.value = true;
isLabelVisibilityEnabled.value = true;
saveLabelVisibilityInteractor = getBinding<SaveLabelVisibilityInteractor>();
if (saveLabelVisibilityInteractor != null) {
@@ -41,6 +41,6 @@ extension HandleSetupLabelVisibilityInSettingExtension
}
void handleGetLabelVisibilitySuccess(bool visible) {
isLabelVisibility.value = visible;
isLabelVisibilityEnabled.value = visible;
}
}
lib/features/manage_account/presentation/manage_account_dashboard_controller.dart
+1 -1
View File
@@ -77,7 +77,7 @@ class ManageAccountDashBoardController extends ReloadableController
final vacationResponse = Rxn<VacationResponse>();
final dashboardSettingAction = Rxn<UIAction>();
final octetsQuota = Rxn<Quota>();
final isLabelVisibility = RxBool(false);
final isLabelVisibilityEnabled = RxBool(false);
Uri? previousUri;
AccountMenuItem? selectedMenu;
lib/features/manage_account/presentation/menu/settings/settings_view.dart
+1 -1
View File
@@ -32,7 +32,7 @@ class SettingsView extends GetWidget<SettingsController> {
Obx(() {
final labelVisibility = controller
.manageAccountDashboardController
.isLabelVisibility
.isLabelVisibilityEnabled
.value;
final isLabelCapabilitySupported = controller
.manageAccountDashboardController
lib/features/manage_account/presentation/preferences/preferences_view.dart
+2 -2
View File
@@ -55,7 +55,7 @@ class PreferencesView extends GetWidget<PreferencesController> with AppLoaderMix
Obx(
() {
final labelVisibility = controller
.accountDashboardController.isLabelVisibility.value;
.accountDashboardController.isLabelVisibilityEnabled.value;
final isLabelCapabilitySupported = controller
.accountDashboardController
@@ -79,7 +79,7 @@ class PreferencesView extends GetWidget<PreferencesController> with AppLoaderMix
final localSettingOption = controller.localSettings.value;
final isLabelVisibility = controller
.accountDashboardController
.isLabelVisibility;
.isLabelVisibilityEnabled;
if (settingOption == null &&
localSettingOption.configs.isEmpty) {